Skip to contentSkip to conversation

powerpc: fix dcr_unmap()

PATCH In review Jean-Christophe Dubois 3 participants 4 messages Mar 28, 2007 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: fix dcr_unmap()

Fix a bug in dcr_unmap().

At unmap time the DCR offset need to be added instead of substracted.

arch/powerpc/sysdev/dcr.c +1 -1
Index: linux-2.6.20/arch/powerpc/sysdev/dcr.c
===================================================================
@@ -129,7 +129,7 @@ void dcr_unmap(dcr_host_t host, unsigned
 
 	if (h.token == NULL)
 		return;
-	h.token -= dcr_n * h.stride;
+	h.token += dcr_n * h.stride;
 	iounmap(h.token);
 	h.token = NULL;
 }
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Jean-Christophe Dubois

Fix a bug in dcr_unmap().

At unmap time the DCR offset need to be added instead of substracted.

---

If possible that should go in 2.6.21

Quoted 17 lines

Index: linux-2.6.20/arch/powerpc/sysdev/dcr.c
===================================================================

arch/powerpc/sysdev/dcr.c +1 -1
@@ -129,7 +129,7 @@ void dcr_unmap(dcr_host_t host, unsigned
 
 	if (h.token == NULL)
 		return;
-	h.token -= dcr_n * h.stride;
+	h.token += dcr_n * h.stride;
 	iounmap(h.token);
 	h.token = NULL;
 }

_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev

#2 lore raw
Quoted 11 lines · Benjamin Herrenschmidt
Quoted 5 lines · Jean-Christophe Dubois

Fix a bug in dcr_unmap().

At unmap time the DCR offset need to be added instead of substracted.

---

If possible that should go in 2.6.21

Can I get an original patch email and/or a git pull request? I didn't see the original email, since I'm not on the linuxppc list..

Linus

#3 lore raw
Quoted 10 lines · Linus Torvalds
Quoted 7 lines · Benjamin Herrenschmidt
Quoted 5 lines · Jean-Christophe Dubois

Fix a bug in dcr_unmap().

At unmap time the DCR offset need to be added instead of substracted.

Quoted 7 lines
Quoted 4 lines

---

If possible that should go in 2.6.21

Can I get an original patch email and/or a git pull request? I didn't see the original email, since I'm not on the linuxppc list..

Sorry about that, I'll bounce it to you