Skip to contentSkip to conversation

blackfin arch fix stamp537 ISP1716 IRQ setting bug

PATCH In review Wu, Bryan 2 participants 3 messages Mar 29, 2007

lore
Share & tools
lore

Wu, Bryan

author
#0 lore raw

PATCH 1/1 blackfin arch fix stamp537 ISP1716 IRQ setting bug

---
 arch/blackfin/mach-bf537/boards/stamp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
(quoted diff) +0 -0

b/arch/blackfin/mach-bf537/boards/stamp.c
index 0f90ff9..a4219df 100644

arch/blackfin/mach-bf537/boards/stamp.c +1 -1
@@ -68,7 +68,7 @@ static struct resource bfin_isp1761_resources[] = {
 	[1] = {
 		.start  = ISP1761_IRQ,
 		.end    = ISP1761_IRQ,
-		.flags  = IORESOURCE_IRQ | IORESOURCE_IRQ_LOWLEVEL,
+		.flags  = IORESOURCE_IRQ,
 	},
 };
 
Signature · 1 line
1.5.0.5
author
#1 lore raw

Sorry for word wrap. this one is ok.

---
 arch/blackfin/mach-bf537/boards/stamp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/blackfin/mach-bf537/boards/stamp.c +1 -1
index 0f90ff9..a4219df 100644
@@ -68,7 +68,7 @@ static struct resource bfin_isp1761_resources[] = {
 	[1] = {
 		.start  = ISP1761_IRQ,
 		.end    = ISP1761_IRQ,
-		.flags  = IORESOURCE_IRQ | IORESOURCE_IRQ_LOWLEVEL,
+		.flags  = IORESOURCE_IRQ,
 	},
 };
 
Signature · 1 line
1.5.0.5
#2 lore raw

arch/blackfin/mach-bf537/boards/stamp.c static struct resource bfin_isp1761_resources[] = { · line 74

Quoted 13 lines · Bryan
arch/blackfin/mach-bf537/boards/stamp.c +1 -1
index 0f90ff9..a4219df 100644
@@ -68,7 +68,7 @@ static struct resource bfin_isp1761_resources[] = {
 	[1] = {
 		.start  = ISP1761_IRQ,
 		.end    = ISP1761_IRQ,
-		.flags  = IORESOURCE_IRQ | IORESOURCE_IRQ_LOWLEVEL,
+		.flags  = IORESOURCE_IRQ,
 	},
 };
 

So you've left the logic for set_irq_type(), yes? In that case, this looks fine.

I'd add an Acked-by, but it probably doesn't matter :-)