Skip to contentSkip to conversation

doc: atomic_add_unless() doesn't imply mb() on failure

PATCH Superseded Oleg Nesterov 2 participants 2 messages Nov 30, 2006

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 doc: atomic_add_unless() doesn't imply mb() on failure

Most implementations of atomic_add_unless() can fail (return 0) after the first atomic_read() (before cmpxchg). In that case we have a compiler barrier only.

 Documentation/atomic_ops.txt      |    3 ++-
 Documentation/memory-barriers.txt |    2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)
Documentation/memory-barriers.txt renamed from Documentation/memory-barriers.txt~doc +1 -1
@@ -1492,7 +1492,7 @@ about the state (old or new) implies an 
 	atomic_dec_and_test();
 	atomic_sub_and_test();
 	atomic_add_negative();
-	atomic_add_unless();
+	atomic_add_unless();	/* when succeeds (returns 1) */
 	test_and_set_bit();
 	test_and_clear_bit();
 	test_and_change_bit();
Documentation/atomic_ops.txt renamed from Documentation/atomic_ops.txt~doc +2 -1
@@ -137,7 +137,8 @@ If the atomic value v is not equal to u,
 returns non zero. If v is equal to u then it returns zero. This is done as
 an atomic operation.
 
-atomic_add_unless requires explicit memory barriers around the operation.
+atomic_add_unless requires explicit memory barriers around the operation
+unless it fails (returns 0).
 
 atomic_inc_not_zero, equivalent to atomic_add_unless(v, 1, 0)
 
maintainer
#1 lore raw
Quoted 3 lines · Oleg Nesterov

Most implementations of atomic_add_unless() can fail (return 0) after the first atomic_read() (before cmpxchg). In that case we have a compiler barrier only.

Ummm... I wonder if we should instead change the behaviour of atomic_add_unless() to include an explicit smp_rmb() between the read and the conditional jump on all archs where this isn't already implied. Otherwise, what governs when the initial test going to be done by the CPU?

Note that not all archs do cmpxchg() here, though I don't think that affects your argument.

David