blackfin arch: use boot_command_line instead of save_command_line in setup c file
PATCH 1/1 blackfin arch: use boot_command_line instead of save_command_line in setup c file
--- arch/blackfin/kernel/setup.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/blackfin/kernel/setup.c +1 -1
@@ -221,7 +221,7 @@ void __init setup_arch(char **cmdline_p)/* Keep a copy of command line */ *cmdline_p = &command_line[0 ]; -memcpy (saved_command_line, command_line,COMMAND_LINE_SIZE ); +memcpy (boot_command_line, command_line,COMMAND_LINE_SIZE ); saved_command_line[COMMAND_LINE_SIZE -1 ] =0 ;/* setup memory defaults from the user config */
Signature · 1 line
1.5.0.5
Quoted 12 lines · Bryan
Signed-off-by Bryan Wu <[email protected]>--- arch/blackfin/kernel/setup.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/blackfin/kernel/setup.c +0
-0
arch/blackfin/kernel/setup.c void __init setup_arch(char **cmdline_p) · line 227
Quoted 8 lines
arch/blackfin/kernel/setup.c +1
-1@@ -221,7 +221,7 @@ void __init setup_arch(char **cmdline_p)/* Keep a copy of command line */ *cmdline_p = &command_line[0 ]; -memcpy (saved_command_line, command_line,COMMAND_LINE_SIZE ); +memcpy (boot_command_line, command_line,COMMAND_LINE_SIZE ); saved_command_line[COMMAND_LINE_SIZE -1 ] =0 ;/* setup memory defaults from the user config */
Hi Bryan,
Patch descriptions should include _why_ a change is being made, not just what the change is.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
Quoted 20 lines · Randy Dunlap
Quoted 18 lines · Bryan
Signed-off-by Bryan Wu <[email protected]>--- arch/blackfin/kernel/setup.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/blackfin/kernel/setup.c +1
-1@@ -221,7 +221,7 @@ void __init setup_arch(char **cmdline_p)/* Keep a copy of command line */ *cmdline_p = &command_line[0 ]; -memcpy (saved_command_line, command_line,COMMAND_LINE_SIZE ); +memcpy (boot_command_line, command_line,COMMAND_LINE_SIZE ); saved_command_line[COMMAND_LINE_SIZE -1 ] =0 ;
Quoted 8 lines
arch/blackfin/kernel/setup.c void __init setup_arch(char **cmdline_p) · line 227
Quoted 2 lines
arch/blackfin/kernel/setup.c +0
-0/* setup memory defaults from the user config */ Hi Bryan,
Patch descriptions should include _why_ a change is being made, not just what the change is.
Thanks Randy. I am just confused by the following comments in -mm tree init/main.c:
---
/* Untouched command line saved by arch-specific code. */ char __initdata boot_command_line[COMMAND_LINE_SIZE];
/* Untouched saved command line (eg. for /proc) */
char *saved_command_line;
---
And you know, in the 2.6.20.x stable kernel init/main.c:
---
/* Untouched command line (eg. for /proc) saved by arch-specific code. */ char saved_command_line[COMMAND_LINE_SIZE];
---
So the patch is to move saved_command_line to boot_command_line in blackfin arch code. I will resend a new patch about this, because I forgot to change :-<
---
- saved_command_line[COMMAND_LINE_SIZE - 1] = 0;
+ boot_command_line[COMMAND_LINE_SIZE - 1] = 0;
---
Did I misunderstand about this? So some other arch (ARM/AVR32 ...) should be updated, too.
Quoted 3 lines
---
~Randy
*** Remember to useDocumentation/SubmitChecklistwhen testing your code ***
Thanks again Randy.
I will follow the rule.
-Bryan
PATCH 1/1 blackfin arch: use boot_command_line instead of saved_command_line in setup c file
[PATCH] blackfin arch
As boot_command_line is added in init/main.c for arch-specific boot command line, replace old saved_command_line to boot_command_line for right boot command passing in -mm tree.
--- arch/blackfin/kernel/setup.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
arch/blackfin/kernel/setup.c +2 -2
@@ -221,8 +221,8 @@ void __init setup_arch(char **cmdline_p)/* Keep a copy of command line */ *cmdline_p = &command_line[0 ]; -memcpy (saved_command_line, command_line,COMMAND_LINE_SIZE ); - saved_command_line[COMMAND_LINE_SIZE -1 ] =0 ; +memcpy (boot_command_line, command_line,COMMAND_LINE_SIZE ); + boot_command_line[COMMAND_LINE_SIZE -1 ] =0 ;/* setup memory defaults from the user config */ physical_mem_end =0 ;
Signature · 1 line
1.5.0.5