Skip to contentSkip to conversation

Problems with upstream SPECTRE mitigation found in sendmsg/recvmsg syscalls

PATCH New François Legal 1 participant 1 message Dec 7, 2020

lore
Share & tools
lore
#0 lore raw

cover Problems with upstream SPECTRE mitigation found in sendmsg/recvmsg syscalls

From: François LEGAL <[email protected]>

The syscall entry code used to copy the struct user_msghdr on the syscall stack, and some registered callbacks (notably in RTNet) were then calling again copy_from/to_user on that struct, which would trigger the SPECTRE mitigation protection.

I ran the iddp/xddp/bufp-label tests which seems ok with the patch, and retested RTNet af_packet part I did not test the rtcan part as I have no hardware available.

 kernel/cobalt/posix/io.c          | 20 ++------------------
 kernel/drivers/can/rtcan_raw.c    | 37 +++++++++++++++++++++++++++++--------
 kernel/drivers/ipc/bufp.c         | 14 ++++++++++++--
 kernel/drivers/ipc/iddp.c         | 14 ++++++++++++--
 kernel/drivers/ipc/xddp.c         | 14 ++++++++++++--
 5 files changed, 67 insertions(+), 32 deletions(-)