Skip to contentSkip to conversation

statistics: fix sorted list

PATCH New Martin Peschke 1 participant 1 message Apr 14, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 statistics: fix sorted list

The list of statistics entries maintained by type 'sparse' might have shown unsorted entries with regard to the number of reported hits. The reason was that new entries were always added at the tail of the list regardless of the number of hits they came with. Unsorted lists might suffer a performance loss.

Fix is to sort the list by hits after entry insertion, i.e. moving entries added at the tail up the chain, which should not be required very often (usually just when merging per-cpu lists).

Patch is against 2.6.21-rc6-mm1.

---

 statistic.c |    1 +
 1 file changed, 1 insertion(+)
lib/statistic.c +1 -0
Index: linux/lib/statistic.c
===================================================================
@@ -1113,6 +1113,7 @@ static int statistic_add_sparse_new(stru
 	entry->hits = incr;
 	slist->entries++;
 	list_add_tail(&entry->list, &slist->entry_lh);
+	statistic_sort_sparse(&slist->entry_lh, entry);
 	return 0;
 }