Clean up the warning message about RCU not defined
PATCH 1/1 Clean up the warning message about RCU not defined
(This fix is for commit 4765c1db84c73f775eb1822a009117cbae524e9e
Titled "rcu-tiny: The Bloatwatch Edition, v6")
When the kernel is built, there is some message printed as following:
include/linux/rcupdate.h:80:7: \
warning: "CONFIG_TINY_RCU" is not defined
So I did "grep _RCU .config" to search the information of "CONFIG_TINY_RCU" in .config file and the result is listed as following:
Command:
grep _RCU .config
Result:
CONFIG_TREE_RCU=y
# CONFIG_TREE_PREEMPT_RCU is not set
# CONFIG_TINY_RCU is not set
CONFIG_RCU_TRACE=y
CONFIG_RCU_FANOUT=64
# CONFIG_RCU_FANOUT_EXACT is not set CONFIG_TREE_RCU_TRACE=y
# CONFIG_RCU_TORTURE_TEST is not set
# CONFIG_RCU_CPU_STALL_DETECTOR is not set
Though the "WARNING" does not give impact to build kernel, I think it should be cleaned up. And I made the patch for modifying it. With this patch there is not any other warning message of CONFIG_TINY_RCU and the kernel could be built successfully. And I confirmed that the built kernel works well.
--- include/linux/rcupdate.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/rcupdate.h +1 -1
@@ -77,7 +77,7 @@ extern int rcu_scheduler_active;#if defined(CONFIG_TREE_RCU ) || defined(CONFIG_TREE_PREEMPT_RCU )#include <linux/rcutree.h> -#elif CONFIG_TINY_RCU +#elif defined(CONFIG_TINY_RCU )#include <linux/rcutiny.h> #else #error "Unknown RCU implementation specified to kernel configuration"
Signature · 1 line
1.6.2.2
Quoted 23 lines · Jin Dongming
(This fix is for commit
4765c1db84c73f775eb1822a009117cbae524e9e
Titled "rcu-tiny: The Bloatwatch Edition, v6")When the kernel is built, there is some message printed as following:
include/linux/rcupdate.h:80:7: \
warning: "CONFIG_TINY_RCU" is not definedSo I did "grep
_RCU.config" to search the information of "CONFIG_TINY_RCU" in .config file and the result is listed as following:
Command:
grep_RCU.config
Result:
CONFIG_TREE_RCU=y
#CONFIG_TREE_PREEMPT_RCUis not set
#CONFIG_TINY_RCUis not set
CONFIG_RCU_TRACE=y
CONFIG_RCU_FANOUT=64
#CONFIG_RCU_FANOUT_EXACTis not setCONFIG_TREE_RCU_TRACE=y
#CONFIG_RCU_TORTURE_TESTis not set
#CONFIG_RCU_CPU_STALL_DETECTORis not set
Quoted 5 lines
Though the "WARNING" does not give impact to build kernel, I think it should be cleaned up. And I made the patch for modifying it. With this patch there is not any other warning message of
CONFIG_TINY_RCUand the kernel could be built successfully. And I confirmed that the built kernel works well.
Good catch!!!
Quoted 26 lines
Signed-off-by Jin Dongming <[email protected]>--- include/linux/rcupdate.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)include/linux/rcupdate.h +1
-1@@ -77,7 +77,7 @@ extern int rcu_scheduler_active;#if defined(CONFIG_TREE_RCU ) || defined(CONFIG_TREE_PREEMPT_RCU )#include <linux/rcutree.h> -#elif CONFIG_TINY_RCU +#elif defined(CONFIG_TINY_RCU )#include <linux/rcutiny.h> #else #error "Unknown RCU implementation specified to kernel configuration"Signature · 7 lines
1.6.2.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Quoted 23 lines · Jin Dongming
(This fix is for commit
4765c1db84c73f775eb1822a009117cbae524e9e
Titled "rcu-tiny: The Bloatwatch Edition, v6")When the kernel is built, there is some message printed as following:
include/linux/rcupdate.h:80:7: \
warning: "CONFIG_TINY_RCU" is not definedSo I did "grep
_RCU.config" to search the information of "CONFIG_TINY_RCU" in .config file and the result is listed as following:
Command:
grep_RCU.config
Result:
CONFIG_TREE_RCU=y
#CONFIG_TREE_PREEMPT_RCUis not set
#CONFIG_TINY_RCUis not set
CONFIG_RCU_TRACE=y
CONFIG_RCU_FANOUT=64
#CONFIG_RCU_FANOUT_EXACTis not setCONFIG_TREE_RCU_TRACE=y
#CONFIG_RCU_TORTURE_TESTis not set
#CONFIG_RCU_CPU_STALL_DETECTORis not set
Quoted 7 lines
Though the "WARNING" does not give impact to build kernel, I think it should be cleaned up. And I made the patch for modifying it. With this patch there is not any other warning message of
CONFIG_TINY_RCUand the kernel could be built successfully. And I confirmed that the built kernel works well.Signed-off-by Jin Dongming <[email protected]>
[tip:core/rcu] rcu: Clean up the warning message about RCU not defined
In reply to Jin DongmingCommit-ID: 5ef9b8e59c043624fb44e31439cecf7f8b4cd62a Gitweb: http://git.kernel.org/tip/5ef9b8e59c043624fb44e31439cecf7f8b4cd62a Author: Jin Dongming <[email protected]> AuthorDate: Fri, 25 Sep 2009 13:52:59 +0900 Committer: Ingo Molnar <[email protected]> CommitDate: Sat, 26 Sep 2009 14:33:41 +0200
rcu: Clean up the warning message about RCU not defined
When the kernel is built, there is some message printed as following:
include/linux/rcupdate.h:80:7: \
warning: "CONFIG_TINY_RCU" is not defined
So I did "grep _RCU .config" to search the information of "CONFIG_TINY_RCU" in .config file and the result is listed as following:
Command:
grep _RCU .config
Result:
CONFIG_TREE_RCU=y
# CONFIG_TREE_PREEMPT_RCU is not set # CONFIG_TINY_RCU is not set CONFIG_RCU_TRACE=y CONFIG_RCU_FANOUT=64
# CONFIG_RCU_FANOUT_EXACT is not set CONFIG_TREE_RCU_TRACE=y
# CONFIG_RCU_TORTURE_TEST is not set # CONFIG_RCU_CPU_STALL_DETECTOR is not set
Though the "WARNING" does not give impact to build kernel, I think it should be cleaned up. And I made the patch for modifying it. With this patch there is not any other warning message of CONFIG_TINY_RCU and the kernel could be built successfully. And I confirmed that the built kernel works well.
LKML-Reference: <[email protected]>
--- include/linux/rcupdate.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/rcupdate.h +1 -1
@@ -77,7 +77,7 @@ extern int rcu_scheduler_active;#if defined(CONFIG_TREE_RCU ) || defined(CONFIG_TREE_PREEMPT_RCU )#include <linux/rcutree.h> -#elif CONFIG_TINY_RCU +#elif defined(CONFIG_TINY_RCU )#include <linux/rcutiny.h> #else #error "Unknown RCU implementation specified to kernel configuration"