Skip to contentSkip to conversation

Remove deprecated /proc/acpi/processor/performance write support

PATCH New Thomas Renninger 1 participant 1 message Apr 19, 2007

Subsystems (2)
ACPI CPU frequency scaling framework
lore
Share & tools
lore

Thomas Renninger

author
#0 lore raw

PATCH 2/2 Remove deprecated /proc/acpi/processor/performance write support

I also sent this a while ago and got a ok from Dominik. Don't know how to provide a link to the archive, the link added at each mail posted to the cpufreq list at the end:
http://lists.linux.org.uk/mailman/listinfo/cpufreq
seems to be dead.

The message was:
-----------------------------------------------------------
Mon, 2 Oct 2006 20:29
Re: [PATCH] Disallow writing to /proc/acpi/processor/xy/performance

Quoted 4 lines · Thomas Renninger
Quoted 3 lines · Thomas Renninger

Makes the cpufreq stuff at least a bit easier...

Compile tested, patched against 2.6.18-rc2

Somehow I like this patch. What's the status on it?

Thanks,
Dominik
-----------------------------------------------------------

So here it is again, can it please be added in 2.6.22.

Thanks,

Thomas

Remove deprecated /proc/acpi/processor/performance write support

Writing to /proc/acpi/processor/xy/performance interferes with sysfs cpufreq interface. Also removes buggy cpufreq_set_policy exported symbol.

Signed-off-by Thomas Renninger <[email protected]>
---
 drivers/acpi/processor_perflib.c |   45 ---------------------------------------
 drivers/cpufreq/cpufreq.c        |   37 --------------------------------
 include/linux/cpufreq.h          |    1 
 3 files changed, 1 insertion(+), 82 deletions(-)
drivers/cpufreq/cpufreq.c +0 -37
Index: linux-2.6.20/drivers/cpufreq/cpufreq.c
===================================================================
@@ -1626,43 +1626,6 @@ error_out:
 }
 
 /**
- *	cpufreq_set_policy - set a new CPUFreq policy
- *	@policy: policy to be set.
- *
- *	Sets a new CPU frequency and voltage scaling policy.
- */
-int cpufreq_set_policy(struct cpufreq_policy *policy)
-{
-	int ret = 0;
-	struct cpufreq_policy *data;
-
-	if (!policy)
-		return -EINVAL;
-
-	data = cpufreq_cpu_get(policy->cpu);
-	if (!data)
-		return -EINVAL;
-
-	if (unlikely(lock_policy_rwsem_write(policy->cpu)))
-		return -EINVAL;
-
-
-	ret = __cpufreq_set_policy(data, policy);
-	data->user_policy.min = data->min;
-	data->user_policy.max = data->max;
-	data->user_policy.policy = data->policy;
-	data->user_policy.governor = data->governor;
-
-	unlock_policy_rwsem_write(policy->cpu);
-
-	cpufreq_cpu_put(data);
-
-	return ret;
-}
-EXPORT_SYMBOL(cpufreq_set_policy);
-
-
-/**
  *	cpufreq_update_policy - re-evaluate an existing cpufreq policy
  *	@cpu: CPU which shall be re-evaluated
  *
include/linux/cpufreq.h +0 -1
Index: linux-2.6.20/include/linux/cpufreq.h
===================================================================
@@ -257,7 +257,6 @@ struct freq_attr {
 /*********************************************************************
  *                        CPUFREQ 2.6. INTERFACE                     *
  *********************************************************************/
-int cpufreq_set_policy(struct cpufreq_policy *policy);
 int cpufreq_get_policy(struct cpufreq_policy *policy, unsigned int cpu);
 int cpufreq_update_policy(unsigned int cpu);
drivers/acpi/processor_perflib.c +1 -44

57 lines not on this page · raw message