libltpnuma: remove restrictions on numa node-id
PATCH 2/2 libltpnuma: remove restrictions on numa node-id
For some ppc64le systems, it has non-continuous numa nodes in hardware configuration. So we're hitting the below warnings while running set_mempolicy tests on that. To fix this issue, let's just remove restrictions on numa node-id in get_mempolicy().
Error Log
---------
tst_test.c:1096: INFO: Timeout per run is 0h 50m 00s tst_numa.c:190: INFO: Found 2 NUMA memory nodes set_mempolicy01.c:63: PASS: set_mempolicy(MPOL_BIND) node 0 tst_numa.c:26: INFO: Node 0 allocated 16 pages tst_numa.c:26: INFO: Node 8 allocated 0 pages set_mempolicy01.c:82: PASS: child: Node 0 allocated 16 set_mempolicy01.c:63: PASS: set_mempolicy(MPOL_BIND) node 8 tst_numa.c:92: WARN: get_mempolicy(...) returned invalid node 8 tst_numa.c:92: WARN: get_mempolicy(...) returned invalid node 8 tst_numa.c:92: WARN: get_mempolicy(...) returned invalid node 8
...
tst_numa.c:26: INFO: Node 0 allocated 0 pages tst_numa.c:26: INFO: Node 8 allocated 0 pages set_mempolicy01.c:86: FAIL: child: Node 8 allocated 0, expected 16
lscpu
-----
Architecture: ppc64le
...
CPU(s): 128 Core(s) per socket: 16 Socket(s): 2 NUMA node(s): 2 Model name: POWER9, altivec supported ... NUMA node0 CPU(s): 0-63 NUMA node8 CPU(s): 64-127
--- libs/libltpnuma/tst_numa.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
libs/libltpnuma/tst_numa.c +3 -2
@@ -88,8 +88,9 @@ void tst_nodemap_count_pages(struct tst_nodemap *nodes,if (ret <0 )tst_brk (TBROK |TERRNO ,"get_mempolicy() failed" ); -if (node <0 || (unsigned int )node >= nodes->cnt) { -tst_res (TWARN ,"get_mempolicy(...) returned invalid node %i\n" , node); +if (node <0 ) { +tst_res (TWARN , +"get_mempolicy(...) returned invalid node %i\n" , node);continue ; }
Signature · 1 line
2.20.1
PATCH 2/2 libltpnuma: remove restrictions on numa node-id
----- Original Message -----
Quoted 57 lines
For some ppc64le systems, it has non-continuous numa nodes in hardware configuration. So we're hitting the below warnings while running
set_mempolicytests on that. To fix this issue, let's just remove restrictions on numa node-id inget_mempolicy().Error Log
---------
tst_test.c:1096: INFO: Timeout per run is 0h 50m 00s tst_numa.c:190: INFO: Found 2 NUMA memory nodes set_mempolicy01.c:63: PASS:set_mempolicy(MPOL_BIND)node 0 tst_numa.c:26: INFO: Node 0 allocated 16 pages tst_numa.c:26: INFO: Node 8 allocated 0 pages set_mempolicy01.c:82: PASS: child: Node 0 allocated 16 set_mempolicy01.c:63: PASS:set_mempolicy(MPOL_BIND)node 8 tst_numa.c:92: WARN:get_mempolicy(...)returned invalid node 8 tst_numa.c:92: WARN:get_mempolicy(...)returned invalid node 8 tst_numa.c:92: WARN:get_mempolicy(...)returned invalid node 8
...
tst_numa.c:26: INFO: Node 0 allocated 0 pages tst_numa.c:26: INFO: Node 8 allocated 0 pages set_mempolicy01.c:86: FAIL: child: Node 8 allocated 0, expected 16lscpu
-----
Architecture: ppc64le
...CPU(s): 128 Core(s) per socket: 16 Socket(s): 2 NUMA node(s): 2 Model name: POWER9, altivec supported ... NUMA node0 CPU(s): 0-63 NUMA node8 CPU(s): 64-127Signed-off-by Li Wang <[email protected]>--- libs/libltpnuma/tst_numa.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)libs/libltpnuma/tst_numa.c +3
-3@@ -88,8 +88,9 @@ void tst_nodemap_count_pages(struct tst_nodemap *nodes,if (ret <0 )tst_brk (TBROK |TERRNO ,"get_mempolicy() failed" ); -if (node <0 || (unsigned int )node >= nodes->cnt) { -tst_res (TWARN ,"get_mempolicy(...) returned invalid node %i\n" , node); +if (node <0 ) { +tst_res (TWARN , +"get_mempolicy(...) returned invalid node %i\n" , node);continue ; } --
Quoted 1 line
2.20.1
2/2 looks good to me:
PATCH 2/2 libltpnuma: remove restrictions on numa node-id
In reply to Li WangHi!
This is obviously OK, applied, thanks for the fix.
I guess that later on we may replace the check by storing the maximal numa node to the numa mapping structure and check that the id is <= than the max node.
Signature · 2 lines
Cyril Hrubis [email protected]