: Clear GPIO mask before storing.

PATCH Applied Michael Chan 2 participants 2 messages May 5, 2007

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Michael Chan

author

2007-05-05 00:05 UTC #0 lore raw

PATCH 3/11 : Clear GPIO mask before storing.

[TG3]: Clear GPIO mask before storing.

The GPIO settings may change during reset and so the stored values in tp->grc_local_ctrl should be cleared first.

Signed-off-by Gary Zambrano <[email protected]>

Signed-off-by Michael Chan <[email protected]>

drivers/net/tg3.c +1 -0

index c01bd86..00027a1 100644
@@ -6454,6 +6454,7 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
 		if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5755)
 			gpio_mask |= GRC_LCLCTRL_GPIO_UART_SEL;
 
+		tp->grc_local_ctrl &= ~gpio_mask;
 		tp->grc_local_ctrl |= tr32(GRC_LOCAL_CTRL) & gpio_mask;
 
 		/* GPIO1 must be driven high for eeprom write protect */

David Miller

maintainer Applied

2007-05-05 18:52 UTC #1 lore raw

From: "Michael Chan" <[email protected]>
Date: Fri, 04 May 2007 17:52:38 -0700

Quoted 7 lines

[TG3]: Clear GPIO mask before storing.
The GPIO settings may change during reset and so the stored values in tp->grc_local_ctrl should be cleared first.
Signed-off-by Gary Zambrano <[email protected]>
Signed-off-by Michael Chan <[email protected]>

Applied.