Skip to contentSkip to conversation

pv drivers for 2.6.5 kernels

PATCH In review Ky Srinivasan 2 participants 3 messages May 9, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pv drivers for 2.6.5 kernels

This patch fixes a compilation problem in PV drivers targeted for sles9.

unmodified_drivers/linux-2.6/compat-include/xen/platform-compat.h +0 -2
Index: xen-3.0.4-testing/unmodified_drivers/linux-2.6/compat-include/xen/platform-compat.h
===================================================================
@@ -36,9 +36,7 @@
 /* Some kernels have this typedef backported so we cannot reliably
  * detect based on version number, hence we forcibly #define it.
  */
-#if defined(__LINUX_TYPES_H) || defined(__LINUX_GFP_H)
 #define gfp_t unsigned
-#endif
 
 #if defined(_LINUX_FS_H) && LINUX_VERSION_CODE < KERNEL_VERSION(2,6,9)
 #define nonseekable_open(inode, filp) /* Nothing to do */

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw

unmodified_drivers/linux-2.6/compat-include/xen/platform-compat.h line 41

Quoted 3 lines · Ky Srinivasan
unmodified_drivers/linux-2.6/compat-include/xen/platform-compat.h +0 -2
-#if defined(__LINUX_TYPES_H) || defined(__LINUX_GFP_H)
 #define gfp_t unsigned
-#endif 

Which file is failing to build? If one of the Xen files is using gfp_t and not including linux/gfp.h then that should be fixed.

Or does on of the guard #defines differ on 2.6.5 for those headers?

Ian.

#2 lore raw

Ian,

Quoted 1 line
Quoted 1 line
Quoted 1 line

On Wed, May 9, 2007 at 4:16 PM, in message

<[email protected]>, Ian Campbell

Quoted 11 lines · <[email protected]> wrote:
Quoted 3 lines · Ky Srinivasan

- #if defined(__LINUX_TYPES_H) || defined(__LINUX_GFP_H) #define gfp_t unsigned
- #endif

Which file is failing to build? If one of the Xen files is using gfp_t and not including linux/gfp.h then that should be fixed.

Or does on of the guard #defines differ on 2.6.5 for those headers?

Ian.

Ian,
I was getting a parse error in platform_compat.h (kasprintf()). Ignore my patch since this problem has been fixed in the unstable tree - the guard has been extended to include _LINUX_KERNEL_H! The code we are working with did not have _LINUX_KERNEL_H in the guard and hence I had the compilation problem and decided to get rid of the guard.

Regards,

K. Y