default y idiocy
Subsystems (6)
Hi,
This has bothered me for a long time, and it just seems to be getting worse. Can people please STOP defaulting non-essential stuff to 'y'? Grrr.
drivers/macintosh/Kconfig +0 -1
@@ -2,7 +2,6 @@ menuconfig MACINTOSH_DRIVERS bool "Macintosh device drivers" depends on PPC || MAC || X86 - default y if MACINTOSH_DRIVERS
drivers/media/Kconfig +0 -1
@@ -89,7 +89,6 @@ config VIDEO_TVEEPROM config DAB boolean "DAB adapters" - default y ---help--- Allow selecting support for for Digital Audio Broadcasting (DAB) Receiver adapters.
Signature · 1 line
Jens Axboe
Quoted 5 lines · Jens Axboe
Hi,
This has bothered me for a long time, and it just seems to be getting worse. Can people please STOP defaulting non-essential stuff to 'y'? Grrr.
http://lkml.org/lkml/2007/5/8/76
Jan
Quoted 9 lines · Jan Engelhardt
Quoted 5 lines · Jens Axboe
Hi,
This has bothered me for a long time, and it just seems to be getting worse. Can people please STOP defaulting non-essential stuff to 'y'? Grrr.
Sorry, I don't buy that reason at all - it's a short term advantage, causing long term pain. It's not what we have done in the past, don't start doing crap like that now.
Signature · 1 line
Jens Axboe
Quoted 9 lines · Jens Axboe
Quoted 8 lines · Jan Engelhardt
Quoted 5 lines · Jens Axboe
Hi,
This has bothered me for a long time, and it just seems to be getting worse. Can people please STOP defaulting non-essential stuff to 'y'? Grrr.
Quoted 5 lines
Quoted 1 line
Sorry, I don't buy that reason at all - it's a short term advantage, causing long term pain. It's not what we have done in the past, don't start doing crap like that now.
Right, I shall create some patches to revert that and send them off to Linus ASAP.
Jan
Quoted 11 lines · Jan Engelhardt
Quoted 9 lines · Jens Axboe
Quoted 8 lines · Jan Engelhardt
Quoted 5 lines · Jens Axboe
Hi,
This has bothered me for a long time, and it just seems to be getting worse. Can people please STOP defaulting non-essential stuff to 'y'? Grrr.
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Sorry, I don't buy that reason at all - it's a short term advantage, causing long term pain. It's not what we have done in the past, don't start doing crap like that now.
Right, I shall create some patches to revert that and send them off to Linus ASAP.
Thanks!
Signature · 1 line
Jens Axboe
Hi Linus,
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines · Jens Axboe
Quoted 5 lines
Hi,
This has bothered me for a long time, and it just seems to be getting worse. Can people please STOP defaulting non-essential stuff to 'y'? Grrr.
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Sorry, I don't buy that reason at all - it's a short term advantage, causing long term pain. It's not what we have done in the past, don't start doing crap like that now.
Right, I shall create some patches to revert that and send them off to Linus ASAP.
Thanks!
Revert "default y" in Kconfig files that were introduced as part of my menuconfig objects series (unfortunately, more patches may find their way into mainline as subsystem maintainers merge). Apply this for now, please.
drivers/atm/Kconfig | 1 - drivers/macintosh/Kconfig | 1 - drivers/media/radio/Kconfig | 1 - drivers/media/video/Kconfig | 2 -- drivers/net/Kconfig | 1 - 5 files changed, 0 insertions(+), 6 deletions(-)
drivers/atm/Kconfig +0 -1
@@ -5,7 +5,6 @@ menuconfig ATM_DRIVERS bool "ATM drivers" depends on NETDEVICES && ATM - default y if ATM_DRIVERS
drivers/macintosh/Kconfig +0 -1
@@ -2,7 +2,6 @@ menuconfig MACINTOSH_DRIVERS bool "Macintosh device drivers" depends on PPC || MAC || X86 - default y if MACINTOSH_DRIVERS
drivers/media/radio/Kconfig +0 -1
@@ -5,7 +5,6 @@ menuconfig RADIO_ADAPTERS bool "Radio Adapters" depends on VIDEO_DEV - default y ---help--- Say Y here to enable selecting AM/FM radio adapters.
drivers/media/video/Kconfig +0 -2
@@ -5,7 +5,6 @@ menuconfig VIDEO_CAPTURE_DRIVERS bool "Video capture adapters" depends on VIDEO_DEV - default y ---help--- Say Y here to enable selecting the video adapters for webcams, analog TV, and hybrid analog/digital TV.
@@ -689,7 +688,6 @@ config VIDEO_CAFE_CCIC menuconfig V4L_USB_DRIVERS bool "V4L USB devices" depends on USB - default y if V4L_USB_DRIVERS
drivers/net/Kconfig +0 -1
@@ -1901,7 +1901,6 @@ endmenu menuconfig NETDEV_1000 bool "Ethernet (1000 Mbit)" depends on !UML - default y if NETDEV_1000
#<EOF>
Jan
Hi Jan,
All the submenus bellow are dependent of VIDEO_DEV (Video4Linux core). If someone wants V4L, it is very likely that he will select a radio or a video adapter, since the subsystem is useless without the drivers (*).
(*) Except if you are using an out-of-tree driver.
Quoted 25 lines
drivers/media/radio/Kconfig +0
-1@@ -5,7 +5,6 @@ menuconfig RADIO_ADAPTERS bool "Radio Adapters" depends on VIDEO_DEV - default y ---help--- Say Y here to enable selecting AM/FM radio adapters.drivers/media/video/Kconfig +0
-1@@ -5,7 +5,6 @@ menuconfig VIDEO_CAPTURE_DRIVERS bool "Video capture adapters" depends on VIDEO_DEV - default y ---help--- Say Y here to enable selecting the video adapters for webcams, analog TV, and hybrid analog/digital TV.
drivers/media/video/Kconfig config VIDEO_CAFE_CCIC · line 692
Quoted 4 lines
drivers/media/video/Kconfig +0
-1@@ -689,7 +688,6 @@ config VIDEO_CAFE_CCIC menuconfig V4L_USB_DRIVERS bool "V4L USB devices" depends on USB - default y
It should be noticed that selecting the "Drivers" Kconfig items won't produce any code. No drivers are marked with default.
Those items are just used to better organize Multimedia menu. The result of having 'y' is just to have the submenus open by default. For me, it makes sense to keep default y, especially if we consider the arguments at:
http://lkml.org/lkml/2007/5/8/76
This is also the same case for DVB drivers submenu:
menuconfig DVB_CAPTURE_DRIVERS
bool "DVB/ATSC adapters"
depends on DVB_CORE
default y
---help---
Say Y to select Digital TV adapters
Just to keep the entire menu coherent, "default y" were added for DAB:
config DAB
boolean "DAB adapters"
default y
---help---
Allow selecting support for for Digital Audio Broadcasting (DAB) Receiver adapters.
if DAB
config USB_DABUSB
tristate "DABUSB driver"
depends on USB
---help---
A Digital Audio Broadcasting (DAB) Receiver for USB and Linux brought to you by the DAB-Team
<http://wwwbode.cs.tum.edu/Par/arch/dab/>. This driver can be taken as an example for URB-based bulk, control, and isochronous transactions. URB's are explained in <Documentation/usb/URB.txt>.
To compile this driver as a module, choose M here: the module will be called dabusb.
endif # DAB
It is fine for me to remove "default y" for DAB, although i would prefer to have it marked as 'y' just for coherence.
Cheers,
Mauro
Quoted 3 lines
Sorry, I don't buy that reason at all - it's a short term advantage, causing long term pain. It's not what we have done in the past, don't start doing crap like that now.
It doesn't really matter what it defaults too
cp .config somewheresafe
Install new kernel
cp it back
make oldconfig
Alan
Quoted 5 lines · Alan Cox
Quoted 3 lines
Sorry, I don't buy that reason at all - it's a short term advantage, causing long term pain. It's not what we have done in the past, don't start doing crap like that now.
It doesn't really matter what it defaults too
It does matter what it defaults to, it should only default to y if it's really needed. If it didn't matter, just default every driver to y? Thanks, but no thanks.
Quoted 7 lines
cp .config somewheresafe
Install new kernel
cp it back
make oldconfig
Ehm yes, kernel updating 101. What's your point? Do that with your 2.6.21 config and get met with lots of new questions on ps2, ethernet, macintosh drivers, dab, etc. All because of some menuconfig shuffling.
Signature · 1 line
Jens Axboe
Quoted 5 lines · Jens Axboe
Hi,
This has bothered me for a long time, and it just seems to be getting worse. Can people please STOP defaulting non-essential stuff to 'y'? Grrr.
Is there a reason why various 10/100/1000Mbit network cards are 'y' too?
There's even a default SCSI 'm' that seems to be completely hidden from the menu too (CONFIG_SCSI_WAIT_SCAN). It depends on SCSI but I can't disable SCSI...
Signature · 1 line
Simon Arlott
Quoted 11 lines · Simon Arlott
Quoted 5 lines · Jens Axboe
Hi,
This has bothered me for a long time, and it just seems to be getting worse. Can people please STOP defaulting non-essential stuff to 'y'? Grrr.
Is there a reason why various 10/100/1000Mbit network cards are 'y' too? There's even a default SCSI 'm' that seems to be completely hidden from the menu too (
CONFIG_SCSI_WAIT_SCAN). It depends on SCSI but I can't disable SCSI...
For the exact same (wrong) reason that the other menuconfig changes did it, I suppose. Need fixing, too.
Signature · 1 line
Jens Axboe
Quoted 11 lines · Simon Arlott
Quoted 5 lines · Jens Axboe
Hi,
This has bothered me for a long time, and it just seems to be getting worse. Can people please STOP defaulting non-essential stuff to 'y'? Grrr.
Is there a reason why various 10/100/1000Mbit network cards are 'y' too? There's even a default SCSI 'm' that seems to be completely hidden from the menu too (
CONFIG_SCSI_WAIT_SCAN). It depends on SCSI but I can't disable SCSI...
That might not necessarily be our fault ... there's no default 'm' for SCSI in drivers/scsi/Kconfig. On the other hand, the select directive can also be the cause of these problems, for instance drivers/ata/Kconfig has a select SCSI at the top, so if you selected modular ATA, you'll be forced to have modular SCSI.
James
Quoted 2 lines · James Bottomley
drivers/ata/Kconfighas a select SCSI at the top, so if you selected modular ATA, you'll be forced to have modular SCSI.
Or built-in.
Signature · 1 line
Krzysztof Halasa
Quoted 11 lines · Simon Arlott
Quoted 5 lines · Jens Axboe
Hi,
This has bothered me for a long time, and it just seems to be getting worse. Can people please STOP defaulting non-essential stuff to 'y'? Grrr.
Is there a reason why various 10/100/1000Mbit network cards are 'y' too? There's even a default SCSI 'm' that seems to be completely hidden from the menu too (
CONFIG_SCSI_WAIT_SCAN). It depends on SCSI but I can't disable SCSI...
Yeah, I've seen a lot of unnecessary default y's too, seems to be a contagious disease.
And there are another kind of (harmless) default y's too, that don't really force unnecessary compilation and linking of stuff into the kernel at all, ones like (21-mm2's) init/Kconfig: SLUB_DEBUG = default y (it's completely contained in mm/slub.c and not exposed to mm/Makefile), but it still seems funny to find a spurious CONFIG_SLUB_DEBUG=y in your .config when you also have # CONFIG_SLUB is not set.
Do we care enough to fix such cases too? This was a one-liner, so including a patch anyway, CC'ing to Andrew and Christoph.
---
Prevent SLUB_DEBUG from being set if SLUB is not. SLUB_DEBUG without SLUB does not cause anything to be compiled or linked in anyway, so this is not critical, but simply removes a spurious CONFIG_SLUB_DEBUG=y from creeping into the .config even when CONFIG_SLUB is not set.
---
init/Kconfig +0 -0
@@ -567,7 +567,7 @@ config VM_EVENT_COUNTERS
if VM event counters are disabled.
config SLUB_DEBUG
- default y
+ default y if SLUB
bool "Enable SLUB debugging support" if EMBEDDED help
SLUB has extensive debug support features. Disabling these can