Skip to contentSkip to conversation

radeonfb and X800 cards

DISCUSSION Daniel Drake 5 participants 12 messages May 17, 2007 – May 24, 2007 Framebuffer layer

lore
Share & tools
lore
#1 lore raw
Quoted 11 lines · Daniel Drake

Hi,

Did anything happen to the patch titled "radeonfb: add support for newer cards"?
http://lwn.net/Articles/215965/

Jimmy at http://bugs.gentoo.org/174063 has extended upon this with some further fixes based on code the in X11 driver. The patches are on the bug report.

Ben, where can the most up-to-date radeonfb code be found?

upstream. I haven't released anything else so far. Does the patch still apply ?

Ben.

#2 lore raw
Quoted 7 lines · Benjamin Herrenschmidt
Quoted 6 lines · Daniel Drake

Hi,

Did anything happen to the patch titled "radeonfb: add support for newer cards"?
http://lwn.net/Articles/215965/

Quoted 8 lines
Quoted 5 lines

Jimmy at http://bugs.gentoo.org/174063 has extended upon this with some further fixes based on code the in X11 driver. The patches are on the bug report.

Ben, where can the most up-to-date radeonfb code be found?

upstream. I haven't released anything else so far. Does the patch still apply ?

Nope, but I still rebase against current kernel for my own use. I can send an up to date patch when I get home this evening.

Luca

#3 lore raw
In reply to Benjamin Herrenschmidt

Il Thu, May 17, 2007 at 11:59:23AM +1000, Benjamin Herrenschmidt ha scritto:

Quoted 7 lines · Daniel Drake
Quoted 6 lines

Hi,

Did anything happen to the patch titled "radeonfb: add support for newer cards"?
http://lwn.net/Articles/215965/

Quoted 8 lines
Quoted 5 lines

Jimmy at http://bugs.gentoo.org/174063 has extended upon this with some further fixes based on code the in X11 driver. The patches are on the bug report.

Ben, where can the most up-to-date radeonfb code be found?

upstream. I haven't released anything else so far. Does the patch still apply ?

This is what I'm using here, it's still the same old patch (Solomon's plus my stuff). I think I can coordinate with [email protected] to create an incremental patch to fix radeonfb on his hardware (provided that this mega-patch is suitable as baseline that is).

---
Applies to current git

 drivers/video/aty/ati_ids.h          |   32 
 drivers/video/aty/radeon_accel.c     |   19 
 drivers/video/aty/radeon_backlight.c |    4 
 drivers/video/aty/radeon_base.c      |  494 +++++++----
 drivers/video/aty/radeon_i2c.c       |   66 -
 drivers/video/aty/radeon_monitor.c   | 1339 +++++++++++++++++++++---------
 drivers/video/aty/radeonfb.h         |  163 ++-
 7 files changed, 1516 insertions(+), 601 deletions(-)
drivers/video/aty/ati_ids.h +32 -0
index 90e7df2..7b701cc 100644
@@ -31,6 +31,7 @@
 #define PCI_CHIP_RV360_AR               0x4152
 #define PCI_CHIP_RV350_AS               0x4153
 #define PCI_CHIP_RV350_AT               0x4154
+#define PCI_CHIP_RV350_AU 		0x4155
 #define PCI_CHIP_RV350_AV               0x4156
 #define PCI_CHIP_MACH32			0x4158
 #define PCI_CHIP_RS250_4237		0x4237
@@ -71,7 +72,13 @@
 #define PCI_CHIP_R420_JL                0x4A4C
 #define PCI_CHIP_R420_JM                0x4A4D
 #define PCI_CHIP_R420_JN                0x4A4E
+#define PCI_CHIP_R420_JO 		0x4A4F
 #define PCI_CHIP_R420_JP                0x4A50
+#define PCI_CHIP_R420_JT 		0x4A54
+#define PCI_CHIP_R480_KI 		0x4B49
+#define PCI_CHIP_R480_KJ 		0x4B4A
+#define PCI_CHIP_R480_KK                0x4B4B
+#define PCI_CHIP_R480_KL 		0x4B4C
 #define PCI_CHIP_MACH64LB		0x4C42
 #define PCI_CHIP_MACH64LD		0x4C44
 #define PCI_CHIP_RAGE128LE		0x4C45
@@ -182,9 +189,19 @@
 #define PCI_CHIP_R423_UI                0x5549
 #define PCI_CHIP_R423_UJ                0x554A
 #define PCI_CHIP_R423_UK                0x554B
+#define PCI_CHIP_R423_UL 		0x554C
+#define PCI_CHIP_R423_UM 		0x554D
+#define PCI_CHIP_R423_UN 		0x554E
+#define PCI_CHIP_R423_UO 		0x554F
+#define PCI_CHIP_R423_UP 	       	0x5550
 #define PCI_CHIP_R423_UQ                0x5551
 #define PCI_CHIP_R423_UR                0x5552
 #define PCI_CHIP_R423_UT                0x5554
+#define PCI_CHIP_RV410_VJ 		0x564A
+#define PCI_CHIP_RV410_VK 		0x564B
+#define PCI_CHIP_RV410_VO 		0x564F
+#define PCI_CHIP_RV410_VR 		0x5652
+#define PCI_CHIP_RV410_VS 		0x5653
 #define PCI_CHIP_MACH64VT		0x5654
 #define PCI_CHIP_MACH64VU		0x5655
 #define PCI_CHIP_MACH64VV		0x5656
@@ -206,7 +223,22 @@
 #define PCI_CHIP_RV280_5964		0x5964
 #define PCI_CHIP_RV280_5C61		0x5C61
 #define PCI_CHIP_RV280_5C63		0x5C63
+#define PCI_CHIP_R423_5D48		0x5D48
+#define PCI_CHIP_R423_5D49		0x5D49
+#define PCI_CHIP_R423_5D4A		0x5D4A
+#define PCI_CHIP_R480_5D4C		0x5D4C
+#define PCI_CHIP_R480_5D4D		0x5D4D
+#define PCI_CHIP_R480_5D4E		0x5D4E
+#define PCI_CHIP_R480_5D4F		0x5D4F
+#define PCI_CHIP_R480_5D50		0x5D50
+#define PCI_CHIP_R480_5D52		0x5D52
 #define PCI_CHIP_R423_5D57              0x5D57
+#define PCI_CHIP_RV410_5E48		0x5E48
+#define PCI_CHIP_RV410_5E4A		0x5E4A
+#define PCI_CHIP_RV410_5E4B		0x5E4B
+#define PCI_CHIP_RV410_5E4C		0x5E4C
+#define PCI_CHIP_RV410_5E4D		0x5E4D
+#define PCI_CHIP_RV410_5E4F		0x5E4F
 #define PCI_CHIP_RS350_7834             0x7834
 #define PCI_CHIP_RS350_7835             0x7835
 #define PCI_CHIP_RS480_5955             0x5955
drivers/video/aty/radeon_accel.c +7 -12
index 3ca27cb..529f158 100644
@@ -203,9 +203,7 @@ void radeonfb_engine_reset(struct radeonfb_info *rinfo)
 	host_path_cntl = INREG(HOST_PATH_CNTL);
 	rbbm_soft_reset = INREG(RBBM_SOFT_RESET);
 
-	if (rinfo->family == CHIP_FAMILY_R300 ||
-	    rinfo->family == CHIP_FAMILY_R350 ||
-	    rinfo->family == CHIP_FAMILY_RV350) {
+	if (IS_R300_VARIANT(rinfo)) {
 		u32 tmp;
 
 		OUTREG(RBBM_SOFT_RESET, (rbbm_soft_reset |
@@ -241,9 +239,7 @@ void radeonfb_engine_reset(struct radeonfb_info *rinfo)
 	INREG(HOST_PATH_CNTL);
 	OUTREG(HOST_PATH_CNTL, host_path_cntl);
 
-	if (rinfo->family != CHIP_FAMILY_R300 ||
-	    rinfo->family != CHIP_FAMILY_R350 ||
-	    rinfo->family != CHIP_FAMILY_RV350)
+	if (IS_R300_VARIANT(rinfo))
 		OUTREG(RBBM_SOFT_RESET, rbbm_soft_reset);
 
 	OUTREG(CLOCK_CNTL_INDEX, clock_cntl_index);
@@ -254,16 +250,15 @@ void radeonfb_engine_init (struct radeonfb_info *rinfo)
 {
 	unsigned long temp;
 
-	/* disable 3D engine */
-	OUTREG(RB3D_CNTL, 0);
-
 	radeonfb_engine_reset(rinfo);
 
 	radeon_fifo_wait (1);
-	if ((rinfo->family != CHIP_FAMILY_R300) &&
-	    (rinfo->family != CHIP_FAMILY_R350) &&
-	    (rinfo->family != CHIP_FAMILY_RV350))
+	if (IS_R300_VARIANT(rinfo)) {
+		temp = INREG(RB2D_DSTCACHE_MODE);
+		OUTREG(RB2D_DSTCACHE_MODE, temp | (1<<17)); /* FIXME */
+	} else {
 		OUTREG(RB2D_DSTCACHE_MODE, 0);
+	}
 
 	radeon_fifo_wait (3);
 	/* We re-read MC_FB_LOCATION from card as it can have been
drivers/video/aty/radeon_backlight.c +2 -2
index 0be25fa..0c264f3 100644
@@ -52,7 +52,7 @@ static int radeon_bl_update_status(struct backlight_device *bd)
 	u32 lvds_gen_cntl, tmpPixclksCntl;
 	int level;
 
-	if (rinfo->mon1_type != MT_LCD)
+	if (PRIMARY_MONITOR(rinfo) != MT_LCD)
 		return 0;
 
 	/* We turn off the LCD completely instead of just dimming the
@@ -138,7 +138,7 @@ void radeonfb_bl_init(struct radeonfb_info *rinfo)
 	struct radeon_bl_privdata *pdata;
 	char name[12];
 
-	if (rinfo->mon1_type != MT_LCD)
+	if (PRIMARY_MONITOR(rinfo) == MT_LCD)
 		return;
 
 #ifdef CONFIG_PMAC_BACKLIGHT
drivers/video/aty/radeon_base.c +345 -149

830 lines not on this page · raw message

drivers/video/aty/radeon_i2c.c +44 -22

79 lines not on this page · raw message

drivers/video/aty/radeon_monitor.c +962 -377

1,624 lines not on this page · raw message

drivers/video/aty/radeonfb.h +124 -39

248 lines not on this page · raw message

Luca

Signature · 3 lines
"New processes are created by other processes, just like new
 humans. New humans are created by other humans, of course,
 not by processes." -- Unix System Administration Handbook
#4 lore raw

Hi.

Quoted 14 lines · Luca Tettamanti

Il Thu, May 17, 2007 at 11:59:23AM +1000, Benjamin Herrenschmidt ha scritto:

Quoted 13 lines · Daniel Drake
Quoted 11 lines

Hi,

Did anything happen to the patch titled "radeonfb: add support for newer cards"?
http://lwn.net/Articles/215965/

Jimmy at http://bugs.gentoo.org/174063 has extended upon this with some further fixes based on code the in X11 driver. The patches are on the bug report.

Ben, where can the most up-to-date radeonfb code be found?

Quoted 8 lines
Quoted 2 lines

upstream. I haven't released anything else so far. Does the patch still apply ?

This is what I'm using here, it's still the same old patch (Solomon's plus my stuff). I think I can coordinate with [email protected] to create an incremental patch to fix radeonfb on his hardware (provided that this mega-patch is suitable as baseline that is).

[long patch snipped]

Is there a reason why this patch can't go upstream?

Regards,
Fabio

Quoted 12 lines

Luca
--
"New processes are created by other processes, just like new
humans. New humans are created by other humans, of course, not by processes." -- Unix System Administration Handbook
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at ...

[Message clipped]

#5 lore raw
Quoted 1 line · Fabio Comolli

Is there a reason why this patch can't go upstream?

Yes. A change of that magnitude will most certainly introduce regressions. So we can either:

- Have it in -mm for monthes trying to iron out all of them (and we'll
miss some). And struggle also since it's hard to track subtle regressions with very big patches.

- Have it split in smaller bits, which make it possible to bisect in
case of problem, and thus find/correct problems much faster.

That's my main issue with it at this point. But I'm ok going for route #1 provided that you guys are willing to help with tracking regressions down. That also mean I need to do some serious testing on powermacs since those rely very heavily on a working radeonfb.

Ben.

#6 lore raw

Hi.
This patch does not work for me.
Relevant part of the dmesg output is:

< ACPI: PCI Interrupt 0000:01:00.0[A] -> GSI 16 (level, low) -> IRQ 16 < radeonfb: Reference=27.00 MHz (RefDiv=7) Memory=330.00 Mhz, System=358.00 MHz < Device driver i2c-0 lacks bus and class support for being resumed. < Device driver i2c-1 lacks bus and class support for being resumed. < Device driver i2c-2 lacks bus and class support for being resumed. < Device driver i2c-3 lacks bus and class support for being resumed. < i2c-adapter i2c-2: unable to read EDID block.
< i2c-adapter i2c-2: unable to read EDID block.
< i2c-adapter i2c-2: unable to read EDID block.
< * Connector 1 is Internal Panel. Head 0, Monitor: LVDS Flat panel (EDID probed)
< ddc port: 0, dac: -1, tmds: -1
< * Connector 2 is VGA. Head -1, Monitor: None
< ddc port: 2, dac: 0, tmds: -1
< radeonfb: detected LVDS panel size from BIOS: 1280x800
< radeonfb: Dynamic Clock Power Management enabled
< radeonfb (0000:01:00.0): ATI Radeon VS

My card is:

01:00.0 VGA compatible controller: ATI Technologies Inc Radeon Mobility X700 (PCIE) (prog-if 00 [VGA])
Subsystem: Hewlett-Packard Company Unknown device 309e
Flags: bus master, fast devsel, latency 0, IRQ 16 Memory at d0000000 (32-bit, prefetchable) [size=128M] I/O ports at 3000 [size=256]
Memory at c8100000 (32-bit, non-prefetchable) [size=64K] [virtual] Expansion ROM at c8120000 [disabled] [size=128K]
Capabilities: [50] Power Management version 2
Capabilities: [58] Express Endpoint IRQ 0
Capabilities: [80] Message Signalled Interrupts: 64bit+
Queue=0/0 Enable-
Capabilities: [100] Advanced Error Reporting

Please let me know if you need more details.
Regards,
Fabio

Quoted 23 lines · Benjamin Herrenschmidt
Quoted 1 line · Fabio Comolli

Is there a reason why this patch can't go upstream?

Yes. A change of that magnitude will most certainly introduce regressions. So we can either:

- Have it in -mm for monthes trying to iron out all of them (and we'll
miss some). And struggle also since it's hard to track subtle regressions with very big patches.

- Have it split in smaller bits, which make it possible to bisect in
case of problem, and thus find/correct problems much faster.

That's my main issue with it at this point. But I'm ok going for route #1 provided that you guys are willing to help with tracking regressions down. That also mean I need to do some serious testing on powermacs since those rely very heavily on a working radeonfb.

Ben.

#7 lore raw

Oh, never mind. Of course it works.
I forgot to enable the framebuffer console, I thought that selecting a fb driver would have automagically enabled it.

It breaks suspend-to-ram, but this is expected.

Thanks and sorry for the noise.
Fabio

Quoted 4 lines · Fabio Comolli

Hi.
This patch does not work for me.
Relevant part of the dmesg output is:

[snipped the rest of the email]

#8 lore raw
In reply to Luca Tettamanti
Quoted 5 lines

This is what I'm using here, it's still the same old patch (Solomon's plus my stuff). I think I can coordinate with [email protected] to create an incremental patch to fix radeonfb on his hardware (provided that this mega-patch is suitable as baseline that is).

Yes, I would very much appreciate if you guys managed to turn that into some incremental patch serie. That would make it much easier for me to review properly and track down possible regressions in fact.

Ben.

#9 lore raw
Quoted 9 lines · Benjamin Herrenschmidt
Quoted 4 lines

This is what I'm using here, it's still the same old patch (Solomon's plus my stuff). I think I can coordinate with [email protected] to create an incremental patch to fix radeonfb on his hardware (provided that this mega-patch is suitable as baseline that is).

Yes, I would very much appreciate if you guys managed to turn that into some incremental patch serie. That would make it much easier for me to review properly and track down possible regressions in fact.

Quoted 8 lines

Ben.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Hello,

i would be glad to help you to build an incremental patch.

Also, my goal was to make it possible to use the console radeon framebuffer, to have a nice splash screen on a wide flat panel in its native mode and to have it stay as much as possible compatible with xorg dri and co. Also, it is working for me now.

Finally, i tried to modify/introduce as few codes as possible and make it easier to X800 family card users to validate the patch, especially if they use a flat panel connected to the dvi port without a vga dongle/adaptator. If someone just tries it and tells if it works with xorg without problem as it works for me, that would be great.

@Luca, if i remember well you have a X850, could you please try the patch for me ?

The patch i introduced concerns the fact that my card doesn't handle
very well the dvi connector with the radeonfb kernel driver. The driver just defaulted the connector to vga. However, the driver defines monid
but is never detected/used during auto detection. I just add it in radeon_monitor.c. It seems pretty easy isn't it ;).
In fact, the code that made it possible to get something different than
a black screen, stays mostly in radeon_monitor.c:
@@ -552,6 +541,9 @@
#endif /* CONFIG_PPC_OF || CONFIG_SPARC */
#ifdef CONFIG_FB_RADEON_I2C
if (rinfo->mon1_type == MT_NONE)
+ rinfo->mon1_type = radeon_probe_i2c_connector(rinfo, ddc_monid,
+ &rinfo->mon1_EDID);
+ if (rinfo->mon1_type == MT_NONE)
rinfo->mon1_type = radeon_probe_i2c_connector(rinfo, ddc_dvi,
&rinfo->mon1_EDID);
if (rinfo->mon1_type == MT_NONE) {
@@ -643,7 +635,7 @@

Also, radeon_accel.c is important to get xorg work as well. In fact, you will get FIFO errors in xorg and dri won't be able to be initialized, if radeon_accel.c doesn't understand your card.

I tried the patch with an old agp 9700 radeon card with a dvi connector, connected to a flat panel. The patch does nothing as expected and seems rather harmless in that case.
It works great, with a "ATI Radeon X800XT (R423) 5D57 (PCIE)" (ChipID = 0x5d57).

you can apply aty-2.6.22.diff to a 2.6.22-rc1-mm1 kernel and 2.6.21 kernels as well.

(The patch needs to be applied directly in the drivers/video/aty directory)

Thank you for you great work and your interest in the radeon framebuffer driver :).

Jj

radeon_accel.c renamed from radeon_accel.c.ori +7 -12
@@ -203,9 +203,7 @@
 	host_path_cntl = INREG(HOST_PATH_CNTL);
 	rbbm_soft_reset = INREG(RBBM_SOFT_RESET);
 
-	if (rinfo->family == CHIP_FAMILY_R300 ||
-	    rinfo->family == CHIP_FAMILY_R350 ||
-	    rinfo->family == CHIP_FAMILY_RV350) {
+	if (IS_R300_VARIANT(rinfo)) {
 		u32 tmp;
 
 		OUTREG(RBBM_SOFT_RESET, (rbbm_soft_reset |
@@ -241,9 +239,7 @@
 	INREG(HOST_PATH_CNTL);
 	OUTREG(HOST_PATH_CNTL, host_path_cntl);
 
-	if (rinfo->family != CHIP_FAMILY_R300 ||
-	    rinfo->family != CHIP_FAMILY_R350 ||
-	    rinfo->family != CHIP_FAMILY_RV350)
+	if (IS_R300_VARIANT(rinfo))
 		OUTREG(RBBM_SOFT_RESET, rbbm_soft_reset);
 
 	OUTREG(CLOCK_CNTL_INDEX, clock_cntl_index);
@@ -254,16 +250,15 @@
 {
 	unsigned long temp;
 
-	/* disable 3D engine */
-	OUTREG(RB3D_CNTL, 0);
-
 	radeonfb_engine_reset(rinfo);
 
 	radeon_fifo_wait (1);
-	if ((rinfo->family != CHIP_FAMILY_R300) &&
-	    (rinfo->family != CHIP_FAMILY_R350) &&
-	    (rinfo->family != CHIP_FAMILY_RV350))
+	if (IS_R300_VARIANT(rinfo)) {
+		temp = INREG(RB2D_DSTCACHE_MODE);
+		OUTREG(RB2D_DSTCACHE_MODE, temp | (1<<17)); /* FIXME */
+	} else {
 		OUTREG(RB2D_DSTCACHE_MODE, 0);
+	}
 
 	radeon_fifo_wait (3);
 	/* We re-read MC_FB_LOCATION from card as it can have been
radeon_base.c renamed from radeon_base.c.ori +81 -12

137 lines not on this page · raw message

radeonfb.h renamed from radeonfb.h.ori +3 -0
@@ -301,6 +301,9 @@
 	void __iomem		*bios_seg;
 	int			fp_bios_start;
 
+	int			is_atom_bios;
+        int                     atom_data_start;
+
 	u32			pseudo_palette[17];
 	struct { u8 red, green, blue, pad; }
 				palette[256];
radeon_monitor.c renamed from radeon_monitor.c.ori +6 -14
@@ -481,17 +481,6 @@
 		
 		RTRACE("Starting monitor auto detection...\n");
 
-#if DEBUG && defined(CONFIG_FB_RADEON_I2C)
-		{
-			u8 *EDIDs[4] = { NULL, NULL, NULL, NULL };
-			int mon_types[4] = {MT_NONE, MT_NONE, MT_NONE, MT_NONE};
-			int i;
-
-			for (i = 0; i < 4; i++)
-				mon_types[i] = radeon_probe_i2c_connector(rinfo,
-									  i+1, &EDIDs[i]);
-		}
-#endif /* DEBUG */
 		/*
 		 * Old single head cards
 		 */
@@ -531,11 +520,11 @@
 				if (!BIOS_IN8(tmp + i*2) && i > 1)
 					break;
 				tmp0 = BIOS_IN16(tmp + i*2);
-				if ((!(tmp0 & 0x01)) && (((tmp0 >> 8) & 0x0f) == ddc_dvi)) {
+				if ((!(tmp0 & 0x01)) && ((((tmp0 >> 8) & 0x0f) == ddc_dvi) || (((tmp0 >> 8) & 0x0f) == ddc_monid))) {
 					rinfo->reversed_DAC = 1;
 					printk(KERN_INFO "radeonfb: Reversed DACs detected\n");
 				}
-				if ((((tmp0 >> 8) & 0x0f) == ddc_dvi) && ((tmp0 >> 4) & 0x01)) {
+				if ((((tmp0 >> 8) & 0x0f) == ddc_dvi || (((tmp0 >> 8) & 0x0f) == ddc_monid)) && ((tmp0 >> 4) & 0x01)) {
 					rinfo->reversed_TMDS = 1;
 					printk(KERN_INFO "radeonfb: Reversed TMDS detected\n");
 				}
@@ -552,6 +541,9 @@
 #endif /* CONFIG_PPC_OF || CONFIG_SPARC */
 #ifdef CONFIG_FB_RADEON_I2C
 		if (rinfo->mon1_type == MT_NONE)
+			rinfo->mon1_type = radeon_probe_i2c_connector(rinfo, ddc_monid,
+								      &rinfo->mon1_EDID);
+		if (rinfo->mon1_type == MT_NONE)
 			rinfo->mon1_type = radeon_probe_i2c_connector(rinfo, ddc_dvi,
 								      &rinfo->mon1_EDID);
 		if (rinfo->mon1_type == MT_NONE) {
@@ -643,7 +635,7 @@
 
 
 /*
- * This functions applyes any arch/model/machine specific fixups
+ * This functions applies any arch/model/machine specific fixups
  * to the panel info. It may eventually alter EDID block as
  * well or whatever is specific to a given model and not probed
  * properly by the default code
#10 lore raw

Il Sun, May 20, 2007 at 02:54:20PM +0200, Jimmy Jazz ha scritto:

Quoted 2 lines

@Luca, if i remember well you have a X850, could you please try the patch for me ?

It does work - sort of; BIOS parsing code is correct. It lacks the proper connector detection though (esp. port sharing). ATOM BIOS has a different data layout, so this should be added (now radeonfb thinks that I've 2 monitors).

I'll be away this weekend, so I'll try to come up with a patch as soon as I return home.

Luca

Signature · 4 lines
"L'abilita` politica e` l'abilita` di prevedere quello che
 accadra` domani, la prossima settimana, il prossimo mese e
 l'anno prossimo. E di essere cosi` abili, piu` tardi,
 da spiegare  perche' non e` accaduto."
#11 lore raw
Quoted 9 lines · Luca Tettamanti

Il Sun, May 20, 2007 at 02:54:20PM +0200, Jimmy Jazz ha scritto:

Quoted 2 lines

@Luca, if i remember well you have a X850, could you please try the patch for me ?

It does work - sort of; BIOS parsing code is correct. It lacks the proper connector detection though (esp. port sharing). ATOM BIOS has a different data layout, so this should be added (now radeonfb thinks that I've 2 monitors).

Quoted 4 lines

I'll be away this weekend, so I'll try to come up with a patch as soon as I return home.

Luca

Hello,

The fact that you see two monitors doesn't really surprise me :) . Also, i'm convinced to move to the mega patch even if i'm not quite sure all that code is also needed and I know it will unnecessarily increase the size of the kernel. However, better have much then less. Sure, if there were any more information on the web about video card connector/port logic, my knowledge would have been undoubtedly improved. Anyway, adding (conn->ddc_type == ddc_monid) in the if condition in radeon_i2c.c works for me as well.

--- /usr/src/model_with-radeon-r400/aty/radeon_i2c.c 2007-04-13
13:35:49.000000000 +0200
+++ radeon_i2c.c 2007-04-13 22:07:16.000000000 +0200
@@ -163,7 +163,7 @@
mon_type = MT_NONE;
goto done;
}
- if ((edid[EDID_STRUCT_DISPLAY] & 0x80) && (conn->ddc_type == ddc_dvi)) {
+ if ((edid[EDID_STRUCT_DISPLAY] & 0x80) && ((conn->ddc_type == ddc_dvi)
|| (conn->ddc_type == ddc_monid))) {
RTRACE("radeonfb: I2C (port %d) ... found TMDS panel\n", conn->ddc_type); mon_type = MT_DFP;
goto done;

Thank you for testing the patch.

Jj