Fix missing include
PATCH 1/1 Fix missing include
ftp://firstfloor.org/pub/ak/x86_64/quilt/x86_64-2.6.22-rc2-070521-1.bz2
explodes in various places due to missing defines of __cold. We can't rely on the assumption that linux/compiler.h is included magically before bug.h is included. Include it explicitely.
include/asm-i386/bug.h +3 -0
@@ -8,6 +8,9 @@*/ #ifdef CONFIG_BUG + +#include <linux/compiler.h> +#define HAVE_ARCH_BUG #ifdef CONFIG_DEBUG_BUGVERBOSE
include/asm-x86_64/bug.h +3 -0
@@ -2,6 +2,9 @@#define __ASM_X8664_BUG_H 1#ifdef CONFIG_BUG + +#include <linux/compiler.h> +#define HAVE_ARCH_BUG #ifdef CONFIG_DEBUG_BUGVERBOSE
Quoted 5 lines · Thomas Gleixner
ftp://firstfloor.org/pub/ak/x86_64/quilt/x86_64-2.6.22-rc2-070521-1.bz2
explodes in various places due to missing defines of
__cold. We can't rely on the assumption thatlinux/compiler.his included magically beforebug.his included. Include it explicitely.
Hmm, somehow it worked here. Perhaps longer term it would be a good idea to turn compiler.h into an -include
Quoted 1 line
Signed-off-by Thomas Gleixner <[email protected]>
Added thanks
-Andi
Quoted 9 lines · Andi Kleen
Quoted 5 lines · Thomas Gleixner
ftp://firstfloor.org/pub/ak/x86_64/quilt/x86_64-2.6.22-rc2-070521-1.bz2
explodes in various places due to missing defines of
__cold. We can't rely on the assumption thatlinux/compiler.his included magically beforebug.his included. Include it explicitely.Hmm, somehow it worked here. Perhaps longer term it would be a good idea to turn
compiler.hinto an -include
Might be not a bad idea. > 300 files include it directly and it's included from sched.h & co as well.
tglx
Quoted 8 lines · Thomas Gleixner
Quoted 7 lines · Andi Kleen
Quoted 5 lines · Thomas Gleixner
ftp://firstfloor.org/pub/ak/x86_64/quilt/x86_64-2.6.22-rc2-070521-1.bz2
explodes in various places due to missing defines of
__cold. We can't rely on the assumption thatlinux/compiler.his included magically beforebug.his included. Include it explicitely.
Quoted 5 lines
Quoted 2 lines
Hmm, somehow it worked here. Perhaps longer term it would be a good idea to turn
compiler.hinto an -includeMight be not a bad idea. > 300 files include it directly and it's included from
sched.h& co as well.
How about a file like:include/linux/always_include.h
This file could then include autoconf.h + compiler.h So we avoid an even longer gcc commandline.
Sam