Skip to contentSkip to conversation

fix reference counting

PATCH New Josef Bacik 2 participants 2 messages Jun 5, 2007 – Jun 6, 2007 Distributed lock manager (DLM)

lore
Share & tools
lore

Josef Bacik

author
#0 lore raw

PATCH 1/1 fix reference counting

Hello,

This is a fix for the patch

021d2ff3a08019260a1dc002793c92d6bf18afb6

I left off a dlm_hold_rsb which causes the box to panic if you try to use debugfs. This patch fixes the problem. Sorry about that,

Signed-off-by Josef Bacik <[email protected]>
fs/dlm/debug_fs.c +1 -0
index 184be98..9f5de37 100644
@@ -250,6 +250,7 @@ static int rsb_iter_next(struct rsb_iter
 			goto top;
                 }
 		ri->rsb = list_entry(ri->next, struct dlm_rsb, res_hashchain);
+		dlm_hold_rsb(ri->rsb);
 		read_unlock(&ls->ls_rsbtbl[i].lock);
 		dlm_put_rsb(old);
 	}
#1 lore raw

PATCH 1/1 fix reference counting

Hi,

Now in the -nmw git tree. Thanks,

Steve.

Quoted 24 lines · Josef Bacik

Hello,

This is a fix for the patch

021d2ff3a08019260a1dc002793c92d6bf18afb6

I left off a dlm_hold_rsb which causes the box to panic if you try to use debugfs. This patch fixes the problem. Sorry about that,

Signed-off-by Josef Bacik <[email protected]>
fs/dlm/debug_fs.c +1 -0
index 184be98..9f5de37 100644
@@ -250,6 +250,7 @@ static int rsb_iter_next(struct rsb_iter
 			goto top;
                 }
 		ri->rsb = list_entry(ri->next, struct dlm_rsb, res_hashchain);
+		dlm_hold_rsb(ri->rsb);
 		read_unlock(&ls->ls_rsbtbl[i].lock);
 		dlm_put_rsb(old);
 	}