Skip to contentSkip to conversation

is_power_of_2-ia64/mm/hugetlbpage.c

PATCH New vignesh babu 1 participant 1 message Jun 7, 2007

Subsystems (2)
Memory management Kernel janitors
lore
Share & tools
lore

vignesh babu

author
#0 lore raw

PATCH 1/1 is_power_of_2-ia64/mm/hugetlbpage.c

Replacing (n & (n-1)) in the context of power of 2 checks with is_power_of_2

Signed-off-by vignesh babu <[email protected]>

---

arch/ia64/mm/hugetlbpage.c +2 -1
index 1346b7f..d22861c 100644
@@ -15,6 +15,7 @@
 #include <linux/pagemap.h>
 #include <linux/slab.h>
 #include <linux/sysctl.h>
+#include <linux/log2.h>
 #include <asm/mman.h>
 #include <asm/pgalloc.h>
 #include <asm/tlb.h>

@@ -182,7 +183,7 @@ static int __init hugetlb_setup_sz(char *str)
 		tr_pages = 0x15557000UL;
 
 	size = memparse(str, &str);
-	if (*str || (size & (size-1)) || !(tr_pages & size) ||
+	if (*str || !is_power_of_2(size) || !(tr_pages & size) ||
 		size <= PAGE_SIZE ||
 		size >= (1UL << PAGE_SHIFT << MAX_ORDER)) {
 		printk(KERN_WARNING "Invalid huge page size specified\n");
Signature · 9 lines
Vignesh Babu BM 
_____________________________________________________________ 
"Why is it that every time I'm with you, makes me believe in magic?"

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>