Skip to contentSkip to conversation

Active_nr is unsigned, hence can't be < 0

PATCH New Pierre Habouzit 1 participant 2 messages Jun 15, 2016

lore
Share & tools
lore

Pierre Habouzit

author
#0 lore raw

PATCH 1/1 Active_nr is unsigned, hence can't be < 0

Signed-off-by Pierre Habouzit <[email protected]>
---
 sha1_name.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
sha1_name.c +0 -2
index 7df01af..858f08c 100644
@@ -682,8 +682,6 @@ int get_sha1_with_mode(const char *name, unsigned char *sha1, unsigned *mode)
 		namelen = namelen - (cp - name);
 		if (!active_cache)
 			read_cache();
-		if (active_nr < 0)
-			return -1;
 		pos = cache_name_pos(cp, namelen);
 		if (pos < 0)
 			pos = -pos - 1;
Signature · 1 line
1.5.2.1
author
#1 lore raw

PATCH 1/1 Missing statics.

Signed-off-by Pierre Habouzit <[email protected]>
---
 builtin-branch.c |    4 ++--
 builtin-revert.c |    2 +-
 daemon.c         |    2 +-
 wt-status.c      |    2 +-
 xdiff/xemit.c    |    4 ++--
 5 files changed, 7 insertions(+), 7 deletions(-)
builtin-branch.c +2 -2
index 67f46c1..da48051 100644
@@ -55,7 +55,7 @@ static int parse_branch_color_slot(const char *var, int ofs)
 	die("bad config variable '%s'", var);
 }
 
-int git_branch_config(const char *var, const char *value)
+static int git_branch_config(const char *var, const char *value)
 {
 	if (!strcmp(var, "color.branch")) {
 		branch_use_color = git_config_colorbool(var, value);

@@ -72,7 +72,7 @@ int git_branch_config(const char *var, const char *value)
 	return git_default_config(var, value);
 }
 
-const char *branch_get_color(enum color_branch ix)
+static const char *branch_get_color(enum color_branch ix)
 {
 	if (branch_use_color)
 		return branch_colors[ix];
builtin-revert.c +1 -1
index 80c348c..8f02ed7 100644
@@ -107,7 +107,7 @@ static char *get_oneline(const char *message)
 	return result;
 }
 
-char *get_encoding(const char *message)
+static char *get_encoding(const char *message)
 {
 	const char *p = message, *eol;
daemon.c +1 -1
index 674e30d..4c8c322 100644
@@ -439,7 +439,7 @@ static void parse_extra_args(struct interp *table, char *extra_args, int buflen)
 	}
 }
 
-void fill_in_extra_table_entries(struct interp *itable)
+static void fill_in_extra_table_entries(struct interp *itable)
 {
 	char *hp;
wt-status.c +1 -1
index 4bfe8f1..5205420 100644
@@ -198,7 +198,7 @@ static void wt_read_cache(struct wt_status *s)
 	read_cache();
 }
 
-void wt_status_print_initial(struct wt_status *s)
+static void wt_status_print_initial(struct wt_status *s)
 {
 	int i;
 	char buf[PATH_MAX];
xdiff/xemit.c +2 -2
index e291dc7..86315b7 100644
@@ -99,8 +99,8 @@ static void xdl_find_func(xdfile_t *xf, long i, char *buf, long sz, long *ll) {
 }
 
 
-int xdl_emit_common(xdfenv_t *xe, xdchange_t *xscr, xdemitcb_t *ecb,
-		    xdemitconf_t const *xecfg) {
+static int xdl_emit_common(xdfenv_t *xe, xdchange_t *xscr, xdemitcb_t *ecb,
+                           xdemitconf_t const *xecfg) {
 	xdfile_t *xdf = &xe->xdf1;
 	const char *rchg = xdf->rchg;
 	long ix;
Signature · 1 line
1.5.2.1