Skip to contentSkip to conversation

82xx: Add the support of Wind River SBC PowerQUICCII 82xx

PATCH In review Mark Zhan 2 participants 3 messages Jun 8, 2007 – Jun 11, 2007 PowerPC

lore
Share & tools
lore

Mark Zhan

author
#0 lore raw

PATCH 3/6 82xx: Add the support of Wind River SBC PowerQUICCII 82xx

This patch fixes the following problems:

(1) The bus_id fs_enet device should be the same with its associated phy device bus_id, which is the combination of mdio bus ID and phy_addr, otherwise fs_enet driver will not be able to attach to its PHY device. MDIO bus ID is equal to fs_enet platform device ID.

(2) The phy irq map should not be hardcoded. It should match the PHY address provided by the platform DevTree Blob.

(3) Add the support of CPM2 SMC serial.

Signed-off-by Mark Zhan <[email protected]>
---
 b/arch/powerpc/sysdev/fsl_soc.c |   49
++++++++++++++++++++--------------------
 1 file changed, 25 insertions(+), 24 deletions(-)
(quoted diff) +0 -0

b/arch/powerpc/sysdev/fsl_soc.c
index cad1757..fe40c86 100644

arch/powerpc/sysdev/fsl_soc.c +25 -24

99 lines not on this page · raw message

#1 lore raw

arch/powerpc/sysdev/fsl_soc.c static int __init fs_enet_of_init(void) · line 694

Quoted 5 lines · On Fri, 08 Jun 2007 16:54:38 +0800 Mark Zhan <[email protected]> wrote:
arch/powerpc/sysdev/fsl_soc.c +2 -1
 			snprintf((char*)&bus_id[(*id)], BUS_ID_SIZE, "%x:%02x",
-							(u32)res.start, fs_enet_data.phy_addr);
+				fs_enet_dev->id, fs_enet_data.phy_addr);
+
 			fs_enet_data.bus_id = (char*)&bus_id[(*id)];

Have to admit this is not correct. The issue is in fs_enet code (which should take mdio bus id, not device id), and I'll cover it.

Signature · 2 lines
Sincerely, 
Vitaly
author
#2 lore raw

Hi Vitaly,

Since you will cover this issue, so I will remove this chunk from my patch, and re-submit my patches.

Thanks
Mark Zhan

Quoted 11 lines · Vitaly Bordug

arch/powerpc/sysdev/fsl_soc.c static int __init fs_enet_of_init(void) · line 694

Quoted 5 lines · On Fri, 08 Jun 2007 16:54:38 +0800 Mark Zhan <[email protected]> wrote:
arch/powerpc/sysdev/fsl_soc.c +2 -1
 			snprintf((char*)&bus_id[(*id)], BUS_ID_SIZE, "%x:%02x",
-							(u32)res.start, fs_enet_data.phy_addr);
+				fs_enet_dev->id, fs_enet_data.phy_addr);
+
 			fs_enet_data.bus_id = (char*)&bus_id[(*id)];

Have to admit this is not correct. The issue is in fs_enet code (which should take mdio bus id, not device id), and I'll cover it.