is_power_of_2-dm
Subsystems (3)
PATCH 1/1 is_power_of_2-dm
Replacing (n & (n-1)) in the context of power of 2 checks with is_power_of_2
Signed-off-by vignesh babu <[email protected]>
---
drivers/md/dm-raid1.c +2 -1
@@ -19,6 +19,7 @@#include <linux/time.h> #include <linux/vmalloc.h> #include <linux/workqueue.h> +#include <linux/log2.h> #define DM_MSG_PREFIX "raid1"#define DM_IO_PAGES 64
@@ -962,7 +963,7 @@ static void free_context(struct mirror_set *ms, struct dm_target *ti,static inline int _check_region_size (struct dm_target *ti,uint32_t size) { -return !(size % (PAGE_SIZE >>9 ) || (size & (size -1 )) || +return !(size % (PAGE_SIZE >>9 ) || !is_power_of_2 (size) || size > ti->len); }
drivers/md/dm-snap.c +2 -1
@@ -17,6 +17,7 @@#include <linux/module.h> #include <linux/slab.h> #include <linux/vmalloc.h> +#include <linux/log2.h> #include "dm-snap.h" #include "dm-bio-list.h"
@@ -414,7 +415,7 @@ static int set_chunk_size(struct dm_snapshot *s, const char *chunk_size_arg, chunk_size =round_up (chunk_size,PAGE_SIZE >>9 );/* Check chunk_size is a power of 2 */ -if (chunk_size & (chunk_size -1 )) { +if (!is_power_of_2 (chunk_size)) { *error ="Chunk size is not a power of 2" ;return -EINVAL ; }
drivers/md/dm-stripe.c +2 -1
@@ -11,6 +11,7 @@#include <linux/blkdev.h> #include <linux/bio.h> #include <linux/slab.h> +#include <linux/log2.h> #define DM_MSG_PREFIX "striped"
@@ -99,7 +100,7 @@ static int stripe_ctr(struct dm_target *ti, unsigned int argc, char **argv)/* * chunk_size is a power of two */ -if (!chunk_size || (chunk_size & (chunk_size -1 )) || +if (!is_power_of_2 (chunk_size) || (chunk_size < (PAGE_SIZE >>SECTOR_SHIFT ))) { ti->error ="Invalid chunk size" ;return -EINVAL ;
Signature · 3 lines
Vignesh Babu BM _____________________________________________________________ "Why is it that every time I'm with you, makes me believe in magic?"