is_power_of_2-cxgb3/cxgb3_main.c

PATCH New vignesh babu 1 participant 1 message Jun 12, 2007

Subsystems (3)

Networking Network drivers Kernel janitors

lore

Share & tools

lore

vignesh babu

author

2007-06-12 05:02 UTC #0 lore raw

PATCH 1/1 is_power_of_2-cxgb3/cxgb3_main.c

Replacing (n & (n-1)) in the context of power of 2 checks with is_power_of_2

Signed-off-by vignesh babu <[email protected]>

---

drivers/net/cxgb3/cxgb3_main.c +3 -2

index 1b20f40..a124b33 100644
@@ -43,6 +43,7 @@
 #include <linux/proc_fs.h>
 #include <linux/rtnetlink.h>
 #include <linux/firmware.h>
+#include <linux/log2.h>
 #include <asm/uaccess.h>
 
 #include "common.h"

@@ -1818,8 +1819,8 @@ static int cxgb_extension_ioctl(struct net_device *dev, void __user *useraddr)
 			return -EBUSY;
 		if (copy_from_user(&m, useraddr, sizeof(m)))
 			return -EFAULT;
-		if (!m.rx_pg_sz || (m.rx_pg_sz & (m.rx_pg_sz - 1)) ||
-			!m.tx_pg_sz || (m.tx_pg_sz & (m.tx_pg_sz - 1)))
+		if (!is_power_of_2(m.rx_pg_sz) ||
+			!is_power_of_2(m.tx_pg_sz))
 			return -EINVAL;	/* not power of 2 */
 		if (!(m.rx_pg_sz & 0x14000))
 			return -EINVAL;	/* not 16KB or 64KB */

Signature · 3 lines

Vignesh Babu BM 
_____________________________________________________________ 
"Why is it that every time I'm with you, makes me believe in magic?"