Skip to contentSkip to conversation

is_power_of_2-ext2/super.c

PATCH New vignesh babu 1 participant 1 message Jun 13, 2007

Subsystems (2)
Kernel janitors ext2 file system
lore
Share & tools
lore

vignesh babu

author
#0 lore raw

PATCH 1/1 is_power_of_2-ext2/super.c

Replacing (n & (n-1)) in the context of power of 2 checks with is_power_of_2

Signed-off-by vignesh babu <[email protected]>

---

fs/ext2/super.c +2 -1
index 16337bf..05c14a6 100644
@@ -29,6 +29,7 @@
 #include <linux/vfs.h>
 #include <linux/seq_file.h>
 #include <linux/mount.h>
+#include <linux/log2.h>
 #include <asm/uaccess.h>
 #include "ext2.h"
 #include "xattr.h"

@@ -803,7 +804,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
 		sbi->s_inode_size = le16_to_cpu(es->s_inode_size);
 		sbi->s_first_ino = le32_to_cpu(es->s_first_ino);
 		if ((sbi->s_inode_size < EXT2_GOOD_OLD_INODE_SIZE) ||
-		    (sbi->s_inode_size & (sbi->s_inode_size - 1)) ||
+		    (!is_power_of_2(sbi->s_inode_size)) ||
 		    (sbi->s_inode_size > blocksize)) {
 			printk ("EXT2-fs: unsupported inode size: %d\n",
 				sbi->s_inode_size);
Signature · 3 lines
Vignesh Babu BM 
_____________________________________________________________ 
"Why is it that every time I'm with you, makes me believe in magic?"