Skip to contentSkip to conversation

is_power_of_2-scsi/NCR53C9x.c

PATCH RESEND New vignesh babu 1 participant 1 message Jun 13, 2007

Subsystems (2)
SCSI Kernel janitors
lore
Share & tools
lore

vignesh babu

author
#0 lore raw

PATCH RESEND 1/1 is_power_of_2-scsi/NCR53C9x.c

David S. Miller ([email protected]) LSILOGIC/SYMBIOS/NCR 53C8XX and 53C1010 PCI-SCSI drivers
P: Matthew Wilcox
M: [email protected]
L: [email protected]
S: Maintained

Replacing (n & (n-1)) in the context of power of 2 checks with is_power_of_2

Thanks Mathew for pointing out the double check that was going on for 0.I have fixed that.

Signed-off-by vignesh babu <[email protected]>

---

drivers/scsi/NCR53C9x.c +2 -3
index 8b5334c..60692dc 100644
@@ -33,6 +33,7 @@
 #include <linux/proc_fs.h>
 #include <linux/stat.h>
 #include <linux/init.h>
+#include <linux/log2.h>
 
 #include "scsi.h"
 #include <scsi/scsi_host.h>

@@ -1648,10 +1649,8 @@ static inline int reconnect_target(struct NCR_ESP *esp, struct ESP_regs *eregs)
 	if(2 != fcount(esp, eregs))
 		return -1;
 	it = esp_read(eregs->esp_fdata);
-	if(!(it & me))
-		return -1;
 	it &= ~me;
-	if(it & (it - 1))
+	if(!is_power_of_2(it))
 		return -1;
 	while(!(it & 1))
 		targ++, it >>= 1;
Signature · 3 lines
Vignesh Babu BM 
_____________________________________________________________ 
"Why is it that every time I'm with you, makes me believe in magic?"