is_power_of_2-ntfs
Subsystems (2)
PATCH 1/1 is_power_of_2-ntfs
Replacing (n & (n-1)) in the context of power of 2 checks with is_power_of_2
Signed-off-by vignesh babu <[email protected]>
---
fs/ntfs/inode.c +2 -1
@@ -27,6 +27,7 @@#include <linux/pagemap.h> #include <linux/quotaops.h> #include <linux/slab.h> +#include <linux/log2.h> #include "aops.h" #include "attrib.h"
@@ -1574,7 +1575,7 @@ static int ntfs_read_locked_index_inode(struct inode *base_vi, struct inode *vi)ntfs_debug ("Index collation rule is 0x%x." ,le32_to_cpu (ir->collation_rule)); ni->itype.index.block_size =le32_to_cpu (ir->index_block_size); -if (ni->itype.index.block_size & (ni->itype.index.block_size -1 )) { +if (!is_power_of_2 (ni->itype.index.block_size)) {ntfs_error (vi->i_sb,"Index block size (%u) is not a power of " "two." , ni->itype.index.block_size); goto unm_err_out;
fs/ntfs/logfile.c +3 -3
@@ -26,6 +26,7 @@#include <linux/highmem.h> #include <linux/buffer_head.h> #include <linux/bitops.h> +#include <linux/log2.h> #include "attrib.h" #include "aops.h"
@@ -63,9 +64,8 @@ static bool ntfs_check_restart_page_header(struct inode *vi, logfile_log_page_size =le32_to_cpu (rp->log_page_size);if (logfile_system_page_size <NTFS_BLOCK_SIZE || logfile_log_page_size <NTFS_BLOCK_SIZE || - logfile_system_page_size & - (logfile_system_page_size -1 ) || - logfile_log_page_size & (logfile_log_page_size -1 )) { + !is_power_of_2 (logfile_system_page_size) || + !is_power_of_2 (logfile_log_page_size)) {ntfs_error (vi->i_sb,"$LogFile uses unsupported page size." );return false; }
Signature · 3 lines
Vignesh Babu BM _____________________________________________________________ "Why is it that every time I'm with you, makes me believe in magic?"