Skip to contentSkip to conversation

allow filenames with vgcfgrestore -l

PATCH New Bryn M. Reeves 2 participants 3 messages Jun 6, 2007 – Jun 15, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 allow filenames with vgcfgrestore -l

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Simple patch to permit a metadata backup file to be specified on the vgcfgrestore command line using -f when listing backups, for e.g.:

vgcfgrestore -l -f /tmp/VolGroup

LVM1 allowed this behavior and it's been requested a couple of times on the mailing list.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFGZzzk6YSQoMYUY94RAi+gAJ9xiDIQhdcV1a+78ko9TEaGijVTvgCgrag+ u1Fmzww3vn68W4AJ7CUvKfA=
=V+OQ
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vgcfgrestore_list_file.patch
Type: text/x-patch
Size: 4080 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20070607/c51132e8/attachment.bin>

#1 lore raw

PATCH 1/1 allow filenames with vgcfgrestore -l

Quoted 11 lines · Bryn M. Reeves

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Simple patch to permit a metadata backup file to be specified on the vgcfgrestore command line using -f when listing backups, for e.g.:

vgcfgrestore -l -f /tmp/VolGroup

LVM1 allowed this behavior and it's been requested a couple of times on the mailing list.

Bryn I just checked in fixes to the vgcfgrestore man pg. Could you take a look and see if it is ok?

#2 lore raw

PATCH 1/1 allow filenames with vgcfgrestore -l

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 7 lines · Dave Wysochanski
Quoted 6 lines · Bryn M. Reeves

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Simple patch to permit a metadata backup file to be specified on the vgcfgrestore command line using -f when listing backups, for e.g.:

Quoted 9 lines
Quoted 5 lines

vgcfgrestore -l -f /tmp/VolGroup

LVM1 allowed this behavior and it's been requested a couple of times on the mailing list.

Bryn I just checked in fixes to the vgcfgrestore man pg. Could you take a look and see if it is ok?

Dave,

Looks good to me - thanks! I wasn't sure how to word it but I think your changes make it clear.

The change to add -f was motivated by the fact that users found the man page confusing as it didn't forbid -f with -l and people found this ambiguous as LVM1 allowed that - I think your changes clear this up.

Regards,
Bryn.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFGcrpV6YSQoMYUY94RAi8hAJ4zQqEVlV+FOt//2QDTH5W9WLmINgCeJ8R9 Eb95R/f8g72c56y2XS6RYe4=
=nrBZ
-----END PGP SIGNATURE-----