maps2-add-proc-kpagemap-interface.patch
Quoted 10 lines
+ * Each entry is a pair of unsigned longs representing the
+ * corresponding physical page, the first containing the page flags
+ * and the second containing the page use count.
+ *
+ * The first 4 bytes of this file form a simple header:
+ *+ * first byte: 0 for big endian, 1 for little + * second byte: page shift (eg 12 for 4096 byte pages) + * third byte: entry size in bytes (currently either 4 or 8) + * fourth byte: header size
Hi Matt,
This comment is worded badly: if the "entry is a pair" then "entry size
in bytes" would be 8 or 16.
Review
Quoted 2 lines
(quoted diff) +2
-0+ pfn = src / KPMSIZE - 1; + count = min_t(size_t, count, ((max_pfn + 1) * KPMSIZE) - src);
Is min_t required here? KPMSIZE is a sizeof() expression, so I'd expect both sides to be type-compatible...
Review
Quoted 3 lines
(quoted diff) +3
-0+ page = (unsigned long *)__get_free_page(GFP_USER); + if (!page) + return -ENOMEM;
An explicit "struct kpagemap { unsigned long flags, count; };" would simplify your iteration, clear up the code and get rid of the KPMSIZE & KPMMASK macros.
But again I'd query the necessity of this cache page at all.
Review
Quoted 9 lines
(quoted diff) +9
-0+ if (copy_to_user(buf, page, chunk)) { + ret = -EFAULT; + break; + } + ret += chunk; + src += chunk; + buf += chunk; + count -= chunk; + cond_resched();
No cond_resched() needed here, either.
Cheers,
Rusty.