Skip to contentSkip to conversation

__deprecated not defined for Linux 2.4

PATCH Applied Wolfgang Grandegger 3 participants 12 messages Jul 9, 2007

lore
Share & tools
lore

Wolfgang Grandegger

author
#0 lore raw

PATCH 1/1 __deprecated not defined for Linux 2.4

Hello,

the attached patch changes:

2007-07-09 Wolfgang Grandegger <[email protected]>

* include/asm-generic/wrappers.h: add __deprecated for Linux 2.4.

Wolfgang.

asm-generic/wrappers.h +2 -0
Index: include/asm-generic/wrappers.h
===================================================================
@@ -179,6 +179,8 @@ void show_stack(struct task_struct *task
 
 #define atomic_cmpxchg(v, old, new) ((int)cmpxchg(&((v)->counter), old, new))
 
+#define __deprecated  __attribute__((deprecated))
+
 #else /* LINUX_VERSION_CODE >= KERNEL_VERSION(2,5,0) */
 
 #define compat_module_param_array(name, type, count, perm) \
ChangeLog +4 -0
Index: ChangeLog
===================================================================
@@ -1,3 +1,7 @@
+2007-07-09  Wolfgang Grandegger  <[email protected]>
+
+	* include/asm-generic/wrappers.h: add  __deprecated for Linux 2.4.
+
 2007-07-08  Philippe Gerum  <[email protected]>
 
 	* xenomai: Upgrade to autoconf 2.61, automake 1.10, libtool
#2 lore raw
Quoted 11 lines · Philippe Gerum
Quoted 8 lines · Wolfgang Grandegger

Hello,

the attached patch changes:

   2007-07-09  Wolfgang Grandegger  <[email protected]>

* include/asm-generic/wrappers.h: add __deprecated for Linux 2.4.

Merged, thanks.

You are too fast for me - I was still test-building my approach!

Looks rather like I picked the wrong expression for marking rtdm_task_sleep_until deprecated. I would prefer to go for this variant and back Wolfgang's patch out again:

rtdm/rtdm_driver.h (Arbeitskopie) renamed from rtdm/rtdm_driver.h (Revision 2758) +1 -1
@@ -1009,7 +1009,7 @@ rtdm_task_sleep_abs(nanosecs_abs_t wakeu
 }
 
 /* rtdm_task_sleep_abs shall be used instead */
-static inline int __deprecated
+static inline int __deprecated_call__
 rtdm_task_sleep_until(nanosecs_abs_t wakeup_time)
 {
     return __rtdm_task_sleep(wakeup_time, XN_REALTIME);

But note that I'm still test-building...

Jan

#3 lore raw
Quoted 11 lines · Jan Kiszka
Quoted 10 lines · Philippe Gerum
Quoted 8 lines · Wolfgang Grandegger

Hello,

the attached patch changes:

   2007-07-09  Wolfgang Grandegger  <[email protected]>

* include/asm-generic/wrappers.h: add __deprecated for Linux 2.4.

Quoted 7 lines
Quoted 1 line

Merged, thanks.

You are too fast for me - I was still test-building my approach!

Looks rather like I picked the wrong expression for marking rtdm_task_sleep_until deprecated. I would prefer to go for this variant and back Wolfgang's patch out again:

__deprecated is going to be useful in backporting 2.6 stuff to 2.4. This is not only a RTDM issue.

Quoted 18 lines
rtdm/rtdm_driver.h (Arbeitskopie) renamed from rtdm/rtdm_driver.h (Revision 2758) +1 -1
@@ -1009,7 +1009,7 @@ rtdm_task_sleep_abs(nanosecs_abs_t wakeu
 }
 
 /* rtdm_task_sleep_abs shall be used instead */
-static inline int __deprecated
+static inline int __deprecated_call__
 rtdm_task_sleep_until(nanosecs_abs_t wakeup_time)
 {
     return __rtdm_task_sleep(wakeup_time, XN_REALTIME);

But note that I'm still test-building...

Jan

Signature · 1 line
Philippe.
#4 lore raw
Quoted 12 lines · Philippe Gerum
Quoted 11 lines · Jan Kiszka
Quoted 10 lines · Philippe Gerum
Quoted 8 lines · Wolfgang Grandegger

Hello,

the attached patch changes:

   2007-07-09  Wolfgang Grandegger  <[email protected]>

* include/asm-generic/wrappers.h: add __deprecated for Linux 2.4.

Merged, thanks.

Quoted 8 lines
Quoted 5 lines

You are too fast for me - I was still test-building my approach!

Looks rather like I picked the wrong expression for marking rtdm_task_sleep_until deprecated. I would prefer to go for this variant and back Wolfgang's patch out again:

__deprecated is going to be useful in backporting 2.6 stuff to 2.4. This is not only a RTDM issue.

No problem, as you like it.

Jan

#5 lore raw
Quoted 15 lines · Jan Kiszka
Quoted 14 lines · Philippe Gerum
Quoted 13 lines · Jan Kiszka
Quoted 10 lines · Philippe Gerum
Quoted 8 lines · Wolfgang Grandegger

Hello,

the attached patch changes:

   2007-07-09  Wolfgang Grandegger  <[email protected]>

* include/asm-generic/wrappers.h: add __deprecated for Linux 2.4.

Merged, thanks.

You are too fast for me - I was still test-building my approach!

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

Looks rather like I picked the wrong expression for marking rtdm_task_sleep_until deprecated. I would prefer to go for this variant and back Wolfgang's patch out again:

__deprecated is going to be useful in backporting 2.6 stuff to 2.4. This is not only a RTDM issue.

No problem, as you like it.

Actually, I don't like wrappers that much, but, well...

Signature · 1 line
Philippe.
author
#6 lore raw
Quoted 16 lines · Philippe Gerum
Quoted 15 lines · Jan Kiszka
Quoted 14 lines · Philippe Gerum
Quoted 13 lines · Jan Kiszka
Quoted 10 lines · Philippe Gerum
Quoted 8 lines · Wolfgang Grandegger

Hello,

the attached patch changes:

   2007-07-09  Wolfgang Grandegger  <[email protected]>

* include/asm-generic/wrappers.h: add __deprecated for Linux 2.4.

Merged, thanks.

You are too fast for me - I was still test-building my approach!

Quoted 8 lines
Quoted 6 lines
Quoted 5 lines
Quoted 3 lines

Looks rather like I picked the wrong expression for marking rtdm_task_sleep_until deprecated. I would prefer to go for this variant and back Wolfgang's patch out again:

__deprecated is going to be useful in backporting 2.6 stuff to 2.4. This is not only a RTDM issue.

No problem, as you like it.

Actually, I don't like wrappers that much, but, well...

I just realized, that __deprecated_call__ is _not_ defined in 2.4 but already in include/nucleus/compiler.h!

Wolfgang.

#7 lore raw
Quoted 20 lines · Wolfgang Grandegger
Quoted 19 lines · Philippe Gerum
Quoted 18 lines · Jan Kiszka
Quoted 17 lines · Philippe Gerum
Quoted 16 lines · Jan Kiszka
Quoted 10 lines · Philippe Gerum
Quoted 8 lines · Wolfgang Grandegger

Hello,

the attached patch changes:

   2007-07-09  Wolfgang Grandegger  <[email protected]>

* include/asm-generic/wrappers.h: add __deprecated for Linux 2.4.

Merged, thanks.

You are too fast for me - I was still test-building my approach!

Looks rather like I picked the wrong expression for marking rtdm_task_sleep_until deprecated. I would prefer to go for this variant and back Wolfgang's patch out again:

Quoted 9 lines
Quoted 5 lines
Quoted 3 lines
Quoted 2 lines

__deprecated is going to be useful in backporting 2.6 stuff to 2.4. This is not only a RTDM issue.

No problem, as you like it.

Actually, I don't like wrappers that much, but, well...

I just realized, that __deprecated_call__ is _not_ defined in 2.4 but already in include/nucleus/compiler.h!

Indeed. __deprecated should go there too btw. Will fix.

Quoted 3 lines

Wolfgang.

Signature · 1 line
Philippe.
author
#8 lore raw
In reply to Jan Kiszka
Quoted 6 lines · Jan Kiszka
Quoted 5 lines · Philippe Gerum
Quoted 4 lines · Wolfgang Grandegger

Hello,

the attached patch changes:

Quoted 7 lines
Quoted 5 lines
Quoted 4 lines
   2007-07-09  Wolfgang Grandegger  <[email protected]>

* include/asm-generic/wrappers.h: add __deprecated for Linux 2.4.

Merged, thanks.

You are too fast for me - I was still test-building my approach!

Too fast? My i-Pipe patched Linux 2.4 kernel did simply not built ;-).

Quoted 17 lines

Looks rather like I picked the wrong expression for marking rtdm_task_sleep_until deprecated. I would prefer to go for this variant and back Wolfgang's patch out again:

rtdm/rtdm_driver.h (Arbeitskopie) renamed from rtdm/rtdm_driver.h (Revision 2758) +1 -1
@@ -1009,7 +1009,7 @@ rtdm_task_sleep_abs(nanosecs_abs_t wakeu
 }
 
 /* rtdm_task_sleep_abs shall be used instead */
-static inline int __deprecated
+static inline int __deprecated_call__
 rtdm_task_sleep_until(nanosecs_abs_t wakeup_time)
 {
     return __rtdm_task_sleep(wakeup_time, XN_REALTIME);
Quoted 1 line

But note that I'm still test-building...

OK, __deprecated_call__ does not make trouble with 2.4.

Wolfgang.

#9 lore raw
Quoted 9 lines · Wolfgang Grandegger
Quoted 8 lines · Jan Kiszka
Quoted 7 lines · Philippe Gerum
Quoted 6 lines · Wolfgang Grandegger

Hello,

the attached patch changes:

   2007-07-09  Wolfgang Grandegger  <[email protected]>
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 2 lines

* include/asm-generic/wrappers.h: add __deprecated for Linux 2.4.

Merged, thanks.

You are too fast for me - I was still test-building my approach!

Too fast? My i-Pipe patched Linux 2.4 kernel did simply not built ;-).

Yeah, and my 2.4 kernel was lying around in the corner, slightly dusty, definitely not touched for several months.

Hell, the amount of regressions one (specifically I) can produce due to all this config variants is amazing. What would be really nice is a playground for patches, some build system you could post a patch series and a set of .configs to and that will then "simply" try to generate various kernels and the xenomai userland for various archs automatically, reporting back any errors or warnings. Without going through SVN with the changes every time. Just a dream.

Jan

#10 lore raw
Quoted 16 lines · Jan Kiszka
Quoted 15 lines · Wolfgang Grandegger
Quoted 13 lines · Jan Kiszka
Quoted 10 lines · Philippe Gerum
Quoted 8 lines · Wolfgang Grandegger

Hello,

the attached patch changes:

   2007-07-09  Wolfgang Grandegger  <[email protected]>

* include/asm-generic/wrappers.h: add __deprecated for Linux 2.4.

Merged, thanks.

You are too fast for me - I was still test-building my approach!

Quoted 7 lines
Quoted 1 line

Too fast? My i-Pipe patched Linux 2.4 kernel did simply not built ;-).

Yeah, and my 2.4 kernel was lying around in the corner, slightly dusty, definitely not touched for several months.

Hell, the amount of regressions one (specifically I) can produce due to all this config variants is amazing.

We all have a very well defined job in this project, and particularly:
- I do produce the original silly bugs.
- You are in charge of adding regressions to your past fixes of my bugs
- Dmitry is in charge of finding why our common code breaks.
- Wolfgang is in charge of making all the involved fixes compile properly.
- Gilles is in charge of making the result run on bugous and/or sluggish hardware.

Ok, all in all, my situation is the best one. Good.

Quoted 6 lines

What would be really nice is a
playground for patches, some build system you could post a patch series and a set of .configs to and that will then "simply" try to generate various kernels and the xenomai userland for various archs automatically, reporting back any errors or warnings. Without going through SVN with the changes every time. Just a dream.

Niklaus already built most of this infrastructure for us, only the automated patching part seems to be missing so far:
http://ngiger.dyndns.org/buildbot/

We would also have to alleviate the burden of his server by providing some dedicated hardware to do that, though.

Quoted 3 lines

Jan

Signature · 1 line
Philippe.
#11 lore raw
Quoted 31 lines · Philippe Gerum
Quoted 12 lines · Jan Kiszka
Quoted 11 lines · Wolfgang Grandegger
Quoted 10 lines · Jan Kiszka
Quoted 9 lines · Philippe Gerum
Quoted 8 lines · Wolfgang Grandegger

Hello,

the attached patch changes:

   2007-07-09  Wolfgang Grandegger  <[email protected]>

* include/asm-generic/wrappers.h: add __deprecated for Linux 2.4.

Quoted 8 lines
Quoted 3 lines
Quoted 2 lines
Quoted 1 line

Merged, thanks.

You are too fast for me - I was still test-building my approach!

Too fast? My i-Pipe patched Linux 2.4 kernel did simply not built ;-).

Yeah, and my 2.4 kernel was lying around in the corner, slightly dusty, definitely not touched for several months.

Hell, the amount of regressions one (specifically I) can produce due to all this config variants is amazing.

We all have a very well defined job in this project, and particularly:
- I do produce the original silly bugs.
- You are in charge of adding regressions to your past fixes of my bugs
- Dmitry is in charge of finding why our common code breaks.
- Wolfgang is in charge of making all the involved fixes compile properly.
- Gilles is in charge of making the result run on bugous and/or sluggish hardware.

Quoted 1 line

Ok, all in all, my situation is the best one. Good.

Yeah, it's certainly not bad when the boss is happy. :)

Quoted 11 lines
Quoted 7 lines

What would be really nice is a
playground for patches, some build system you could post a patch series and a set of .configs to and that will then "simply" try to generate various kernels and the xenomai userland for various archs automatically, reporting back any errors or warnings. Without going through SVN with the changes every time. Just a dream.

Niklaus already built most of this infrastructure for us, only the automated patching part seems to be missing so far:
http://ngiger.dyndns.org/buildbot/

I'm very well aware of his work, but I also know that it was never intended for broad use due to hardware and bandwidth constraints. However, his buildbot scripts may indeed provide a helpful foundation.

Quoted 2 lines

We would also have to alleviate the burden of his server by providing some dedicated hardware to do that, though.

That together with the required software infrastructure for more automation are the points. We need some nice parallel box (4-way or more) with a fast link and someone to look after the software. The latter work may partly be distributed among the arch maintainers (toolchain, kernel, .config updates). One could go even further with such a platform, e.g. qemu targets, but let's concentrate on multi-arch, multi-kernel build services first.

(My worries are also a bit egoistic: the nice 4-way box I'm using so far for certain builds and tests will be definitely out of reach for me in the near future.)

Jan