Skip to contentSkip to conversation

QE Ethernet driver writes to wrong register to mask interrupts

PATCH Applied Timur Tabi 3 participants 3 messages Jul 10, 2007

Subsystems (2)
lore
Share & tools
lore

Timur Tabi

author
#0 lore raw

PATCH 1/1 QE Ethernet driver writes to wrong register to mask interrupts

The QE Ethernet driver was writing to the wrong register to mask interrupts. In ucc_geth_stop(), it was clearing UCCE instead of UCCM.

---
 drivers/net/ucc_geth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/ucc_geth.c +1 -1
index 18b731b..e4736a3 100644
@@ -2276,7 +2276,7 @@ static void ucc_geth_stop(struct ucc_geth_private *ugeth)
 	phy_stop(phydev);
 
 	/* Mask all interrupts */
-	out_be32(ugeth->uccf->p_ucce, 0x00000000);
+	out_be32(ugeth->uccf->p_uccm, 0x00000000);
 
 	/* Clear all interrupts */
 	out_be32(ugeth->uccf->p_ucce, 0xffffffff);
Signature · 1 line
1.5.0.2.260.g2eb065
Acked-by on v1 1/1
#1 lore raw
Quoted 2 lines

-----Original Message-----
From: [email protected]

[mailto:[email protected]] On

Quoted 5 lines

Behalf Of Tabi Timur-B04825
Sent: Tuesday, July 10, 2007 8:51 PM
To: [email protected]; [email protected]
Cc: Tabi Timur-B04825
Subject: [PATCH] QE Ethernet driver writes to wrong register to mask

interrupts

Quoted 2 lines

The QE Ethernet driver was writing to the wrong register to mask

interrupts.

Quoted 3 lines

In ucc_geth_stop(), it was clearing UCCE instead of UCCM.

Applied
#2 lore raw
In reply to Timur Tabi
Quoted 7 lines · Timur Tabi

The QE Ethernet driver was writing to the wrong register to mask interrupts. In ucc_geth_stop(), it was clearing UCCE instead of UCCM.

---
 drivers/net/ucc_geth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

applied