ieee1394: forgotten dereference...
PATCH 1/1 ieee1394: forgotten dereference...
Going through the string and waiting for _pointer_ to become '\0' is not what the authors meant...
Signed-off-by Al Viro <[email protected]>
--- drivers/ieee1394/nodemgr.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/ieee1394/nodemgr.c +1 -1
@@ -283,7 +283,7 @@ static ssize_t fw_show_##class##_##td_kv (struct device *dev, struct device_attrmemcpy (buf, \CSR1212_TEXTUAL_DESCRIPTOR_LEAF_DATA (class->td_kv), \ len); \ -while ((buf + len -1 ) =='\0' ) \ +while (buf[len -1 ] =='\0' ) \ len--; \ buf[len++] ='\n' ; \ buf[len] ='\0' ; \
Signature · 1 line
1.5.3.GIT
Quoted 13 lines · Al Viro
Going through the string and waiting for _pointer_ to become '\0' is not what the authors meant...
Signed-off-by Al Viro <[email protected]>--- drivers/ieee1394/nodemgr.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/ieee1394/nodemgr.c +0
-0
drivers/ieee1394/nodemgr.c static ssize_t fw_show_##class##_##td_kv (struct device *dev, struct device_attr · line 289
Quoted 8 lines
drivers/ieee1394/nodemgr.c +1
-1@@ -283,7 +283,7 @@ static ssize_t fw_show_##class##_##td_kv (struct device *dev, struct device_attrmemcpy (buf, \CSR1212_TEXTUAL_DESCRIPTOR_LEAF_DATA (class->td_kv), \ len); \ -while ((buf + len -1 ) =='\0' ) \ +while (buf[len -1 ] =='\0' ) \ len--; \ buf[len++] ='\n' ; \ buf[len] ='\0' ; \
ACK
Definitely looks right with your patch. Thanks.
Signature · 2 lines
Ubuntu : http://www.ubuntu.com/ Linux1394: http://wiki.linux1394.org/