Skip to contentSkip to conversation

BT87x ALSA driver patches

DISCUSSION Trent Piepho 3 participants 5 messages Jul 25, 2007 – Jul 27, 2007 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): 1185200670.8251.3.camel@gaivota

#2 lore raw
Quoted 8 lines · Mauro Carvalho Chehab

Em Sáb, 2007-07-21 às 17:36 -0700, Trent Piepho escreveu:

Quoted 5 lines

01/01: bttv: Fix Viewcast Osprey 440 support
http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=8e72fe5675b3

I have two other changes that only affect the ALSA driver part. Should I send those to ALSA or to you?

Please send to ALSA guys, c/c me.

Ok, I'll do that. What about the two lines to bt87x.c that this patch added? I seemed logical to me that they should be part of the same patch at git as the changes to bttv-cards.c, but I suppose it's not 100% necessary to do so, the kernel will still compile and not crash.

Do you plan to send this to git as one patch, or to strip out the ALSA change? I'm just wondering if I should send these two lines to the ALSA people as a separate patch, of if they will get them into their hg via a kernel-sync patch. My bt87x patches depend on this one, so somehow the ALSA hg needs to get this change before I can send them the next two.

The problem really, is that having two divers for the same chip split into v4l-dvb and ALSA like this a pain. IMHO, it would make a lot more sense to put the bttv alsa driver into v4l-dvb, like the saa7134 alsa and oss and cx88 alsa drivers are.

Quoted 3 lines
Quoted 3 lines
 drivers/media/video/bt8xx/bttv-cards.c |  240 ++++++++++++++++++---------------
 sound/pci/bt87x.c                      |    2
 2 files changed, 137 insertions(+), 105 deletions(-)

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#3 lore raw

At Wed, 25 Jul 2007 15:43:50 -0700 (PDT),

Quoted 9 lines · Trent Piepho
Quoted 7 lines · Mauro Carvalho Chehab

Em Sáb, 2007-07-21 às 17:36 -0700, Trent Piepho escreveu:

Quoted 5 lines

01/01: bttv: Fix Viewcast Osprey 440 support
http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=8e72fe5675b3

I have two other changes that only affect the ALSA driver part. Should I send those to ALSA or to you?

Quoted 6 lines
Quoted 1 line

Please send to ALSA guys, c/c me.

Ok, I'll do that. What about the two lines to bt87x.c that this patch added? I seemed logical to me that they should be part of the same patch at git as the changes to bttv-cards.c, but I suppose it's not 100% necessary to do so, the kernel will still compile and not crash.

In such a case, I think one patch makes more sense.

Mauro, please apply it from your tree all together?

Quoted 10 lines

Do you plan to send this to git as one patch, or to strip out the ALSA change? I'm just wondering if I should send these two lines to the ALSA people as a separate patch, of if they will get them into their hg via a kernel-sync patch. My bt87x patches depend on this one, so somehow the ALSA hg needs to get this change before I can send them the next two.

The problem really, is that having two divers for the same chip split into v4l-dvb and ALSA like this a pain. IMHO, it would make a lot more sense to put the bttv alsa driver into v4l-dvb, like the saa7134 alsa and oss and cx88 alsa drivers are.

OTOH, fixing cx88 and saa7134 codes are also painful for us :)

thanks,

Takashi

#4 lore raw

Em Qui, 2007-07-26 às 12:01 +0200, Takashi Iwai escreveu:

Quoted 13 lines

At Wed, 25 Jul 2007 15:43:50 -0700 (PDT),

Quoted 11 lines · Trent Piepho
Quoted 8 lines · Mauro Carvalho Chehab

Em Sáb, 2007-07-21 às 17:36 -0700, Trent Piepho escreveu:

Quoted 5 lines

01/01: bttv: Fix Viewcast Osprey 440 support
http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=8e72fe5675b3

I have two other changes that only affect the ALSA driver part. Should I send those to ALSA or to you?

Please send to ALSA guys, c/c me.

Quoted 8 lines
Quoted 4 lines

Ok, I'll do that. What about the two lines to bt87x.c that this patch added? I seemed logical to me that they should be part of the same patch at git as the changes to bttv-cards.c, but I suppose it's not 100% necessary to do so, the kernel will still compile and not crash.

In such a case, I think one patch makes more sense.

Mauro, please apply it from your tree all together?

Ok. The changeset with the newer PCI IDs, together with the V4L changes, is available on my tree at:

http://git.kernel.org/?p=linux/kernel/git/mchehab/v4l-dvb.git;a=commit;h=99f8a23a98ae6b7af7f821fd25865b1dbf5375ac

Do you wanna me also to take care of the changesets improving bt87x to properly work with Osprey 440, or do you prefer if Trent sent you directly, c/c me?

Quoted 1 line

OTOH, fixing cx88 and saa7134 codes are also painful for us :)

There's no easy solution for those "merged" work...

Signature · 7 lines
Cheers,
Mauro

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
#5 lore raw

At Fri, 27 Jul 2007 12:11:15 -0300,

Quoted 20 lines · Mauro Carvalho Chehab

Em Qui, 2007-07-26 às 12:01 +0200, Takashi Iwai escreveu:

Quoted 18 lines

At Wed, 25 Jul 2007 15:43:50 -0700 (PDT),

Quoted 15 lines · Trent Piepho
Quoted 8 lines · Mauro Carvalho Chehab

Em Sáb, 2007-07-21 às 17:36 -0700, Trent Piepho escreveu:

Quoted 5 lines

01/01: bttv: Fix Viewcast Osprey 440 support
http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=8e72fe5675b3

I have two other changes that only affect the ALSA driver part. Should I send those to ALSA or to you?

Please send to ALSA guys, c/c me.

Ok, I'll do that. What about the two lines to bt87x.c that this patch added? I seemed logical to me that they should be part of the same patch at git as the changes to bttv-cards.c, but I suppose it's not 100% necessary to do so, the kernel will still compile and not crash.

Quoted 8 lines
Quoted 3 lines

In such a case, I think one patch makes more sense.

Mauro, please apply it from your tree all together?

Ok. The changeset with the newer PCI IDs, together with the V4L changes, is available on my tree at:

http://git.kernel.org/?p=linux/kernel/git/mchehab/v4l-dvb.git;a=commit;h=99f8a23a98ae6b7af7f821fd25865b1dbf5375ac

Thanks!

Quoted 3 lines

Do you wanna me also to take care of the changesets improving bt87x to properly work with Osprey 440, or do you prefer if Trent sent you directly, c/c me?

I don't mind you apply and push it from your tree at all, but patches are always welcome, even only for checking.

Takashi

#6 lore raw
Quoted 7 lines
Quoted 4 lines

Do you wanna me also to take care of the changesets improving bt87x to properly work with Osprey 440, or do you prefer if Trent sent you directly, c/c me?

I don't mind you apply and push it from your tree at all, but patches are always welcome, even only for checking.

For me, both ways should work fine. Of course, it is important to have your eyes looking at those changesets.

Signature · 2 lines
Cheers,
Mauro