HW VLAN filtering control
Subsystems (2)
cover HW VLAN filtering control
This patchset adds the capability to disable hardware VLAN filtering at runtime via the existing vconfig utility. It's useful for debugging purposes.
The first patch modifies the VLAN subsystem to define the flag, and to support passing the flag on to the base driver.
The second patch modifies e1000 to support the flag. Since it's only one function, other drivers can be easily modified to support this functionality.
vconfig is used without modification to enable or disable filtering:
# vconfig [vlan-interface] 2 1 will disable filtering, and # vconfig [vlan-interface] 2 0 will enable filtering.
Quoted 11 lines · Mitch Williams
This patchset adds the capability to disable hardware VLAN filtering at runtime via the existing vconfig utility. It's useful for debugging purposes.
The first patch modifies the VLAN subsystem to define the flag, and to support passing the flag on to the base driver.
The second patch modifies e1000 to support the flag. Since it's only one function, other drivers can be easily modified to support this functionality.
Quoted 5 lines
vconfig is used without modification to enable or disable filtering:
# vconfig [vlan-interface] 2 1 will disable filtering, and # vconfig [vlan-interface] 2 0 will enable filtering.
This looks fine to me.
Ben
Signature · 2 lines
Ben Greear <[email protected]> Candela Technologies Inc http://www.candelatech.com
Quoted 4 lines · Ben Greear
This looks fine to me.
Ben
Grr. Except that Evolution mangled them. I'll have to repost. -Mitch
Quoted 11 lines · Mitch Williams
This patchset adds the capability to disable hardware VLAN filtering at runtime via the existing vconfig utility. It's useful for debugging purposes.
The first patch modifies the VLAN subsystem to define the flag, and to support passing the flag on to the base driver.
The second patch modifies e1000 to support the flag. Since it's only one function, other drivers can be easily modified to support this functionality.
Quoted 5 lines
vconfig is used without modification to enable or disable filtering:
# vconfig [vlan-interface] 2 1 will disable filtering, and # vconfig [vlan-interface] 2 0 will enable filtering.
I think an ethtool option for this would be more consistent with configuration of other device features and its questionable whether new feature should be added to the ioctl interface at all. The vlan driver could perform the necessary reconfiguration in the FEAT_CHANGE notifier call.