Skip to contentSkip to conversation

hwmon: fix lm78 detection regression

PATCH New Mark M. Hoffman 1 participant 1 message Jul 31, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon: fix lm78 detection regression

From: Hans de Goede <[email protected]>

Here is a small but important bugfix to the lm78 driver. I found out about this problem because a Fedora user filed a bug that the lm78 driver no longer worked on his system: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id$9428

The problem is that sometime ago the isa lm78 detection was made more stringent and this new code now checks the chip-id, but does not accept a chip-id of 20h, however a chip-id of 20h is valid, and is excepted in the main probe function of the driver, see line 551. This fixed also makes the isa detection code accept the chip-id of 0x20 fixing this issue.

---
 drivers/hwmon/lm78.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/hwmon/lm78.c +1 -1
index 9fb572f..565c4e6 100644
@@ -864,7 +864,7 @@ static int __init lm78_isa_found(unsigned short address)
 	/* Determine the chip type */
 	outb_p(LM78_REG_CHIPID, address + LM78_ADDR_REG_OFFSET);
 	val = inb_p(address + LM78_DATA_REG_OFFSET);
-	if (val = 0x00			/* LM78 */
+	if (val = 0x00 || val = 0x20	/* LM78 */
 	 || val = 0x40			/* LM78-J */
 	 || (val & 0xfe) = 0xc0)	/* LM79 */
 		found = 1;
Signature · 7 lines
1.5.2.2


_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors