drivers/hwmon - 'defined but not used' warnings

PATCH In review Gabriel C 3 participants 5 messages Jul 21, 2007 – Jul 31, 2007

Subsystems (4)

Hardware monitoring IT87 hardware monitoring driver PC87360 hardware monitoring driver VT8231 hardware monitor driver

lore

Share & tools

lore

Gabriel C

author

2007-07-21 22:30 UTC #0 lore raw

Hi ,

I noticed this warnings on current git:

...

drivers/hwmon/pc87360.c:1082: warning: 'pc87360_remove' defined but not used drivers/hwmon/sis5595.c:580: warning: 'sis5595_remove' defined but not used drivers/hwmon/smsc47m1.c:608: warning: 'smsc47m1_remove' defined but not used drivers/hwmon/via686a.c:648: warning: 'via686a_remove' defined but not used drivers/hwmon/vt8231.c:755: warning: 'vt8231_remove' defined but not used

...

Regards,

Gabriel C

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Jean Delvare

2007-07-22 10:08 UTC #1 lore raw

PATCH 1/1 hwmon: Add missing __devexit tags in various drivers

Quoted 7 lines · Gabriel C

I noticed this warnings on current git:
drivers/hwmon/pc87360.c:1082: warning: 'pc87360_remove' defined but not used drivers/hwmon/sis5595.c:580: warning: 'sis5595_remove' defined but not used drivers/hwmon/smsc47m1.c:608: warning: 'smsc47m1_remove' defined but not used drivers/hwmon/via686a.c:648: warning: 'via686a_remove' defined but not used drivers/hwmon/vt8231.c:755: warning: 'vt8231_remove' defined but not used

Signed-off-by Jean Delvare <[email protected]>

---
 drivers/hwmon/it87.c     |    2 +-
 drivers/hwmon/pc87360.c  |    2 +-
 drivers/hwmon/sis5595.c  |    2 +-
 drivers/hwmon/smsc47m1.c |    2 +-
 drivers/hwmon/via686a.c  |    2 +-
 drivers/hwmon/vt8231.c   |    4 ++--
 drivers/hwmon/w83627hf.c |    2 +-
 7 files changed, 8 insertions(+), 8 deletions(-)

drivers/hwmon/it87.c +1 -1

@@ -252,7 +252,7 @@ struct it87_data {
 
 
 static int it87_probe(struct platform_device *pdev);
-static int it87_remove(struct platform_device *pdev);
+static int __devexit it87_remove(struct platform_device *pdev);
 
 static int it87_read_value(struct it87_data *data, u8 reg);
 static void it87_write_value(struct it87_data *data, u8 reg, u8 value);

drivers/hwmon/pc87360.c +1 -1

@@ -220,7 +220,7 @@ struct pc87360_data {
  */
 
 static int pc87360_probe(struct platform_device *pdev);
-static int pc87360_remove(struct platform_device *pdev);
+static int __devexit pc87360_remove(struct platform_device *pdev);
 
 static int pc87360_read_value(struct pc87360_data *data, u8 ldi, u8 bank,
 			      u8 reg);

drivers/hwmon/sis5595.c +1 -1

@@ -187,7 +187,7 @@ struct sis5595_data {
 static struct pci_dev *s_bridge;	/* pointer to the (only) sis5595 */
 
 static int sis5595_probe(struct platform_device *pdev);
-static int sis5595_remove(struct platform_device *pdev);
+static int __devexit sis5595_remove(struct platform_device *pdev);
 
 static int sis5595_read_value(struct sis5595_data *data, u8 reg);
 static void sis5595_write_value(struct sis5595_data *data, u8 reg, u8 value);

drivers/hwmon/smsc47m1.c +1 -1

@@ -134,7 +134,7 @@ struct smsc47m1_sio_data {
 
 
 static int smsc47m1_probe(struct platform_device *pdev);
-static int smsc47m1_remove(struct platform_device *pdev);
+static int __devexit smsc47m1_remove(struct platform_device *pdev);
 static struct smsc47m1_data *smsc47m1_update_device(struct device *dev,
 		int init);

drivers/hwmon/via686a.c +1 -1

@@ -314,7 +314,7 @@ struct via686a_data {
 static struct pci_dev *s_bridge;	/* pointer to the (only) via686a */
 
 static int via686a_probe(struct platform_device *pdev);
-static int via686a_remove(struct platform_device *pdev);
+static int __devexit via686a_remove(struct platform_device *pdev);
 
 static inline int via686a_read_value(struct via686a_data *data, u8 reg)
 {

drivers/hwmon/vt8231.c +2 -2

@@ -167,7 +167,7 @@ struct vt8231_data {
 
 static struct pci_dev *s_bridge;
 static int vt8231_probe(struct platform_device *pdev);
-static int vt8231_remove(struct platform_device *pdev);
+static int __devexit vt8231_remove(struct platform_device *pdev);
 static struct vt8231_data *vt8231_update_device(struct device *dev);
 static void vt8231_init_device(struct vt8231_data *data);

@@ -751,7 +751,7 @@ exit_release:
 	return err;
 }
 
-static int vt8231_remove(struct platform_device *pdev)
+static int __devexit vt8231_remove(struct platform_device *pdev)
 {
 	struct vt8231_data *data = platform_get_drvdata(pdev);
 	int i;

drivers/hwmon/w83627hf.c +1 -1

@@ -384,7 +384,7 @@ struct w83627hf_sio_data {
 
 
 static int w83627hf_probe(struct platform_device *pdev);
-static int w83627hf_remove(struct platform_device *pdev);
+static int __devexit w83627hf_remove(struct platform_device *pdev);
 
 static int w83627hf_read_value(struct w83627hf_data *data, u16 reg);
 static int w83627hf_write_value(struct w83627hf_data *data, u16 reg, u16 value);

Signature · 1 line

Jean Delvare

Gabriel C

author

2007-07-22 11:03 UTC #2 lore raw

Re: [PATCH] hwmon: Add missing __devexit tags in various drivers

Quoted 8 lines · Jean Delvare

Quoted 7 lines · Gabriel C
I noticed this warnings on current git:
drivers/hwmon/pc87360.c:1082: warning: 'pc87360_remove' defined but not used drivers/hwmon/sis5595.c:580: warning: 'sis5595_remove' defined but not used drivers/hwmon/smsc47m1.c:608: warning: 'smsc47m1_remove' defined but not used drivers/hwmon/via686a.c:648: warning: 'via686a_remove' defined but not used drivers/hwmon/vt8231.c:755: warning: 'vt8231_remove' defined but not used

Thx , the patch fixes all this warnings.

Quoted 92 lines

Signed-off-by Jean Delvare <[email protected]>

---
 drivers/hwmon/it87.c     |    2 +-
 drivers/hwmon/pc87360.c  |    2 +-
 drivers/hwmon/sis5595.c  |    2 +-
 drivers/hwmon/smsc47m1.c |    2 +-
 drivers/hwmon/via686a.c  |    2 +-
 drivers/hwmon/vt8231.c   |    4 ++--
 drivers/hwmon/w83627hf.c |    2 +-
 7 files changed, 8 insertions(+), 8 deletions(-)

drivers/hwmon/it87.c +1 -1

@@ -252,7 +252,7 @@ struct it87_data {
 
 
 static int it87_probe(struct platform_device *pdev);
-static int it87_remove(struct platform_device *pdev);
+static int __devexit it87_remove(struct platform_device *pdev);
 
 static int it87_read_value(struct it87_data *data, u8 reg);
 static void it87_write_value(struct it87_data *data, u8 reg, u8 value);

drivers/hwmon/pc87360.c +1 -1

@@ -220,7 +220,7 @@ struct pc87360_data {
  */
 
 static int pc87360_probe(struct platform_device *pdev);
-static int pc87360_remove(struct platform_device *pdev);
+static int __devexit pc87360_remove(struct platform_device *pdev);
 
 static int pc87360_read_value(struct pc87360_data *data, u8 ldi, u8 bank,
 			      u8 reg);

drivers/hwmon/sis5595.c +1 -1

@@ -187,7 +187,7 @@ struct sis5595_data {
 static struct pci_dev *s_bridge;	/* pointer to the (only) sis5595 */
 
 static int sis5595_probe(struct platform_device *pdev);
-static int sis5595_remove(struct platform_device *pdev);
+static int __devexit sis5595_remove(struct platform_device *pdev);
 
 static int sis5595_read_value(struct sis5595_data *data, u8 reg);
 static void sis5595_write_value(struct sis5595_data *data, u8 reg, u8 value);

drivers/hwmon/smsc47m1.c +1 -1

@@ -134,7 +134,7 @@ struct smsc47m1_sio_data {
 
 
 static int smsc47m1_probe(struct platform_device *pdev);
-static int smsc47m1_remove(struct platform_device *pdev);
+static int __devexit smsc47m1_remove(struct platform_device *pdev);
 static struct smsc47m1_data *smsc47m1_update_device(struct device *dev,
 		int init);

drivers/hwmon/via686a.c +1 -1

@@ -314,7 +314,7 @@ struct via686a_data {
 static struct pci_dev *s_bridge;	/* pointer to the (only) via686a */
 
 static int via686a_probe(struct platform_device *pdev);
-static int via686a_remove(struct platform_device *pdev);
+static int __devexit via686a_remove(struct platform_device *pdev);
 
 static inline int via686a_read_value(struct via686a_data *data, u8 reg)
 {

drivers/hwmon/vt8231.c +2 -2

@@ -167,7 +167,7 @@ struct vt8231_data {
 
 static struct pci_dev *s_bridge;
 static int vt8231_probe(struct platform_device *pdev);
-static int vt8231_remove(struct platform_device *pdev);
+static int __devexit vt8231_remove(struct platform_device *pdev);
 static struct vt8231_data *vt8231_update_device(struct device *dev);
 static void vt8231_init_device(struct vt8231_data *data);

@@ -751,7 +751,7 @@ exit_release:
 	return err;
 }
 
-static int vt8231_remove(struct platform_device *pdev)
+static int __devexit vt8231_remove(struct platform_device *pdev)
 {
 	struct vt8231_data *data = platform_get_drvdata(pdev);
 	int i;

drivers/hwmon/w83627hf.c struct w83627hf_sio_data { · line 390

Quoted 8 lines

drivers/hwmon/w83627hf.c +1 -1

@@ -384,7 +384,7 @@ struct w83627hf_sio_data {
 
 
 static int w83627hf_probe(struct platform_device *pdev);
-static int w83627hf_remove(struct platform_device *pdev);
+static int __devexit w83627hf_remove(struct platform_device *pdev);
 
 static int w83627hf_read_value(struct w83627hf_data *data, u16 reg);
 static int w83627hf_write_value(struct w83627hf_data *data, u16 reg, u16 value);

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Mark M. Hoffman

2007-07-25 02:09 UTC #3 lore raw

Re: [PATCH] hwmon: Add missing __devexit tags in various drivers

In reply to Jean Delvare

Hi Jean:

Quoted 100 lines · Jean Delvare

Quoted 7 lines · Gabriel C

I noticed this warnings on current git:
drivers/hwmon/pc87360.c:1082: warning: 'pc87360_remove' defined but not used drivers/hwmon/sis5595.c:580: warning: 'sis5595_remove' defined but not used drivers/hwmon/smsc47m1.c:608: warning: 'smsc47m1_remove' defined but not used drivers/hwmon/via686a.c:648: warning: 'via686a_remove' defined but not used drivers/hwmon/vt8231.c:755: warning: 'vt8231_remove' defined but not used

Signed-off-by Jean Delvare <[email protected]>

---
 drivers/hwmon/it87.c     |    2 +-
 drivers/hwmon/pc87360.c  |    2 +-
 drivers/hwmon/sis5595.c  |    2 +-
 drivers/hwmon/smsc47m1.c |    2 +-
 drivers/hwmon/via686a.c  |    2 +-
 drivers/hwmon/vt8231.c   |    4 ++--
 drivers/hwmon/w83627hf.c |    2 +-
 7 files changed, 8 insertions(+), 8 deletions(-)

drivers/hwmon/it87.c +1 -1

@@ -252,7 +252,7 @@ struct it87_data {
 
 
 static int it87_probe(struct platform_device *pdev);
-static int it87_remove(struct platform_device *pdev);
+static int __devexit it87_remove(struct platform_device *pdev);
 
 static int it87_read_value(struct it87_data *data, u8 reg);
 static void it87_write_value(struct it87_data *data, u8 reg, u8 value);

drivers/hwmon/pc87360.c +1 -1

@@ -220,7 +220,7 @@ struct pc87360_data {
  */
 
 static int pc87360_probe(struct platform_device *pdev);
-static int pc87360_remove(struct platform_device *pdev);
+static int __devexit pc87360_remove(struct platform_device *pdev);
 
 static int pc87360_read_value(struct pc87360_data *data, u8 ldi, u8 bank,
 			      u8 reg);

drivers/hwmon/sis5595.c +1 -1

@@ -187,7 +187,7 @@ struct sis5595_data {
 static struct pci_dev *s_bridge;	/* pointer to the (only) sis5595 */
 
 static int sis5595_probe(struct platform_device *pdev);
-static int sis5595_remove(struct platform_device *pdev);
+static int __devexit sis5595_remove(struct platform_device *pdev);
 
 static int sis5595_read_value(struct sis5595_data *data, u8 reg);
 static void sis5595_write_value(struct sis5595_data *data, u8 reg, u8 value);

drivers/hwmon/smsc47m1.c +1 -1

@@ -134,7 +134,7 @@ struct smsc47m1_sio_data {
 
 
 static int smsc47m1_probe(struct platform_device *pdev);
-static int smsc47m1_remove(struct platform_device *pdev);
+static int __devexit smsc47m1_remove(struct platform_device *pdev);
 static struct smsc47m1_data *smsc47m1_update_device(struct device *dev,
 		int init);

drivers/hwmon/via686a.c +1 -1

@@ -314,7 +314,7 @@ struct via686a_data {
 static struct pci_dev *s_bridge;	/* pointer to the (only) via686a */
 
 static int via686a_probe(struct platform_device *pdev);
-static int via686a_remove(struct platform_device *pdev);
+static int __devexit via686a_remove(struct platform_device *pdev);
 
 static inline int via686a_read_value(struct via686a_data *data, u8 reg)
 {

drivers/hwmon/vt8231.c +2 -2

@@ -167,7 +167,7 @@ struct vt8231_data {
 
 static struct pci_dev *s_bridge;
 static int vt8231_probe(struct platform_device *pdev);
-static int vt8231_remove(struct platform_device *pdev);
+static int __devexit vt8231_remove(struct platform_device *pdev);
 static struct vt8231_data *vt8231_update_device(struct device *dev);
 static void vt8231_init_device(struct vt8231_data *data);

@@ -751,7 +751,7 @@ exit_release:
 	return err;
 }
 
-static int vt8231_remove(struct platform_device *pdev)
+static int __devexit vt8231_remove(struct platform_device *pdev)
 {
 	struct vt8231_data *data = platform_get_drvdata(pdev);
 	int i;

drivers/hwmon/w83627hf.c struct w83627hf_sio_data { · line 390

Quoted 8 lines

drivers/hwmon/w83627hf.c +1 -1

@@ -384,7 +384,7 @@ struct w83627hf_sio_data {
 
 
 static int w83627hf_probe(struct platform_device *pdev);
-static int w83627hf_remove(struct platform_device *pdev);
+static int __devexit w83627hf_remove(struct platform_device *pdev);
 
 static int w83627hf_read_value(struct w83627hf_data *data, u16 reg);
 static int w83627hf_write_value(struct w83627hf_data *data, u16 reg, u16 value);

Applied to hwmon-2.6.git/testing, thanks.

Signature · 8 lines

Mark M. Hoffman
[email protected]


_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Mark M. Hoffman

2007-07-31 01:39 UTC #4 lore raw

PATCH 1/1 hwmon: Add missing __devexit tags in various

In reply to Jean Delvare

From: Jean Delvare <[email protected]>

Quoted 7 lines · Gabriel C

I noticed this warnings on current git:
drivers/hwmon/pc87360.c:1082: warning: 'pc87360_remove' defined but not used drivers/hwmon/sis5595.c:580: warning: 'sis5595_remove' defined but not used drivers/hwmon/smsc47m1.c:608: warning: 'smsc47m1_remove' defined but not used drivers/hwmon/via686a.c:648: warning: 'via686a_remove' defined but not used drivers/hwmon/vt8231.c:755: warning: 'vt8231_remove' defined but not used

Signed-off-by Jean Delvare <[email protected]>

Signed-off-by Mark M. Hoffman <[email protected]>

---
 drivers/hwmon/it87.c     |    2 +-
 drivers/hwmon/pc87360.c  |    2 +-
 drivers/hwmon/sis5595.c  |    2 +-
 drivers/hwmon/smsc47m1.c |    2 +-
 drivers/hwmon/via686a.c  |    2 +-
 drivers/hwmon/vt8231.c   |    4 ++--
 drivers/hwmon/w83627hf.c |    2 +-
 7 files changed, 8 insertions(+), 8 deletions(-)

drivers/hwmon/it87.c +1 -1

index eff6036..d75dba9 100644
@@ -252,7 +252,7 @@ struct it87_data {
 
 
 static int it87_probe(struct platform_device *pdev);
-static int it87_remove(struct platform_device *pdev);
+static int __devexit it87_remove(struct platform_device *pdev);
 
 static int it87_read_value(struct it87_data *data, u8 reg);
 static void it87_write_value(struct it87_data *data, u8 reg, u8 value);

drivers/hwmon/pc87360.c +1 -1

index cb72526..f57c75d 100644
@@ -220,7 +220,7 @@ struct pc87360_data {
  */
 
 static int pc87360_probe(struct platform_device *pdev);
-static int pc87360_remove(struct platform_device *pdev);
+static int __devexit pc87360_remove(struct platform_device *pdev);
 
 static int pc87360_read_value(struct pc87360_data *data, u8 ldi, u8 bank,
 			      u8 reg);

drivers/hwmon/sis5595.c +1 -1

index 83321b2..92956eb 100644
@@ -187,7 +187,7 @@ struct sis5595_data {
 static struct pci_dev *s_bridge;	/* pointer to the (only) sis5595 */
 
 static int sis5595_probe(struct platform_device *pdev);
-static int sis5595_remove(struct platform_device *pdev);
+static int __devexit sis5595_remove(struct platform_device *pdev);
 
 static int sis5595_read_value(struct sis5595_data *data, u8 reg);
 static void sis5595_write_value(struct sis5595_data *data, u8 reg, u8 value);

drivers/hwmon/smsc47m1.c +1 -1

index 1de2f2b..338ee4f 100644
@@ -134,7 +134,7 @@ struct smsc47m1_sio_data {
 
 
 static int smsc47m1_probe(struct platform_device *pdev);
-static int smsc47m1_remove(struct platform_device *pdev);
+static int __devexit smsc47m1_remove(struct platform_device *pdev);
 static struct smsc47m1_data *smsc47m1_update_device(struct device *dev,
 		int init);

drivers/hwmon/via686a.c +1 -1

index 24a6851..696c8a2 100644
@@ -314,7 +314,7 @@ struct via686a_data {
 static struct pci_dev *s_bridge;	/* pointer to the (only) via686a */
 
 static int via686a_probe(struct platform_device *pdev);
-static int via686a_remove(struct platform_device *pdev);
+static int __devexit via686a_remove(struct platform_device *pdev);
 
 static inline int via686a_read_value(struct via686a_data *data, u8 reg)
 {

drivers/hwmon/vt8231.c +2 -2

index c604972..3e63eaf 100644
@@ -167,7 +167,7 @@ struct vt8231_data {
 
 static struct pci_dev *s_bridge;
 static int vt8231_probe(struct platform_device *pdev);
-static int vt8231_remove(struct platform_device *pdev);
+static int __devexit vt8231_remove(struct platform_device *pdev);
 static struct vt8231_data *vt8231_update_device(struct device *dev);
 static void vt8231_init_device(struct vt8231_data *data);

@@ -751,7 +751,7 @@ exit_release:
 	return err;
 }
 
-static int vt8231_remove(struct platform_device *pdev)
+static int __devexit vt8231_remove(struct platform_device *pdev)
 {
 	struct vt8231_data *data = platform_get_drvdata(pdev);
 	int i;

drivers/hwmon/w83627hf.c +1 -1

index 1ce7817..7a4a15f 100644
@@ -387,7 +387,7 @@ struct w83627hf_sio_data {
 
 
 static int w83627hf_probe(struct platform_device *pdev);
-static int w83627hf_remove(struct platform_device *pdev);
+static int __devexit w83627hf_remove(struct platform_device *pdev);
 
 static int w83627hf_read_value(struct w83627hf_data *data, u16 reg);
 static int w83627hf_write_value(struct w83627hf_data *data, u16 reg, u16 value);

Signature · 7 lines

1.5.2.2


_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors