Resend patch to add SBC8641D

PATCH New Joe Hamman 2 participants 5 messages Jul 31, 2007 – Aug 6, 2007 Kbuild

lore

Share & tools

lore

Joe Hamman

author

2007-07-31 16:53 UTC #0 lore raw

PATCH 2/2 Resend patch to add SBC8641D

Add support for Wind River's SBC8641D reference board.

Resend to make MAC addresses private - thanks Ben.

Signed-off by: Joe Hamman <[email protected]>

doc/README.sbc8641d +27 -0

diff -uprN -X dontdiff u-boot/doc/README.sbc8641d u-boot-esi/doc/README.sbc8641d
@@ -0,0 +1,27 @@
+Wind River SBC8641D reference board
+===========================
+
+Created 06/14/2007 Joe Hamman
+Copyright 2007, Embedded Specialties, Inc.
+-----------------------------
+
+1. Building U-Boot
+------------------
+The SBC8641D code is known to build using ELDK 4.1.
+
+    $ make sbc8641d_config
+    Configuring for sbc8641d board...
+
+    $ make
+
+
+2. Switch and Jumper Settings
+-----------------------------
+All Jumpers & Switches are in their default positions.  Please refer to
+the board documentation for details.  Some settings control CPU voltages
+and settings may change with board revisions.
+
+3. Known limitations
+--------------------
+PCI:
+	The PCI command may hang if no boards are present in either slot.

drivers/tsec.h +1 -1

diff -uprN -X dontdiff u-boot/drivers/tsec.h u-boot-esi/drivers/tsec.h
@@ -70,7 +70,7 @@
 #define miim_end -2
 #define miim_read -1
 
-#define TBIPA_VALUE		0x1f
+#define TBIPA_VALUE		0x1e
 #define MIIMCFG_INIT_VALUE	0x00000003
 #define MIIMCFG_RESET		0x80000000

include/configs/sbc8641d.h +597 -0

597 lines not on this page · raw message

MAINTAINERS +4 -0

diff -uprN -X dontdiff u-boot/MAINTAINERS u-boot-esi/MAINTAINERS
@@ -179,6 +179,10 @@ Howard Gray <[email protected]>
 
 	MVS1			MPC823
 
+Joe Hamman <[email protected]>
+
+	sbc8641d		MPC8641D
+
 Klaus Heydeck <[email protected]>
 
 	KUP4K			MPC855

Makefile +2 -0

diff -uprN -X dontdiff u-boot/Makefile u-boot-esi/Makefile
@@ -1856,6 +1856,8 @@ TQM8560_config:		unconfig
 MPC8641HPCN_config:    unconfig
 	@./mkconfig $(@:_config=) ppc mpc86xx mpc8641hpcn
 
+sbc8641d_config:	unconfig
+	@./mkconfig $(@:_config=) ppc mpc86xx sbc8641d
 
 #########################################################################
 ## 74xx/7xx Systems

Jon Loeliger

2007-08-03 16:12 UTC #1 lore raw

PATCH 2/2 Resend patch to add SBC8641D

Quoted 5 lines · Joe Hamman

Add support for Wind River's SBC8641D reference board.
Resend to make MAC addresses private - thanks Ben.
Signed-off by: Joe Hamman <[email protected]>

Joe,

Can I get you to this patch for me? I'd like to
see two changes to it, one for TSEC and one for
command line configuration.

include/configs/sbc8641d.h line 26

Quoted 7 lines

diff -uprN -X dontdiff u-boot/include/configs/sbc8641d.h u-boot-esi/include/configs/sbc8641d.h
include/configs/sbc8641d.h +2 -0
@@ -0,0 +1,597 @@
 
+/*
+ * MPC8641HPCN board configuration file

Interesting... :-)

include/configs/sbc8641d.h line 267

Quoted 11 lines

include/configs/sbc8641d.h +11 -0

+/*
+ * Pass open firmware flat tree to kernel
+ */
+#define CONFIG_OF_FLAT_TREE	1
+#define CONFIG_OF_BOARD_SETUP	1
+
+/* maximum size of the flat tree (8K) */
+#define OF_FLAT_TREE_MAX_SIZE	8192
+
+#define OF_CPU		"PowerPC,8641 at 0"
+#define OF_SOC		"soc8641 at f8000000"

This needs to be "soc at f8000000" instead. Ie, drop the part number. Corresponding changes will be needed in your kernel setup() function likely too.

include/configs/sbc8641d.h line 269

Quoted 2 lines

include/configs/sbc8641d.h +2 -0

+#define OF_TBCLK	(bd->bi_busfreq / 4)
+#define OF_STDOUT_PATH	"/soc8641 at f8000000/serial at 4500"

Uh, same stuff here.

Quoted 20 lines

include/configs/sbc8641d.h +20 -0

+
+#if defined(CONFIG_TSEC_ENET)
+
+#ifndef CONFIG_NET_MULTI
+#define CONFIG_NET_MULTI 	1
+#endif
+
+/* #define CONFIG_MII		1 */	/* MII PHY management */
+
+#define CONFIG_MPC86XX_TSEC1    1
+#define CONFIG_MPC86XX_TSEC1_NAME       "eTSEC1"
+#define CONFIG_MPC86XX_TSEC2    1
+#define CONFIG_MPC86XX_TSEC2_NAME       "eTSEC2"
+#define CONFIG_MPC86XX_TSEC3    1
+#define CONFIG_MPC86XX_TSEC3_NAME       "eTSEC3"
+#define CONFIG_MPC86XX_TSEC4    1
+#define CONFIG_MPC86XX_TSEC4_NAME       "eTSEC4"
+
+#define TSEC1_PHY_ADDR		0x1F
+#define TSEC2_PHY_ADDR		0x00

include/configs/sbc8641d.h line 376

Quoted 10 lines

include/configs/sbc8641d.h +10 -0

+#define TSEC3_PHY_ADDR		0x01
+#define TSEC4_PHY_ADDR		0x02
+#define TSEC1_PHYIDX		0
+#define TSEC2_PHYIDX		0
+#define TSEC3_PHYIDX		0
+#define TSEC4_PHYIDX		0
+
+#define CONFIG_ETHPRIME		"eTSEC1"
+
+#endif	/* CONFIG_TSEC_ENET */

So, all of these TSEC parameters have dropped the device specific part from their names. Specifically, we need CONFIG_TSEC1, not CONFIG_MPC86XX_TSEC1 now.

include/configs/sbc8641d.h line 477

Quoted 13 lines

include/configs/sbc8641d.h +13 -0

+
+#if defined(CONFIG_PCI)
+  #define  CONFIG_COMMANDS	(CONFIG_CMD_DFL		\
+				| CFG_CMD_PCI		\
+				| CFG_CMD_PING		\
+				| CFG_CMD_I2C)
+#else
+  #define  CONFIG_COMMANDS	(CONFIG_CMD_DFL		\
+				| CFG_CMD_PING		\
+				| CFG_CMD_I2C)
+#endif
+
+#include <cmd_confdefs.h>

Please recode this with the new Command Line Configuration style as found in the u-boot-testing tree.

We'll try to get those in for the merge window here. Having those two re-code efforts in hand will facilitate that greatly.

Thanks,
jdl

Jon Loeliger

2007-08-03 16:49 UTC #2 lore raw

PATCH 2/2 Resend patch to add SBC8641D

Quoted 10 lines · Jon Loeliger

Quoted 5 lines · Joe Hamman
Add support for Wind River's SBC8641D reference board.
Resend to make MAC addresses private - thanks Ben.
Signed-off by: Joe Hamman <[email protected]>
Joe,
Can I get you to this patch for me?

Hmmm.... This sentence no verb... :-)

So, insert "respin" in there as needed!

Thanks,
jdl

Joe Hamman

author

2007-08-04 01:47 UTC #3 lore raw

PATCH 2/2 Resend patch to add SBC8641D

Hi Jon,

The TSEC name change burned me today when I tried loading Linux. Then I realized I couldn't TFTP a new u-boot image. Had to dig out the JTAG...

I'll get the patch respun this weekend.

Thanks,
Joe

Quoted 26 lines

-----Original Message-----
From: Jon Loeliger [mailto:jdl at freescale.com]
Sent: Friday, August 03, 2007 11:49 AM
To: joe.hamman at embeddedspecialties.com
Cc: u-boot-users
Subject: Re: [U-Boot-Users] [PATCH 2/2] Resend patch to add SBC8641D
Quoted 10 lines · Jon Loeliger
Quoted 5 lines · Joe Hamman
Add support for Wind River's SBC8641D reference board.
Resend to make MAC addresses private - thanks Ben.
Signed-off by: Joe Hamman <[email protected]>
Joe,
Can I get you to this patch for me?
Hmmm.... This sentence no verb... :-)
So, insert "respin" in there as needed!
Thanks,
jdl

Jon Loeliger

2007-08-06 16:36 UTC #4 lore raw

PATCH 2/2 Resend patch to add SBC8641D

Quoted 9 lines · Joe Hamman

Hi Jon,
The TSEC name change burned me today when I tried loading Linux. Then I realized I couldn't TFTP a new u-boot image. Had to dig out the JTAG...
I'll get the patch respun this weekend.
Thanks,
Joe

D'oh. Nothing in an "alternate flash bank"? :-)

Sorry,
jdl