Skip to contentSkip to conversation

Updated patch to add SBC8641D

PATCH New Joe Hamman 3 participants 4 messages Aug 6, 2007 Kbuild

lore
Share & tools
lore

Joe Hamman

author
#0 lore raw

PATCH 2/2 Updated patch to add SBC8641D

Add support for Wind River's SBC8641D reference board.

Resend to add fixes per JDL.

Signed-off by: Joe Hamman <[email protected]>

doc/README.sbc8641d +28 -0
diff -uprN -X dontdiff u-boot/doc/README.sbc8641d u-boot-esi/doc/README.sbc8641d
@@ -0,0 +1,28 @@
+Wind River SBC8641D reference board
+===========================
+
+Created 06/14/2007 Joe Hamman
+Copyright 2007, Embedded Specialties, Inc.
+Copyright 2007 Wind River Systemes, Inc.
+-----------------------------
+
+1. Building U-Boot
+------------------
+The SBC8641D code is known to build using ELDK 4.1.
+
+    $ make sbc8641d_config
+    Configuring for sbc8641d board...
+
+    $ make
+
+
+2. Switch and Jumper Settings
+-----------------------------
+All Jumpers & Switches are in their default positions.  Please refer to
+the board documentation for details.  Some settings control CPU voltages
+and settings may change with board revisions.
+
+3. Known limitations
+--------------------
+PCI:
+	The PCI command may hang if no boards are present in either slot.
drivers/tsec.h +1 -1
diff -uprN -X dontdiff u-boot/drivers/tsec.h u-boot-esi/drivers/tsec.h
@@ -70,7 +70,7 @@
 #define miim_end -2
 #define miim_read -1
 
-#define TBIPA_VALUE		0x1f
+#define TBIPA_VALUE		0x1e
 #define MIIMCFG_INIT_VALUE	0x00000003
 #define MIIMCFG_RESET		0x80000000
include/configs/sbc8641d.h +595 -0

595 lines not on this page · raw message

MAINTAINERS +4 -0
diff -uprN -X dontdiff u-boot/MAINTAINERS u-boot-esi/MAINTAINERS
@@ -179,6 +179,10 @@ Howard Gray <[email protected]>
 
 	MVS1			MPC823
 
+Joe Hamman <[email protected]>
+
+	sbc8641d		MPC8641D
+
 Klaus Heydeck <[email protected]>
 
 	KUP4K			MPC855
Makefile +2 -0
diff -uprN -X dontdiff u-boot/Makefile u-boot-esi/Makefile
@@ -1856,6 +1856,8 @@ TQM8560_config:		unconfig
 MPC8641HPCN_config:    unconfig
 	@./mkconfig $(@:_config=) ppc mpc86xx mpc8641hpcn
 
+sbc8641d_config:	unconfig
+	@./mkconfig $(@:_config=) ppc mpc86xx sbc8641d
 
 #########################################################################
 ## 74xx/7xx Systems
#1 lore raw

PATCH 2/2 Updated patch to add SBC8641D

Quoted 5 lines · In message <1186410458.22362.8.camel@server> you wrote:

Add support for Wind River's SBC8641D reference board.

Resend to add fixes per JDL.

Signed-off by: Joe Hamman <[email protected]>

Please explain why you are changing drivers/tsec.h in this patch?

Are you fixing a bug? If yes, then this should be submitted as a separate patch and not be hidden within bug board support patches.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There are three principal ways to lose money: wine, women,  and  en-
gineers.  While  the first two are more pleasant, the third is by far
the more certain."                      -- Baron Rothschild, ca. 1800
#2 lore raw

PATCH 2/2 Updated patch to add SBC8641D

Quoted 11 lines · Wolfgang Denk
Quoted 5 lines · In message <1186410458.22362.8.camel@server> you wrote:

Add support for Wind River's SBC8641D reference board.

Resend to add fixes per JDL.

Signed-off by: Joe Hamman <[email protected]>

Please explain why you are changing drivers/tsec.h in this patch?

Are you fixing a bug? If yes, then this should be submitted as a separate patch and not be hidden within bug board support patches.

Hmmm... This isn't really a bug fix. It is really more of a board-specific adjustment for PHY association with the controllers on your board, right?

So, it seems like this should be made board dependent somehow.

Or, it seems like we might have Andy talk to us about the future of Ed's TSEC patches for multiple PHY and TBI support. This _might_ be subsumed by that effort, but I'm not sure.

jdl

#3 lore raw

PATCH 2/2 Updated patch to add SBC8641D

In reply to Joe Hamman

include/configs/sbc8641d.h line 475

Quoted 11 lines · Joe Hamman
include/configs/sbc8641d.h +11 -0
+
+#if defined(CONFIG_PCI)
+    #define CONFIG_CMD_PCI
+    #define CONFIG_CMD_PING
+    #define CONFIG_CMD_I2C
+#else
+    #define CONFIG_CMD_PING
+    #define CONFIG_CMD_I2C
+#endif
+
+#include <cmd_confdefs.h>

I think the above really needs to look more like this:

/*
* BOOTP options
*/
#define CONFIG_BOOTP_BOOTFILESIZE
#define CONFIG_BOOTP_BOOTPATH
#define CONFIG_BOOTP_GATEWAY
#define CONFIG_BOOTP_HOSTNAME

/*
* Command line configuration.
*/
#include <config_cmd_default.h>

#define CONFIG_CMD_PING
#define CONFIG_CMD_I2C

#if defined(CFG_RAMBOOT)
#undef CONFIG_CMD_ENV
#endif

#if defined(CONFIG_PCI)
    #define CONFIG_CMD_PCI
    #define CONFIG_CMD_SCSI
    #define CONFIG_CMD_EXT2

#endif