- FInd the maintainer(s) for a patch - MAINTAINERS
PATCH 1/1 - FInd the maintainer(s) for a patch - MAINTAINERS
It helps when you do the diff the right way.
Describe the new F: pattern
MAINTAINERS +7 -0
@@ -83,6 +83,13 @@ S: Status, one of the following: it has been replaced by a better system and you should be using that. +F: Files and directories with wildcard patterns. + A trailing slash includes all files and subdirectory files. + F: drivers/net/ all files in and below drivers/net + F: drivers/net/* all files in drivers/net, but not below + F: */net/* all files in "any top level directory"/net + One pattern per line. Multiple F: lines acceptable. + 3C359 NETWORK DRIVER P: Mike Phillips M: [email protected]
MAINTAINERS S: Status, one of the following: · line 89
Quoted 3 lines · Joe Perches
MAINTAINERS +3
-0+ A trailing slash includes all files and subdirectory files. + F: drivers/net/ all files in and below drivers/net + F: drivers/net/* all files in drivers/net, but not below
Since somebody is going to screw up and do it - what are the semantics of 'drivers/net' and forgetting the trailing slash? Does your tool break on that, and if so, is it silent or noisy (if it's silent, it won't get fixed).
MAINTAINERS S: Status, one of the following: · line 90
Quoted 1 line
MAINTAINERS +1
-0+ F: */net/* all files in "any top level directory"/net
Does the leading '*' match exactly one level, or will it match foo/bar/net/* as well?
Is a construction like 'net/*/netfilter/*' legal?
Quoted 8 lines · On Mon, 2007-08-13 at 12:36 -0400, [email protected] wrote:
Quoted 3 lines · Joe Perches
+ A trailing slash includes all files and subdirectory files.
+ F:drivers/net/all files in and belowdrivers/net
+ F:drivers/net/*all files indrivers/net, but not belowSince somebody is going to screw up and do it - what are the semantics of '
drivers/net' and forgetting the trailing slash?
Looks for a specific file in the patch called drivers/net
Quoted 1 line
is it silent or noisy (if it's silent, it won't get fixed)
silent
Quoted 2 lines
+ F: */net/* all files in "any top level directory"/net Does the leading '*' match exactly one level
Yes
Quoted 1 line
or will it match foo/bar/net/* as
No match, the script counts slashes
+sub file_match_pattern {
+ my ($file, $pattern) = @_;
+ if (substr($pattern, -1) eq "/") {
+ if ($file =~ m@^$pattern@) {
+ return 1;
+ }
+ } else {
+ if ($file =~ m@^$pattern@) {
+ my $s1 = ($file =~ tr@/@@);
+ my $s2 = ($pattern =~ tr@/@@);
+ if ($s1 == $s2) {+ return 1;
+ }
+ }
+ }
+ return 0;
+}
Enhancements appreciated.
Quoted 1 line
Is a construction like '
net/*/netfilter/*' legal?
Yes
cheers, Joe
Quoted 16 lines · Joe Perches
It helps when you do the diff the right way.
Describe the new F: pattern
Signed-off-by Joe Perches <[email protected]>MAINTAINERS +0
-0@@ -83,6 +83,13 @@ S: Status, one of the following: it has been replaced by a better system and you should be using that.
MAINTAINERS S: Status, one of the following: · line 95
Quoted 10 lines
MAINTAINERS +7
-0+F: Files and directories with wildcard patterns. + A trailing slash includes all files and subdirectory files. + F: drivers/net/ all files in and below drivers/net + F: drivers/net/* all files in drivers/net, but not below + F: */net/* all files in "any top level directory"/net + One pattern per line. Multiple F: lines acceptable. + 3C359 NETWORK DRIVER P: Mike Phillips M: [email protected]
Just to be clear, which one is picked with a patch for drivers/net/foo? Both or the most common one?
SUBSYSTEM1
P: Person 1
F: */net/
SUBSYSTEM2
P: Person 2
F: drivers/net/
Richard "the Perl-illiterate" Knutsson
Quoted 10 lines · Richard Knutsson
Just to be clear, which one is picked with a patch for
drivers/net/foo? Both or the most common one?SUBSYSTEM1
P: Person 1
F: */net/SUBSYSTEM2
P: Person 2
F:drivers/net/
Both. Find a match, add, look for more.
I'm a perl "groper in the dark" myself.