Skip to contentSkip to conversation

ARM: shmobile: Minor header cleanup

PATCH New Magnus Damm 4 participants 7 messages Jan 20, 2015 – Jan 21, 2015

Subsystems (4)
lore
Share & tools
lore

Magnus Damm

author maintainer
#0 lore raw

cover ARM: shmobile: Minor header cleanup

ARM: shmobile: Minor header cleanup

[PATCH 01/03] ARM: shmobile: Remove mach/system.h [PATCH 02/03] ARM: shmobile: Remove mach/clkdev.h [PATCH 03/03] ARM: shmobile: Remove mach/uncompress.h

Rework the mach-shmobile code a bit more to allow removing the files system.h, clkdev.h and uncompress.h from arch/arm/mach-shmobile/include/mach/

---

Built on top of renesas-devel-20150119-v3.19-rc5

 arch/arm/Kconfig                                 |    1 -
 arch/arm/Kconfig.debug                           |    3 ++-
 arch/arm/mach-shmobile/clock.c                   |   11 -----------
 arch/arm/mach-shmobile/include/mach/clkdev.h     |    7 -------
 arch/arm/mach-shmobile/include/mach/system.h     |   11 -----------
 arch/arm/mach-shmobile/include/mach/uncompress.h |   19 -------------------
 6 files changed, 2 insertions(+), 50 deletions(-)
author maintainer
#1 lore raw

PATCH 1/3 ARM: shmobile: Remove mach/system.h

From: Magnus Damm <[email protected]>

The file <mach/system.h> is no longer included from anywhere so clean up the code by removing mach-shmobile/include/mach/system.h

---

Applies to renesas-devel-20150119-v3.19-rc5

 arch/arm/mach-shmobile/include/mach/system.h |   11 -----------
 1 file changed, 11 deletions(-)
arch/arm/mach-shmobile/include/mach/system.h deleted +0 -11
@@ -1,11 +0,0 @@
-#ifndef __ASM_ARCH_SYSTEM_H
-#define __ASM_ARCH_SYSTEM_H
-
-#include <asm/system_misc.h>
-
-static inline void arch_reset(char mode, const char *cmd)
-{
-	soft_restart(0);
-}
-
-#endif
author maintainer
#2 lore raw

PATCH 2/3 ARM: shmobile: Remove mach/clkdev.h

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Move over ARCH_SHMOBILE_LEGACY to use the default legacy ARM implementations of __clk_get() and __clk_put() in <asm/clkdev.h> by deselecting HAVE_MACH_CLKDEV. This has the nice side effect that <mach/clkdev.h> is no longer used and can be removed.

---

 arch/arm/Kconfig                             |    1 -
 arch/arm/mach-shmobile/clock.c               |   11 -----------
 arch/arm/mach-shmobile/include/mach/clkdev.h |    7 -------
 3 files changed, 19 deletions(-)
arch/arm/Kconfig +0 -1
@@ -644,7 +644,6 @@ config ARCH_SHMOBILE_LEGACY
 	select GENERIC_CLOCKEVENTS
 	select HAVE_ARM_SCU if SMP
 	select HAVE_ARM_TWD if SMP
-	select HAVE_MACH_CLKDEV
 	select HAVE_SMP
 	select MIGHT_HAVE_CACHE_L2X0
 	select MULTI_IRQ_HANDLER
arch/arm/mach-shmobile/clock.c +0 -11
@@ -45,14 +45,3 @@ int __init shmobile_clk_init(void)
 
 	return 0;
 }
-
-int __clk_get(struct clk *clk)
-{
-	return 1;
-}
-EXPORT_SYMBOL(__clk_get);
-
-void __clk_put(struct clk *clk)
-{
-}
-EXPORT_SYMBOL(__clk_put);
arch/arm/mach-shmobile/include/mach/clkdev.h deleted +0 -7
@@ -1,7 +0,0 @@
-#ifndef __ASM_MACH_CLKDEV_H
-#define __ASM_MACH_CLKDEV_H
-
-int __clk_get(struct clk *clk);
-void __clk_put(struct clk *clk);
-
-#endif /* __ASM_MACH_CLKDEV_H */
author maintainer
#3 lore raw

PATCH 3/3 ARM: shmobile: Remove mach/uncompress.h

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Convert ARCH_SHMOBILE_LEGACY to make use of <debug/uncompress.h> and remove the now unused <mach/uncompress.h>.

---

 arch/arm/Kconfig.debug                           |    3 ++-
 arch/arm/mach-shmobile/include/mach/uncompress.h |   19 -------------------
 2 files changed, 2 insertions(+), 20 deletions(-)
arch/arm/Kconfig.debug +2 -1
@@ -1441,7 +1441,8 @@ config DEBUG_UNCOMPRESS
 config UNCOMPRESS_INCLUDE
 	string
 	default "debug/uncompress.h" if ARCH_MULTIPLATFORM || ARCH_MSM || \
-					PLAT_SAMSUNG || ARCH_EFM32
+					PLAT_SAMSUNG || ARCH_EFM32 || \
+					ARCH_SHMOBILE_LEGACY
 	default "mach/uncompress.h"
 
 config EARLY_PRINTK
arch/arm/mach-shmobile/include/mach/uncompress.h deleted +0 -19
@@ -1,19 +0,0 @@
-#ifndef __ASM_MACH_UNCOMPRESS_H
-#define __ASM_MACH_UNCOMPRESS_H
-
-/*
- * This does not append a newline
- */
-static void putc(int c)
-{
-}
-
-static inline void flush(void)
-{
-}
-
-static void arch_decomp_setup(void)
-{
-}
-
-#endif /* __ASM_MACH_UNCOMPRESS_H */
#4 lore raw

cover ARM: shmobile: Minor header cleanup

In reply to Magnus Damm

Hi Magnus,

Thank you for the patches.

Quoted 9 lines · On Tuesday 20 January 2015 20:57:50 Magnus Damm wrote:

ARM: shmobile: Minor header cleanup

[PATCH 01/03] ARM: shmobile: Remove mach/system.h [PATCH 02/03] ARM: shmobile: Remove mach/clkdev.h [PATCH 03/03] ARM: shmobile: Remove mach/uncompress.h

Rework the mach-shmobile code a bit more to allow removing the files system.h, clkdev.h and uncompress.h from arch/arm/mach-shmobile/include/mach/

Nice, mach-shmobile is getting slimmer, I like that :-)

Quoted 1 line

For the whole series,

Quoted 11 lines

---

Built on top of renesas-devel-20150119-v3.19-rc5

 arch/arm/Kconfig                                 |    1 -
 arch/arm/Kconfig.debug                           |    3 ++-
 arch/arm/mach-shmobile/clock.c                   |   11 -----------
 arch/arm/mach-shmobile/include/mach/clkdev.h     |    7 -------
 arch/arm/mach-shmobile/include/mach/system.h     |   11 -----------
 arch/arm/mach-shmobile/include/mach/uncompress.h |   19 -------------------
6 files changed, 2 insertions(+), 50 deletions(-)
Signature · 3 lines
Regards,

Laurent Pinchart
#5 lore raw

cover ARM: shmobile: Minor header cleanup

In reply to Magnus Damm

Hi Magnus,

Quoted 9 lines · Magnus Damm

ARM: shmobile: Minor header cleanup

[PATCH 01/03] ARM: shmobile: Remove mach/system.h [PATCH 02/03] ARM: shmobile: Remove mach/clkdev.h [PATCH 03/03] ARM: shmobile: Remove mach/uncompress.h

Rework the mach-shmobile code a bit more to allow removing the files system.h, clkdev.h and uncompress.h from arch/arm/mach-shmobile/include/mach/

Thanks!

Quoted 1 line

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#6 lore raw

cover ARM: shmobile: Minor header cleanup

In reply to Magnus Damm
Quoted 11 lines · Magnus Damm

ARM: shmobile: Minor header cleanup

[PATCH 01/03] ARM: shmobile: Remove mach/system.h [PATCH 02/03] ARM: shmobile: Remove mach/clkdev.h [PATCH 03/03] ARM: shmobile: Remove mach/uncompress.h

Rework the mach-shmobile code a bit more to allow removing the files system.h, clkdev.h and uncompress.h from arch/arm/mach-shmobile/include/mach/

Thanks, I have queued this up for v3.21 with Laurent and Geert's Acks.

Quoted 12 lines

---

Built on top of renesas-devel-20150119-v3.19-rc5

 arch/arm/Kconfig                                 |    1 -
 arch/arm/Kconfig.debug                           |    3 ++-
 arch/arm/mach-shmobile/clock.c                   |   11 -----------
 arch/arm/mach-shmobile/include/mach/clkdev.h     |    7 -------
 arch/arm/mach-shmobile/include/mach/system.h     |   11 -----------
 arch/arm/mach-shmobile/include/mach/uncompress.h |   19 -------------------
 6 files changed, 2 insertions(+), 50 deletions(-)