Skip to contentSkip to conversation

musb_hdrc: Unify naming and rename common files

PATCH In review Tony Lindgren 1 participant 11 messages Aug 20, 2007 – Aug 21, 2007

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover musb_hdrc: Unify naming and rename common files

Hi all,

Attached patch series replaces Inventra naming with musb, and renames the core musb files to start with musb_.

Renaming the files unifies the file names, and groups them by type. This all should make it easier for people to locate the right piece of code within the driver.

After applying the patch series, the musb directory has following files:

$ ls
cppi_dma.c   musb_core.c        musb_host.c          omap2430.h
cppi_dma.h   musb_core.h        musb_host.h          tusb6010.c
davinci.c    musb_debug.h       musb_host_virthub.c  tusb6010.h
davinci.h    musb_dma.h         musbhsdma.c          tusb6010_omap.c
Kconfig      musb_gadget.c      musb_procfs.c
Makefile     musb_gadget_ep0.c  musb_regs.h
musb_arch.h  musb_gadget.h      omap2430.c

Tested on tusb.

Regards,

Tony

#1 lore raw

PATCH 1/9 musb_hdrc: Search and replace USB_INVENTRA_FIFO with USB_MUSB_DISABLE_DMA

Search and replace USB_INVENTRA_FIFO with USB_MUSB_DISABLE_DMA

---
 drivers/usb/musb/Kconfig       |    8 ++++----
 drivers/usb/musb/Makefile      |    2 +-
 drivers/usb/musb/dma.h         |    2 +-
 drivers/usb/musb/musb_gadget.c |    2 +-
 drivers/usb/musb/musb_procfs.c |    2 +-
 drivers/usb/musb/plat_uds.c    |   12 ++++++------
 6 files changed, 14 insertions(+), 14 deletions(-)
drivers/usb/musb/Kconfig +4 -4
index a9bcd7e..8e5430a 100644
@@ -129,7 +129,7 @@ config USB_MUSB_HDRC_HCD
 	default y
 
 
-config USB_INVENTRA_FIFO
+config USB_MUSB_DISABLE_DMA
 	bool 'Disable DMA (always use PIO)'
 	depends on USB_MUSB_HDRC
 	default y if USB_TUSB6010
@@ -144,21 +144,21 @@ config USB_INVENTRA_FIFO
 
 config USB_INVENTRA_DMA
 	bool
-	depends on USB_MUSB_HDRC && !USB_INVENTRA_FIFO
+	depends on USB_MUSB_HDRC && !USB_MUSB_DISABLE_DMA
 	default ARCH_OMAP2430 || ARCH_OMAP343X
 	help
 	  Enable DMA transfers using Mentor's engine.
 
 config USB_TI_CPPI_DMA
 	bool
-	depends on USB_MUSB_HDRC && !USB_INVENTRA_FIFO
+	depends on USB_MUSB_HDRC && !USB_MUSB_DISABLE_DMA
 	default ARCH_DAVINCI
 	help
 	  Enable DMA transfers when TI CPPI DMA is available.
 
 config USB_TUSB_OMAP_DMA
 	bool
-	depends on USB_MUSB_HDRC && !USB_INVENTRA_FIFO
+	depends on USB_MUSB_HDRC && !USB_MUSB_DISABLE_DMA
 	depends on USB_TUSB6010
 	depends on ARCH_OMAP
 	default y
drivers/usb/musb/Makefile +1 -1
index 535ba40..fbff415 100644
@@ -31,7 +31,7 @@ endif
 # PIO (INVENTRA_FIFO), or DMA (several potential schemes).
 # though PIO is always there to back up DMA, and for ep0
 
-ifneq ($(CONFIG_USB_INVENTRA_FIFO),y)
+ifneq ($(CONFIG_USB_MUSB_DISABLE_DMA),y)
 
   ifeq ($(CONFIG_USB_INVENTRA_DMA),y)
     musb_hdrc-objs		+= musbhsdma.o
drivers/usb/musb/dma.h +1 -1
index 701d312..deef0c2 100644
@@ -62,7 +62,7 @@ struct musb_hw_ep;
 
 #define	DMA_ADDR_INVALID	(~(dma_addr_t)0)
 
-#ifndef CONFIG_USB_INVENTRA_FIFO
+#ifndef CONFIG_USB_MUSB_DISABLE_DMA
 #define	is_dma_capable()	(1)
 #else
 #define	is_dma_capable()	(0)
drivers/usb/musb/musb_gadget.c +1 -1
index 88757ce..5a4227e 100644
@@ -291,7 +291,7 @@ static void txstate(struct musb *musb, struct musb_request *req)
 			epnum, musb_ep->packet_sz, fifo_count,
 			csr);
 
-#ifndef	CONFIG_USB_INVENTRA_FIFO
+#ifndef	CONFIG_USB_MUSB_DISABLE_DMA
 	if (is_dma_capable() && musb_ep->dma) {
 		struct dma_controller	*c = musb->dma_controller;
 
drivers/usb/musb/musb_procfs.c +1 -1
index 1bc5c79..3144f34 100644
@@ -508,7 +508,7 @@ static int dump_header_stats(struct musb *musb, char *buffer)
 
 	code = sprintf(buffer,
 			"Options: "
-#ifdef CONFIG_USB_INVENTRA_FIFO
+#ifdef CONFIG_USB_MUSB_DISABLE_DMA
 			"pio"
 #elif defined(CONFIG_USB_TI_CPPI_DMA)
 			"cppi-dma"
drivers/usb/musb/plat_uds.c +6 -6
index dacf930..e544339 100644
@@ -1536,7 +1536,7 @@ irqreturn_t musb_interrupt(struct musb *musb)
 }
 
 
-#ifndef CONFIG_USB_INVENTRA_FIFO
+#ifndef CONFIG_USB_MUSB_DISABLE_DMA
 static int __initdata use_dma = 1;
 
 /* "modprobe ... use_dma=0" etc */
@@ -1918,7 +1918,7 @@ musb_init_controller(struct device *dev, int nIrq, void __iomem *ctrl)
 		goto fail2;
 	}
 
-#ifndef CONFIG_USB_INVENTRA_FIFO
+#ifndef CONFIG_USB_MUSB_DISABLE_DMA
 	if (use_dma && dev->dma_mask) {
 		struct dma_controller	*c;
 
@@ -2047,7 +2047,7 @@ fail2:
  * bridge to a platform device; this driver then suffices.
  */
 
-#ifndef CONFIG_USB_INVENTRA_FIFO
+#ifndef CONFIG_USB_MUSB_DISABLE_DMA
 static u64	*orig_dma_mask;
 #endif
 
@@ -2068,7 +2068,7 @@ static int __init musb_probe(struct platform_device *pdev)
 		return -ENOMEM;
 	}
 
-#ifndef CONFIG_USB_INVENTRA_FIFO
+#ifndef CONFIG_USB_MUSB_DISABLE_DMA
 	/* clobbered by use_dma=n */
 	orig_dma_mask = dev->dma_mask;
 #endif
@@ -2094,7 +2094,7 @@ static int __devexit musb_remove(struct platform_device *pdev)
 	musb_free(musb);
 	iounmap(ctrl_base);
 	device_init_wakeup(&pdev->dev, 0);
-#ifndef CONFIG_USB_INVENTRA_FIFO
+#ifndef CONFIG_USB_MUSB_DISABLE_DMA
 	pdev->dev.dma_mask = orig_dma_mask;
 #endif
 	return 0;
@@ -2180,7 +2180,7 @@ static int __init musb_init(void)
 #endif
 
 	pr_info("%s: version " MUSB_VERSION ", "
-#ifdef CONFIG_USB_INVENTRA_FIFO
+#ifdef CONFIG_USB_MUSB_DISABLE_DMA
 		"pio"
 #elif defined(CONFIG_USB_TI_CPPI_DMA)
 		"cppi-dma"
Signature · 1 line
1.5.2.3
#2 lore raw

PATCH 2/9 musb_hdrc: Search and replace USB_INVENTRA_HCD_LOGGING with USB_MUSB_LOGLEVEL

Search and replace USB_INVENTRA_HCD_LOGGING with USB_MUSB_LOGLEVEL

---
 drivers/usb/musb/Kconfig  |    2 +-
 drivers/usb/musb/Makefile |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/usb/musb/Kconfig +1 -1
index 8e5430a..ed800a0 100644
@@ -165,7 +165,7 @@ config USB_TUSB_OMAP_DMA
 	help
 	  Enable DMA transfers on TUSB 6010 when OMAP DMA is available.
 
-config	USB_INVENTRA_HCD_LOGGING
+config	USB_MUSB_LOGLEVEL
 	depends on USB_MUSB_HDRC
 	int  'Logging Level (0 - none / 3 - annoying / ... )'
 	default 0
drivers/usb/musb/Makefile +1 -1
index fbff415..93c3f40 100644
@@ -60,7 +60,7 @@ endif
 
 # Debugging
 
-MUSB_DEBUG:=$(CONFIG_USB_INVENTRA_HCD_LOGGING)
+MUSB_DEBUG:=$(CONFIG_USB_MUSB_LOGLEVEL)
 
 ifeq ("$(strip $(MUSB_DEBUG))","")
     ifdef CONFIG_USB_DEBUG
Signature · 1 line
1.5.2.3
#3 lore raw

PATCH 3/9 musb_hdrc: Rename plat_uds.c to musb_core.c, plat_arc.h to musb_arch.h

Rename plat_uds.c to musb_core.c, plat_arc.h to musb_arch.h

---
 drivers/usb/musb/Makefile    |    2 +-
 drivers/usb/musb/musb_arch.h |  115 +++
 drivers/usb/musb/musb_core.c | 2216 ++++++++++++++++++++++++++++++++++++++++++
 drivers/usb/musb/musbdefs.h  |    2 +-
 drivers/usb/musb/plat_arc.h  |  115 ---
 drivers/usb/musb/plat_uds.c  | 2216 ------------------------------------------
 6 files changed, 2333 insertions(+), 2333 deletions(-)
 create mode 100644 drivers/usb/musb/musb_arch.h
 create mode 100644 drivers/usb/musb/musb_core.c
 delete mode 100644 drivers/usb/musb/plat_arc.h
 delete mode 100644 drivers/usb/musb/plat_uds.c
drivers/usb/musb/Makefile +1 -1
index 93c3f40..537faed 100644
@@ -2,7 +2,7 @@
 # for USB OTG silicon based on Mentor Graphics INVENTRA designs
 #
 
-musb_hdrc-objs := plat_uds.o
+musb_hdrc-objs := musb_core.o
 
 obj-$(CONFIG_USB_MUSB_HDRC)	+= musb_hdrc.o
 
drivers/usb/musb/musb_arch.h new file +115 -0

115 lines not on this page · raw message

drivers/usb/musb/musb_core.c new file +2216 -0

2,216 lines not on this page · raw message

drivers/usb/musb/musbdefs.h +1 -1
index ccc8d24..a9af51e 100644
@@ -68,7 +68,7 @@ struct musb_ep;
 #include <asm/arch/hdrc_cnf.h>
 #endif
 
-#include "plat_arc.h"
+#include "musb_arch.h"
 #include "musbhdrc.h"
 
 #include "musb_gadget.h"
drivers/usb/musb/plat_arc.h deleted +0 -115

115 lines not on this page · raw message

drivers/usb/musb/plat_uds.c deleted +0 -2216

538 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
1.5.2.3

Part of the diff is not shown here. View the raw message.

#4 lore raw

PATCH 4/9 musb_hdrc: Rename musbhdrc.h to musb_regs.h

Rename musbhdrc.h to musb_regs.h

---
 drivers/usb/musb/musb_regs.h |  300 ++++++++++++++++++++++++++++++++++++++++++
 drivers/usb/musb/musbdefs.h  |    2 +-
 drivers/usb/musb/musbhdrc.h  |  300 ------------------------------------------
 3 files changed, 301 insertions(+), 301 deletions(-)
 create mode 100644 drivers/usb/musb/musb_regs.h
 delete mode 100644 drivers/usb/musb/musbhdrc.h
drivers/usb/musb/musb_regs.h new file +300 -0
new file mode 100644
index 0000000..d1500a4
@@ -0,0 +1,300 @@
+/*
+ * MUSB OTG driver register defines
+ *
+ * Copyright 2005 Mentor Graphics Corporation
+ * Copyright (C) 2005-2006 by Texas Instruments
+ * Copyright (C) 2006-2007 Nokia Corporation
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA
+ *
+ * THIS SOFTWARE IS PROVIDED "AS IS" AND ANY EXPRESS OR IMPLIED
+ * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.  IN
+ * NO EVENT SHALL THE AUTHORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
+ * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
+ * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+ * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ */
+
+#ifndef __MUSB_REGS_H__
+#define __MUSB_REGS_H__
+
+#define MUSB_EP0_FIFOSIZE	64	/* This is non-configurable */
+
+/*
+ * Common USB registers
+ */
+
+#define MUSB_FADDR		0x00	/* 8-bit */
+#define MUSB_POWER		0x01	/* 8-bit */
+
+#define MUSB_INTRTX		0x02	/* 16-bit */
+#define MUSB_INTRRX		0x04
+#define MUSB_INTRTXE		0x06
+#define MUSB_INTRRXE		0x08
+#define MUSB_INTRUSB		0x0A	/* 8 bit */
+#define MUSB_INTRUSBE		0x0B	/* 8 bit */
+#define MUSB_FRAME		0x0C
+#define MUSB_INDEX		0x0E	/* 8 bit */
+#define MUSB_TESTMODE		0x0F	/* 8 bit */
+
+/* Get offset for a given FIFO from musb->mregs */
+#ifdef	CONFIG_USB_TUSB6010
+#define MUSB_FIFO_OFFSET(epnum)	(0x200 + ((epnum) * 0x20))
+#else
+#define MUSB_FIFO_OFFSET(epnum)	(0x20 + ((epnum) * 4))
+#endif
+
+/*
+ * Additional Control Registers
+ */
+
+#define MUSB_DEVCTL		0x60	/* 8 bit */
+
+/* These are always controlled through the INDEX register */
+#define MUSB_TXFIFOSZ		0x62	/* 8-bit (see masks) */
+#define MUSB_RXFIFOSZ		0x63	/* 8-bit (see masks) */
+#define MUSB_TXFIFOADD		0x64	/* 16-bit offset shifted right 3 */
+#define MUSB_RXFIFOADD		0x66	/* 16-bit offset shifted right 3 */
+
+/* REVISIT: vctrl/vstatus: optional vendor utmi+phy register at 0x68 */
+#define MUSB_HWVERS		0x6C	/* 8 bit */
+
+#define MUSB_EPINFO		0x78	/* 8 bit */
+#define MUSB_RAMINFO		0x79	/* 8 bit */
+#define MUSB_LINKINFO		0x7a	/* 8 bit */
+#define MUSB_VPLEN		0x7b	/* 8 bit */
+#define MUSB_HS_EOF1		0x7c	/* 8 bit */
+#define MUSB_FS_EOF1		0x7d	/* 8 bit */
+#define MUSB_LS_EOF1		0x7e	/* 8 bit */
+
+/* Offsets to endpoint registers */
+#define MUSB_TXMAXP		0x00
+#define MUSB_TXCSR		0x02
+#define MUSB_CSR0		MUSB_TXCSR	/* Re-used for EP0 */
+#define MUSB_RXMAXP		0x04
+#define MUSB_RXCSR		0x06
+#define MUSB_RXCOUNT		0x08
+#define MUSB_COUNT0		MUSB_RXCOUNT	/* Re-used for EP0 */
+#define MUSB_TXTYPE		0x0A
+#define MUSB_TYPE0		MUSB_TXTYPE	/* Re-used for EP0 */
+#define MUSB_TXINTERVAL		0x0B
+#define MUSB_NAKLIMIT0		MUSB_TXINTERVAL	/* Re-used for EP0 */
+#define MUSB_RXTYPE		0x0C
+#define MUSB_RXINTERVAL		0x0D
+#define MUSB_FIFOSIZE		0x0F
+#define MUSB_CONFIGDATA		MUSB_FIFOSIZE	/* Re-used for EP0 */
+
+/* Offsets to endpoint registers in indexed model (using INDEX register) */
+#define MUSB_INDEXED_OFFSET(_epnum, _offset)	\
+	(0x10 + (_offset))
+
+/* Offsets to endpoint registers in flat models */
+#define MUSB_FLAT_OFFSET(_epnum, _offset)	\
+	(0x100 + (0x10*(_epnum)) + (_offset))
+
+#ifdef CONFIG_USB_TUSB6010
+/* TUSB6010 EP0 configuration register is special */
+#define MUSB_TUSB_OFFSET(_epnum, _offset)	\
+	(0x10 + _offset)
+#include "tusb6010.h"		/* Needed "only" for TUSB_EP0_CONF */
+#endif
+
+/* "bus control"/target registers, for host side multipoint (external hubs) */
+#define MUSB_TXFUNCADDR		0x00
+#define MUSB_TXHUBADDR		0x02
+#define MUSB_TXHUBPORT		0x03
+
+#define MUSB_RXFUNCADDR		0x04
+#define MUSB_RXHUBADDR		0x06
+#define MUSB_RXHUBPORT		0x07
+
+#define MUSB_BUSCTL_OFFSET(_epnum, _offset) \
+	(0x80 + (8*(_epnum)) + (_offset))
+
+/*
+ * MUSB Register bits
+ */
+
+/* POWER */
+#define MUSB_POWER_ISOUPDATE	0x80
+#define MUSB_POWER_SOFTCONN	0x40
+#define MUSB_POWER_HSENAB	0x20
+#define MUSB_POWER_HSMODE	0x10
+#define MUSB_POWER_RESET	0x08
+#define MUSB_POWER_RESUME	0x04
+#define MUSB_POWER_SUSPENDM	0x02
+#define MUSB_POWER_ENSUSPEND	0x01
+
+/* INTRUSB */
+#define MUSB_INTR_SUSPEND	0x01
+#define MUSB_INTR_RESUME	0x02
+#define MUSB_INTR_RESET		0x04
+#define MUSB_INTR_BABBLE	0x04
+#define MUSB_INTR_SOF		0x08
+#define MUSB_INTR_CONNECT	0x10
+#define MUSB_INTR_DISCONNECT	0x20
+#define MUSB_INTR_SESSREQ	0x40
+#define MUSB_INTR_VBUSERROR	0x80	/* For SESSION end */
+
+/* DEVCTL */
+#define MUSB_DEVCTL_BDEVICE	0x80
+#define MUSB_DEVCTL_FSDEV	0x40
+#define MUSB_DEVCTL_LSDEV	0x20
+#define MUSB_DEVCTL_VBUS	0x18
+#define MUSB_DEVCTL_VBUS_SHIFT	3
+#define MUSB_DEVCTL_HM		0x04
+#define MUSB_DEVCTL_HR		0x02
+#define MUSB_DEVCTL_SESSION	0x01
+
+/* TESTMODE */
+#define MUSB_TEST_FORCE_HOST	0x80
+#define MUSB_TEST_FIFO_ACCESS	0x40
+#define MUSB_TEST_FORCE_FS	0x20
+#define MUSB_TEST_FORCE_HS	0x10
+#define MUSB_TEST_PACKET	0x08
+#define MUSB_TEST_K		0x04
+#define MUSB_TEST_J		0x02
+#define MUSB_TEST_SE0_NAK	0x01
+
+/* Allocate for double-packet buffering (effectively doubles assigned _SIZE) */
+#define MUSB_FIFOSZ_DPB	0x10
+/* Allocation size (8, 16, 32, ... 4096) */
+#define MUSB_FIFOSZ_SIZE	0x0f
+
+/* CSR0 */
+#define MUSB_CSR0_FLUSHFIFO	0x0100
+#define MUSB_CSR0_TXPKTRDY	0x0002
+#define MUSB_CSR0_RXPKTRDY	0x0001
+
+/* CSR0 in Peripheral mode */
+#define MUSB_CSR0_P_SVDSETUPEND	0x0080
+#define MUSB_CSR0_P_SVDRXPKTRDY	0x0040
+#define MUSB_CSR0_P_SENDSTALL	0x0020
+#define MUSB_CSR0_P_SETUPEND	0x0010
+#define MUSB_CSR0_P_DATAEND	0x0008
+#define MUSB_CSR0_P_SENTSTALL	0x0004
+
+/* CSR0 in Host mode */
+#define MUSB_CSR0_H_DIS_PING		0x0800
+#define MUSB_CSR0_H_WR_DATATOGGLE	0x0400	/* Set to allow setting: */
+#define MUSB_CSR0_H_DATATOGGLE		0x0200	/* Data toggle control */
+#define MUSB_CSR0_H_NAKTIMEOUT		0x0080
+#define MUSB_CSR0_H_STATUSPKT		0x0040
+#define MUSB_CSR0_H_REQPKT		0x0020
+#define MUSB_CSR0_H_ERROR		0x0010
+#define MUSB_CSR0_H_SETUPPKT		0x0008
+#define MUSB_CSR0_H_RXSTALL		0x0004
+
+/* CSR0 bits to avoid zeroing (write zero clears, write 1 ignored) */
+#define MUSB_CSR0_P_WZC_BITS	\
+	( MUSB_CSR0_P_SENTSTALL )
+#define MUSB_CSR0_H_WZC_BITS	\
+	( MUSB_CSR0_H_NAKTIMEOUT | MUSB_CSR0_H_RXSTALL \
+	| MUSB_CSR0_RXPKTRDY )
+
+/* TxType/RxType */
+#define MUSB_TYPE_SPEED		0xc0
+#define MUSB_TYPE_SPEED_SHIFT	6
+#define MUSB_TYPE_PROTO		0x30	/* Implicitly zero for ep0 */
+#define MUSB_TYPE_PROTO_SHIFT	4
+#define MUSB_TYPE_REMOTE_END	0xf	/* Implicitly zero for ep0 */
+
+/* CONFIGDATA */
+#define MUSB_CONFIGDATA_MPRXE		0x80	/* Auto bulk pkt combining */
+#define MUSB_CONFIGDATA_MPTXE		0x40	/* Auto bulk pkt splitting */
+#define MUSB_CONFIGDATA_BIGENDIAN	0x20
+#define MUSB_CONFIGDATA_HBRXE		0x10	/* HB-ISO for RX */
+#define MUSB_CONFIGDATA_HBTXE		0x08	/* HB-ISO for TX */
+#define MUSB_CONFIGDATA_DYNFIFO		0x04	/* Dynamic FIFO sizing */
+#define MUSB_CONFIGDATA_SOFTCONE	0x02	/* SoftConnect */
+#define MUSB_CONFIGDATA_UTMIDW		0x01	/* Data width 0/1 => 8/16bits */
+
+/* TXCSR in Peripheral and Host mode */
+#define MUSB_TXCSR_AUTOSET		0x8000
+#define MUSB_TXCSR_MODE			0x2000
+#define MUSB_TXCSR_DMAENAB		0x1000
+#define MUSB_TXCSR_FRCDATATOG		0x0800
+#define MUSB_TXCSR_DMAMODE		0x0400
+#define MUSB_TXCSR_CLRDATATOG		0x0040
+#define MUSB_TXCSR_FLUSHFIFO		0x0008
+#define MUSB_TXCSR_FIFONOTEMPTY		0x0002
+#define MUSB_TXCSR_TXPKTRDY		0x0001
+
+/* TXCSR in Peripheral mode */
+#define MUSB_TXCSR_P_ISO		0x4000
+#define MUSB_TXCSR_P_INCOMPTX		0x0080
+#define MUSB_TXCSR_P_SENTSTALL		0x0020
+#define MUSB_TXCSR_P_SENDSTALL		0x0010
+#define MUSB_TXCSR_P_UNDERRUN		0x0004
+
+/* TXCSR in Host mode */
+#define MUSB_TXCSR_H_WR_DATATOGGLE	0x0200
+#define MUSB_TXCSR_H_DATATOGGLE		0x0100
+#define MUSB_TXCSR_H_NAKTIMEOUT		0x0080
+#define MUSB_TXCSR_H_RXSTALL		0x0020
+#define MUSB_TXCSR_H_ERROR		0x0004
+
+/* TXCSR bits to avoid zeroing (write zero clears, write 1 ignored) */
+#define MUSB_TXCSR_P_WZC_BITS	\
+	( MUSB_TXCSR_P_INCOMPTX | MUSB_TXCSR_P_SENTSTALL \
+	| MUSB_TXCSR_P_UNDERRUN | MUSB_TXCSR_FIFONOTEMPTY )
+#define MUSB_TXCSR_H_WZC_BITS	\
+	( MUSB_TXCSR_H_NAKTIMEOUT | MUSB_TXCSR_H_RXSTALL \
+	| MUSB_TXCSR_H_ERROR | MUSB_TXCSR_FIFONOTEMPTY )
+
+/* RXCSR in Peripheral and Host mode */
+#define MUSB_RXCSR_AUTOCLEAR		0x8000
+#define MUSB_RXCSR_DMAENAB		0x2000
+#define MUSB_RXCSR_DISNYET		0x1000
+#define MUSB_RXCSR_PID_ERR		0x1000
+#define MUSB_RXCSR_DMAMODE		0x0800
+#define MUSB_RXCSR_INCOMPRX		0x0100
+#define MUSB_RXCSR_CLRDATATOG		0x0080
+#define MUSB_RXCSR_FLUSHFIFO		0x0010
+#define MUSB_RXCSR_DATAERROR		0x0008
+#define MUSB_RXCSR_FIFOFULL		0x0002
+#define MUSB_RXCSR_RXPKTRDY		0x0001
+
+/* RXCSR in Peripheral mode */
+#define MUSB_RXCSR_P_ISO		0x4000
+#define MUSB_RXCSR_P_SENTSTALL		0x0040
+#define MUSB_RXCSR_P_SENDSTALL		0x0020
+#define MUSB_RXCSR_P_OVERRUN		0x0004
+
+/* RXCSR in Host mode */
+#define MUSB_RXCSR_H_AUTOREQ		0x4000
+#define MUSB_RXCSR_H_WR_DATATOGGLE	0x0400
+#define MUSB_RXCSR_H_DATATOGGLE		0x0200
+#define MUSB_RXCSR_H_RXSTALL		0x0040
+#define MUSB_RXCSR_H_REQPKT		0x0020
+#define MUSB_RXCSR_H_ERROR		0x0004
+
+/* RXCSR bits to avoid zeroing (write zero clears, write 1 ignored) */
+#define MUSB_RXCSR_P_WZC_BITS	\
+	( MUSB_RXCSR_P_SENTSTALL | MUSB_RXCSR_P_OVERRUN \
+	| MUSB_RXCSR_RXPKTRDY )
+#define MUSB_RXCSR_H_WZC_BITS	\
+	( MUSB_RXCSR_H_RXSTALL | MUSB_RXCSR_H_ERROR \
+	| MUSB_RXCSR_DATAERROR | MUSB_RXCSR_RXPKTRDY )
+
+/* HUBADDR */
+#define MUSB_HUBADDR_MULTI_TT		0x80
+
+#endif	/* __MUSB_REGS_H__ */
drivers/usb/musb/musbdefs.h +1 -1
index a9af51e..7dbc74a 100644
@@ -69,7 +69,7 @@ struct musb_ep;
 #endif
 
 #include "musb_arch.h"
-#include "musbhdrc.h"
+#include "musb_regs.h"
 
 #include "musb_gadget.h"
 #include "../core/hcd.h"
drivers/usb/musb/musbhdrc.h deleted +0 -300

300 lines not on this page · raw message

Signature · 1 line
1.5.2.3
#5 lore raw

PATCH 5/9 musb_hdrc: Rename musbdefs.h to musb_core.h

Rename musbdefs.h to musb_core.h

---
 drivers/usb/musb/cppi_dma.c      |    2 +-
 drivers/usb/musb/cppi_dma.h      |    2 +-
 drivers/usb/musb/davinci.c       |    2 +-
 drivers/usb/musb/g_ep0.c         |    2 +-
 drivers/usb/musb/musb_core.c     |    2 +-
 drivers/usb/musb/musb_core.h     |  525 ++++++++++++++++++++++++++++++++++++++
 drivers/usb/musb/musb_gadget.c   |    2 +-
 drivers/usb/musb/musb_host.c     |    2 +-
 drivers/usb/musb/musb_procfs.c   |    2 +-
 drivers/usb/musb/musbdefs.h      |  525 --------------------------------------
 drivers/usb/musb/musbhsdma.c     |    2 +-
 drivers/usb/musb/omap2430.c      |    2 +-
 drivers/usb/musb/tusb6010.c      |    2 +-
 drivers/usb/musb/tusb6010_omap.c |    2 +-
 drivers/usb/musb/virthub.c       |    2 +-
 15 files changed, 538 insertions(+), 538 deletions(-)
 create mode 100644 drivers/usb/musb/musb_core.h
 delete mode 100644 drivers/usb/musb/musbdefs.h
drivers/usb/musb/cppi_dma.c +1 -1
index 8ce3fd5..5403a4f 100644
@@ -8,7 +8,7 @@
 
 #include <linux/usb.h>
 
-#include "musbdefs.h"
+#include "musb_core.h"
 #include "cppi_dma.h"
 
 
drivers/usb/musb/cppi_dma.h +1 -1
index da97a99..c121865 100644
@@ -10,7 +10,7 @@
 #include <linux/dmapool.h>
 
 #include "dma.h"
-#include "musbdefs.h"
+#include "musb_core.h"
 #include "davinci.h"
 
 
drivers/usb/musb/davinci.c +1 -1
index 99ac042..85300dd 100644
@@ -36,7 +36,7 @@
 #include <asm/arch/gpio.h>
 #include <asm/mach-types.h>
 
-#include "musbdefs.h"
+#include "musb_core.h"
 
 
 #ifdef CONFIG_MACH_DAVINCI_EVM
drivers/usb/musb/g_ep0.c +1 -1
index e63e983..2395729 100644
@@ -40,7 +40,7 @@
 #include <linux/device.h>
 #include <linux/interrupt.h>
 
-#include "musbdefs.h"
+#include "musb_core.h"
 
 /* ep0 is always musb->endpoints[0].ep_in */
 #define	next_ep0_request(musb)	next_in_request(&(musb)->endpoints[0])
drivers/usb/musb/musb_core.c +1 -1
index e544339..edb03a1 100644
@@ -106,7 +106,7 @@
 #include <asm/mach-types.h>
 #endif
 
-#include "musbdefs.h"
+#include "musb_core.h"
 
 
 #ifdef CONFIG_ARCH_DAVINCI
drivers/usb/musb/musb_core.h new file +525 -0

525 lines not on this page · raw message

drivers/usb/musb/musb_gadget.c +1 -1
index 5a4227e..1789ede 100644
@@ -43,7 +43,7 @@
 #include <linux/stat.h>
 #include <linux/dma-mapping.h>
 
-#include "musbdefs.h"
+#include "musb_core.h"
 
 
 /* MUSB PERIPHERAL status 3-mar:
drivers/usb/musb/musb_host.c +1 -1
index e924853..e7935fb 100644
@@ -41,7 +41,7 @@
 #include <linux/init.h>
 #include <linux/list.h>
 
-#include "musbdefs.h"
+#include "musb_core.h"
 #include "musb_host.h"
 
 
drivers/usb/musb/musb_procfs.c +1 -1
index 3144f34..fa36969 100644
@@ -44,7 +44,7 @@
 #include <asm/uaccess.h>	/* FIXME remove procfs writes */
 #include <asm/arch/hardware.h>
 
-#include "musbdefs.h"
+#include "musb_core.h"
 
 #include "davinci.h"
 
drivers/usb/musb/musbdefs.h deleted +0 -525

525 lines not on this page · raw message

drivers/usb/musb/musbhsdma.c +1 -1
index 515b914..974fd7d 100644
@@ -38,7 +38,7 @@
 #include <linux/device.h>
 #include <linux/interrupt.h>
 #include <linux/platform_device.h>
-#include "musbdefs.h"
+#include "musb_core.h"
 
 #if defined(CONFIG_ARCH_OMAP2430) || defined(CONFIG_ARCH_OMAP3430)
 #include "omap2430.h"
drivers/usb/musb/omap2430.c +1 -1
index 3664ff8..660d202 100644
@@ -33,7 +33,7 @@
 #include <asm/arch/hardware.h>
 #include <asm/arch/mux.h>
 
-#include "musbdefs.h"
+#include "musb_core.h"
 #include "omap2430.h"
 
 #ifdef CONFIG_ARCH_OMAP3430
drivers/usb/musb/tusb6010.c +1 -1
index 4b5a4dc..537788e 100644
@@ -23,7 +23,7 @@
 #include <linux/irq.h>
 #include <linux/platform_device.h>
 
-#include "musbdefs.h"
+#include "musb_core.h"
 
 static void tusb_source_power(struct musb *musb, int is_on);
 
drivers/usb/musb/tusb6010_omap.c +1 -1
index c71e123..c7fbfba 100644
@@ -18,7 +18,7 @@
 #include <asm/arch/dma.h>
 #include <asm/arch/mux.h>
 
-#include "musbdefs.h"
+#include "musb_core.h"
 
 /*
  * REVISIT: With TUSB2.0 only one dmareq line can be used at a time.
drivers/usb/musb/virthub.c +1 -1
index d9f3c28..9422881 100644
@@ -43,7 +43,7 @@
 
 #include <asm/unaligned.h>
 
-#include "musbdefs.h"
+#include "musb_core.h"
 
 
 static void musb_port_suspend(struct musb *musb, u8 bSuspend)
Signature · 1 line
1.5.2.3
#6 lore raw

PATCH 6/9 musb_hdrc: Rename dma.h to musb_dma.h

Rename dma.h to musb_dma.h

---
 drivers/usb/musb/cppi_dma.h  |    2 +-
 drivers/usb/musb/dma.h       |  174 ------------------------------------------
 drivers/usb/musb/musb_core.h |    2 +-
 drivers/usb/musb/musb_dma.h  |  174 ++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 176 insertions(+), 176 deletions(-)
 delete mode 100644 drivers/usb/musb/dma.h
 create mode 100644 drivers/usb/musb/musb_dma.h
drivers/usb/musb/cppi_dma.h +1 -1
index c121865..1d72c1b 100644
@@ -9,7 +9,7 @@
 #include <linux/errno.h>
 #include <linux/dmapool.h>
 
-#include "dma.h"
+#include "musb_dma.h"
 #include "musb_core.h"
 #include "davinci.h"
 
drivers/usb/musb/dma.h deleted +0 -174

174 lines not on this page · raw message

drivers/usb/musb/musb_core.h +1 -1
index ed02839..56f8fbb 100644
@@ -54,7 +54,7 @@ struct musb_ep;
 
 
 #include "debug.h"
-#include "dma.h"
+#include "musb_dma.h"
 
 #ifdef CONFIG_USB_MUSB_SOC
 /*
drivers/usb/musb/musb_dma.h new file +174 -0

174 lines not on this page · raw message

Signature · 1 line
1.5.2.3
#7 lore raw

PATCH 7/9 musb_hdrc: Rename g_ep0.c musb_gadget_ep0.c

Rename g_ep0.c musb_gadget_ep0.c

---
 drivers/usb/musb/Makefile          |    2 +-
 drivers/usb/musb/g_ep0.c           |  963 ------------------------------------
 drivers/usb/musb/musb_gadget_ep0.c |  963 ++++++++++++++++++++++++++++++++++++
 3 files changed, 964 insertions(+), 964 deletions(-)
 delete mode 100644 drivers/usb/musb/g_ep0.c
 create mode 100644 drivers/usb/musb/musb_gadget_ep0.c
drivers/usb/musb/Makefile +1 -1
index 537faed..e91bb2b 100644
@@ -19,7 +19,7 @@ ifeq ($(CONFIG_ARCH_OMAP2430),y)
 endif
 
 ifeq ($(CONFIG_USB_GADGET_MUSB_HDRC),y)
-	musb_hdrc-objs		+= g_ep0.o musb_gadget.o
+	musb_hdrc-objs		+= musb_gadget_ep0.o musb_gadget.o
 endif
 
 ifeq ($(CONFIG_USB_MUSB_HDRC_HCD),y)
drivers/usb/musb/g_ep0.c deleted +0 -963

963 lines not on this page · raw message

drivers/usb/musb/musb_gadget_ep0.c new file +963 -0

963 lines not on this page · raw message

Signature · 1 line
1.5.2.3
#8 lore raw

PATCH 8/9 musb_hdrc: Rename virthub.c musb_host_virthub.c

Rename virthub.c musb_host_virthub.c

---
 drivers/usb/musb/Makefile            |    2 +-
 drivers/usb/musb/musb_host_virthub.c |  418 ++++++++++++++++++++++++++++++++++
 drivers/usb/musb/virthub.c           |  418 ----------------------------------
 3 files changed, 419 insertions(+), 419 deletions(-)
 create mode 100644 drivers/usb/musb/musb_host_virthub.c
 delete mode 100644 drivers/usb/musb/virthub.c
drivers/usb/musb/Makefile +1 -1
index e91bb2b..4f0ae5a 100644
@@ -23,7 +23,7 @@ ifeq ($(CONFIG_USB_GADGET_MUSB_HDRC),y)
 endif
 
 ifeq ($(CONFIG_USB_MUSB_HDRC_HCD),y)
-	musb_hdrc-objs		+= virthub.o musb_host.o
+	musb_hdrc-objs		+= musb_host_virthub.o musb_host.o
 endif
 
 # the kconfig must guarantee that only one of the
drivers/usb/musb/musb_host_virthub.c new file +418 -0

418 lines not on this page · raw message

drivers/usb/musb/virthub.c deleted +0 -418

418 lines not on this page · raw message

Signature · 1 line
1.5.2.3
#9 lore raw

PATCH 9/9 musb_hdrc: Rename debug.h to musb_debug.h

Rename debug.h to musb_debug.h

---
 drivers/usb/musb/debug.h      |   66 -----------------------------------------
 drivers/usb/musb/musb_core.h  |    2 +-
 drivers/usb/musb/musb_debug.h |   66 +++++++++++++++++++++++++++++++++++++++++
 3 files changed, 67 insertions(+), 67 deletions(-)
 delete mode 100644 drivers/usb/musb/debug.h
 create mode 100644 drivers/usb/musb/musb_debug.h
drivers/usb/musb/debug.h deleted +0 -66
deleted file mode 100644
index 5eff56e..0000000
@@ -1,66 +0,0 @@
-/*
- * MUSB OTG driver debug defines
- *
- * Copyright 2005 Mentor Graphics Corporation
- * Copyright (C) 2005-2006 by Texas Instruments
- * Copyright (C) 2006-2007 Nokia Corporation
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * version 2 as published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
- * 02110-1301 USA
- *
- * THIS SOFTWARE IS PROVIDED "AS IS" AND ANY EXPRESS OR IMPLIED
- * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
- * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.  IN
- * NO EVENT SHALL THE AUTHORS BE LIABLE FOR ANY DIRECT, INDIRECT,
- * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
- * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
- * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
- * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
- * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- *
- */
-
-#ifndef __MUSB_LINUX_DEBUG_H__
-#define __MUSB_LINUX_DEBUG_H__
-
-#define yprintk(facility, format, args...) \
-	do { printk(facility "%s %d: " format , \
-	__FUNCTION__, __LINE__ , ## args); } while (0)
-#define WARN(fmt, args...) yprintk(KERN_WARNING,fmt, ## args)
-#define INFO(fmt,args...) yprintk(KERN_INFO,fmt, ## args)
-#define ERR(fmt,args...) yprintk(KERN_ERR,fmt, ## args)
-
-#define xprintk(level, facility, format, args...) do { \
-	if ( _dbg_level(level) ) { \
-		printk(facility "%s %d: " format , \
-				__FUNCTION__, __LINE__ , ## args); \
-	} } while (0)
-
-#if MUSB_DEBUG > 0
-extern unsigned debug;
-#else
-#define debug	0
-#endif
-
-static inline int _dbg_level(unsigned l)
-{
-	return debug >= l;
-}
-
-#define DBG(level,fmt,args...) xprintk(level,KERN_DEBUG,fmt, ## args)
-
-extern const char *otg_state_string(struct musb *);
-
-#endif				//  __MUSB_LINUX_DEBUG_H__
drivers/usb/musb/musb_core.h +1 -1
index 56f8fbb..29239a0 100644
@@ -53,7 +53,7 @@ struct musb_hw_ep;
 struct musb_ep;
 
 
-#include "debug.h"
+#include "musb_debug.h"
 #include "musb_dma.h"
 
 #ifdef CONFIG_USB_MUSB_SOC
drivers/usb/musb/musb_debug.h new file +66 -0

66 lines not on this page · raw message

Signature · 1 line
1.5.2.3
#10 lore raw
In reply to Tony Lindgren
Quoted 22 lines · Tony Lindgren

Hi all,

Attached patch series replaces Inventra naming with musb, and renames the core musb files to start with musb_.

Renaming the files unifies the file names, and groups them by type. This all should make it easier for people to locate the right piece of code within the driver.

After applying the patch series, the musb directory has following files:

$ ls
cppi_dma.c   musb_core.c        musb_host.c          omap2430.h
cppi_dma.h   musb_core.h        musb_host.h          tusb6010.c
davinci.c    musb_debug.h       musb_host_virthub.c  tusb6010.h
davinci.h    musb_dma.h         musbhsdma.c          tusb6010_omap.c
Kconfig      musb_gadget.c      musb_procfs.c
Makefile     musb_gadget_ep0.c  musb_regs.h
musb_arch.h  musb_gadget.h      omap2430.c
Quoted 1 line

Tested on tusb.

Pushing this series today refreshed based on following comments from David Brownell:

- 1/9: Use MUSB_PIO_ONLY instead of USB_MUSB_DISABLE_DMA, fix Makefile comment

- 3/9: Use musb_io.h instead of musb_arch.h

- 8/9: Use musb_virthub.c instead of musb_host_virthub.c

Regards,

Tony