Skip to contentSkip to conversation

Move PREEMPT_NOTIFIERS into an always-included Kconfig

PATCH In review Avi Kivity 2 participants 3 messages Aug 23, 2007

lore
Share & tools
lore

Avi Kivity

author
#0 lore raw

PATCH 1/1 Move PREEMPT_NOTIFIERS into an always-included Kconfig

Kconfig.preempt is not included on some archs (for example, m68k). On those archs, the Kconfig machinery complains that KVM selects an undefined symbol PREEMPT_NOTIFIERS (which lives in Kconfig.preempt). Pointing out that this is a Kconfig bug does not seem to silence the error, so move the offending symbol into a Kconfig file which is included by everyone.

Cc Roman Zippel <[email protected]>
Cc Geert Uytterhoeven <[email protected]>
init/Kconfig +3 -0
index 96b5459..aae3928 100644
@@ -667,3 +667,6 @@ config STOP_MACHINE
 	  Need stop_machine() primitive.
 
 source "block/Kconfig"
+
+config PREEMPT_NOTIFIERS
+	bool
kernel/Kconfig.preempt +0 -3
index 6b06663..c64ce9c 100644
@@ -63,6 +63,3 @@ config PREEMPT_BKL
 	  Say Y here if you are building a kernel for a desktop system.
 	  Say N if you are unsure.
 
-config PREEMPT_NOTIFIERS
-	bool
-
#1 lore raw

Hi,

Quoted 2 lines · Avi Kivity

Pointing out that this
is a Kconfig bug does not seem to silence the error,

*sigh*
This is not a Kconfig bug!

bye, Roman

author
#2 lore raw
Quoted 5 lines · Roman Zippel

Hi,

On Thu, 23 Aug 2007, Avi Kivity wrote:

Quoted 7 lines
Quoted 3 lines

Pointing out that this
is a Kconfig bug does not seem to silence the error,

*sigh*
This is not a Kconfig bug!

I take it back, then.

Signature · 1 line
error compiling committee.c: too many arguments to function