fs: remove page_readlink
Subsystems (2)
PATCH 1/1 fs: remove page_readlink
Opencode it in AFS, the only user instead.
--- fs/afs/mntpt.c | 13 ++++++++++++- fs/namei.c | 11 ----------- include/linux/fs.h | 1 - 3 files changed, 12 insertions(+), 13 deletions(-)
fs/afs/mntpt.c +12 -1
@@ -31,9 +31,20 @@ const struct file_operations afs_mntpt_file_operations = { .llseek = noop_llseek, }; +static int afs_mntpt_readlink (struct dentry *dentry,char __user *buffer, +int buflen) +{ +DEFINE_DELAYED_CALL (done); +int res =readlink_copy (buffer, buflen, +page_get_link (dentry,d_inode (dentry), + &done)); +do_delayed_call (&done); +return res; +} +const struct inode_operations afs_mntpt_inode_operations = { .lookup = afs_mntpt_lookup, - .readlink = page_readlink, + .readlink = afs_mntpt_readlink, .getattr = afs_getattr, };
fs/namei.c +0 -11
@@ -4746,17 +4746,6 @@ void page_put_link(void *arg) }EXPORT_SYMBOL (page_put_link); -int page_readlink (struct dentry *dentry,char __user *buffer,int buflen) -{ -DEFINE_DELAYED_CALL (done); -int res =readlink_copy (buffer, buflen, -page_get_link (dentry,d_inode (dentry), - &done)); -do_delayed_call (&done); -return res; -} -EXPORT_SYMBOL (page_readlink); -/* * The nofs argument instructs pagecache_write_begin to pass AOP_FLAG_NOFS */
include/linux/fs.h +0 -1
@@ -2897,7 +2897,6 @@ extern const struct file_operations generic_ro_fops;#define special_file (m) (S_ISCHR(m)||S_ISBLK(m)||S_ISFIFO(m)||S_ISSOCK(m))extern int readlink_copy (char __user *,int ,const char *); -extern int page_readlink (struct dentry *,char __user *,int );extern const char *page_get_link (struct dentry *,struct inode *,struct delayed_call *);extern void page_put_link (void *);
Signature · 1 line
2.11.0
Quoted 2 lines · Christoph Hellwig
Opencode it in AFS, the only user instead.
Christopher,
page_readlink() is used by out of tree filesystems as well as "kafs". Please do not remove it.
Thank you.
Jeffrey Altman
begin:vcard
fn:Jeffrey Altman
n:Altman;Jeffrey
org:AuriStor, Inc.
adr:Suite 6B;;255 West 94Th Street;New York;New York;10025-6985;United States email;internet:[email protected]
title:Founder and CEO
tel;work:+1-212-769-9018
note;quoted-printable:LinkedIn: https://www.linkedin.com/in/jeffreyaltman=0D=0A=
Skype: jeffrey.e.altman=0D=0A=
url:https://www.auristor.com/
version:2.1
end:vcard
Quoted 5 lines · Jeffrey Altman
Quoted 2 lines · Christoph Hellwig
Opencode it in AFS, the only user instead.
Christopher,
Christoph, my apologies for mistyping your name.
Jeffrey Altman
begin:vcard
fn:Jeffrey Altman
n:Altman;Jeffrey
org:AuriStor, Inc.
adr:Suite 6B;;255 West 94Th Street;New York;New York;10025-6985;United States email;internet:[email protected]
title:Founder and CEO
tel;work:+1-212-769-9018
note;quoted-printable:LinkedIn: https://www.linkedin.com/in/jeffreyaltman=0D=0A=
Skype: jeffrey.e.altman=0D=0A=
url:https://www.auristor.com/
version:2.1
end:vcard
Quoted 7 lines · Jeffrey Altman
Quoted 2 lines · Christoph Hellwig
Opencode it in AFS, the only user instead.
Christopher,
page_readlink()is used by out of tree filesystems as well as "kafs".
Which does not matter at all.
kbuild test robot
build boturl: https://github.com/0day-ci/linux/commits/Christoph-Hellwig/fs-remove-page_readlink/20170511-062855 config: x86_64-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0…
Hi Christoph,
[auto build test ERROR on linus/master]
[also build test ERROR on v4.11 next-20170510]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Christoph-Hellwig/fs-remove-page_readlink/20170511-062855
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64 All errors (new ones prefixed by >>):
>> ERROR: "readlink_copy" [fs/afs/kafs.ko] undefined!
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
David Howells
maintainerQuoted 1 line · Christoph Hellwig
Opencode it in AFS, the only user instead.
readlink_copy() isn't exported.
David