Current 4xx patch queue

Commit 804ace8881d21 changed the behavior of how compatible nodes are found. This highlighted a bug on the Bamboo board where it wasn't probing the bus specified in the DTS file. We fix it by being explicit about which bus to probe.

Signed-off-by Josh Boyer <[email protected]>

---
 arch/powerpc/platforms/44x/bamboo.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

arch/powerpc/platforms/44x/bamboo.c +1 -1

@@ -23,7 +23,7 @@
 #include "44x.h"
 
 static struct of_device_id bamboo_of_bus[] = {
-	{ .compatible = "ibm,plb", },
+	{ .compatible = "ibm,plb4", },
 	{ .compatible = "ibm,opb", },
 	{ .compatible = "ibm,ebc", },
 	{},

Add a cuboot wrapper for the Bamboo board. This also removes some obsoleted linker declarations that have been moved into ops.h

Signed-off-by Josh Boyer <[email protected]>

arch/powerpc/boot/bamboo.c +1 -2

@@ -24,8 +24,7 @@
 #include "4xx.h"
 #include "44x.h"
 
-extern char _dtb_start[];
-extern char _dtb_end[];
+static u8 *bamboo_mac0, *bamboo_mac1;
 
 static void bamboo_fixups(void)
 {

arch/powerpc/boot/bamboo.c +3 -1

 }
 
-void bamboo_init(void)
+void bamboo_init(void *mac0, void *mac1)
 {
 	platform_ops.fixups = bamboo_fixups;
 	platform_ops.exit = ibm44x_dbcr_reset;
+	bamboo_mac0 = mac0;
+	bamboo_mac1 = mac1;
 	ft_init(_dtb_start, 0, 32);
 	serial_console_init();
 }

arch/powerpc/boot/treeboot-bamboo.c +0 -2

@@ -13,8 +13,6 @@
 #include "stdio.h"
 #include "44x.h"
 
-extern char _end[];
-
 BSS_STACK(4096);
 
 void platform_init(void)

Quoted 4 lines · Josh Boyer

Add a cuboot wrapper for the Bamboo board. This also removes some obsoleted linker declarations that have been moved into ops.h

Signed-off-by Josh Boyer <[email protected]>

[snip]

Quoted 10 lines

arch/powerpc/boot/bamboo.c +1 -2

@@ -24,8 +24,7 @@
 #include "4xx.h"
 #include "44x.h"
 
-extern char _dtb_start[];
-extern char _dtb_end[];
+static u8 *bamboo_mac0, *bamboo_mac1;
 

arch/powerpc/boot/bamboo.c static void bamboo_fixups(void) · line 37

Quoted 8 lines

arch/powerpc/boot/bamboo.c +2 -0

 static void bamboo_fixups(void)
 {

@@ -34,12 +33,16 @@ static void bamboo_fixups(void)
 	ibm440ep_fixup_clocks(sysclk, 11059200);
 	ibm4xx_fixup_memsize();
 	ibm4xx_quiesce_eth((u32 *)0xef600e00, (u32 *)0xef600f00);
+	if (bamboo_mac0 && bamboo_mac1)
+		dt_fixup_mac_addresses(bamboo_mac0, bamboo_mac1);

Bit ugly that you only set the MAC address for any ethernet if they're supplied for every ethernet.

arch/powerpc/boot/bamboo.c static void bamboo_fixups(void) · line 39

Quoted 3 lines

arch/powerpc/boot/bamboo.c +1 -1

 	simple_alloc_init(_end, avail_ram, 32, 64);
-	bamboo_init();
+	bamboo_init(NULL, NULL);

There must surely be a way to get the MAC addresses out of OpenBIOS...

Quoted 17 lines · David Gibson

Quoted 4 lines · Josh Boyer

Add a cuboot wrapper for the Bamboo board. This also removes some obsoleted linker declarations that have been moved into ops.h

Signed-off-by Josh Boyer <[email protected]>

[snip]

Quoted 10 lines

arch/powerpc/boot/bamboo.c +1 -2

@@ -24,8 +24,7 @@
 #include "4xx.h"
 #include "44x.h"
 
-extern char _dtb_start[];
-extern char _dtb_end[];
+static u8 *bamboo_mac0, *bamboo_mac1;
 

Quoted 11 lines

arch/powerpc/boot/bamboo.c static void bamboo_fixups(void) · line 37

Quoted 8 lines

arch/powerpc/boot/bamboo.c +2 -0

 static void bamboo_fixups(void)
 {

@@ -34,12 +33,16 @@ static void bamboo_fixups(void)
 	ibm440ep_fixup_clocks(sysclk, 11059200);
 	ibm4xx_fixup_memsize();
 	ibm4xx_quiesce_eth((u32 *)0xef600e00, (u32 *)0xef600f00);
+	if (bamboo_mac0 && bamboo_mac1)
+		dt_fixup_mac_addresses(bamboo_mac0, bamboo_mac1);

Bit ugly that you only set the MAC address for any ethernet if they're supplied for every ethernet.

Good point. Will fix.

Quoted 5 lines

arch/powerpc/boot/bamboo.c static void bamboo_fixups(void) · line 39

Quoted 3 lines

arch/powerpc/boot/bamboo.c +1 -1

 	simple_alloc_init(_end, avail_ram, 32, 64);
-	bamboo_init();
+	bamboo_init(NULL, NULL);

There must surely be a way to get the MAC addresses out of OpenBIOS...

Probably. I just need to find out where they are stored.

Quoted 38 lines · Josh Boyer

Quoted 17 lines · David Gibson

Quoted 4 lines · Josh Boyer

Add a cuboot wrapper for the Bamboo board. This also removes some obsoleted linker declarations that have been moved into ops.h

Signed-off-by Josh Boyer <[email protected]>

[snip]

Quoted 10 lines

arch/powerpc/boot/bamboo.c +1 -2

@@ -24,8 +24,7 @@
 #include "4xx.h"
 #include "44x.h"
 
-extern char _dtb_start[];
-extern char _dtb_end[];
+static u8 *bamboo_mac0, *bamboo_mac1;
 

Quoted 11 lines

arch/powerpc/boot/bamboo.c static void bamboo_fixups(void) · line 37

Quoted 8 lines

arch/powerpc/boot/bamboo.c +2 -0

 static void bamboo_fixups(void)
 {

@@ -34,12 +33,16 @@ static void bamboo_fixups(void)
 	ibm440ep_fixup_clocks(sysclk, 11059200);
 	ibm4xx_fixup_memsize();
 	ibm4xx_quiesce_eth((u32 *)0xef600e00, (u32 *)0xef600f00);
+	if (bamboo_mac0 && bamboo_mac1)
+		dt_fixup_mac_addresses(bamboo_mac0, bamboo_mac1);

Bit ugly that you only set the MAC address for any ethernet if they're supplied for every ethernet.

Good point. Will fix.

Quoted 5 lines

arch/powerpc/boot/bamboo.c static void bamboo_fixups(void) · line 39

Quoted 3 lines

arch/powerpc/boot/bamboo.c +1 -1

 	simple_alloc_init(_end, avail_ram, 32, 64);
-	bamboo_init();
+	bamboo_init(NULL, NULL);

There must surely be a way to get the MAC addresses out of OpenBIOS...

Quoted 1 line

Probably. I just need to find out where they are stored.

It's not buried somewhere in the arch/ppc/boot code?

Quoted 39 lines · David Gibson

Quoted 38 lines · Josh Boyer

Quoted 17 lines · David Gibson

Quoted 4 lines · Josh Boyer

Add a cuboot wrapper for the Bamboo board. This also removes some obsoleted linker declarations that have been moved into ops.h

Signed-off-by Josh Boyer <[email protected]>

[snip]

Quoted 10 lines

arch/powerpc/boot/bamboo.c +1 -2

@@ -24,8 +24,7 @@
 #include "4xx.h"
 #include "44x.h"
 
-extern char _dtb_start[];
-extern char _dtb_end[];
+static u8 *bamboo_mac0, *bamboo_mac1;
 

Quoted 11 lines

arch/powerpc/boot/bamboo.c static void bamboo_fixups(void) · line 37

Quoted 8 lines

arch/powerpc/boot/bamboo.c +2 -0

 static void bamboo_fixups(void)
 {

@@ -34,12 +33,16 @@ static void bamboo_fixups(void)
 	ibm440ep_fixup_clocks(sysclk, 11059200);
 	ibm4xx_fixup_memsize();
 	ibm4xx_quiesce_eth((u32 *)0xef600e00, (u32 *)0xef600f00);
+	if (bamboo_mac0 && bamboo_mac1)
+		dt_fixup_mac_addresses(bamboo_mac0, bamboo_mac1);

Bit ugly that you only set the MAC address for any ethernet if they're supplied for every ethernet.

Good point. Will fix.

Quoted 5 lines

arch/powerpc/boot/bamboo.c static void bamboo_fixups(void) · line 39

Quoted 3 lines

arch/powerpc/boot/bamboo.c +1 -1

 	simple_alloc_init(_end, avail_ram, 32, 64);
-	bamboo_init();
+	bamboo_init(NULL, NULL);

There must surely be a way to get the MAC addresses out of OpenBIOS...

Quoted 3 lines

Quoted 1 line

Probably. I just need to find out where they are stored.

It's not buried somewhere in the arch/ppc/boot code?

It's not OpenBIOS, it's PIBS. And the arch/ppc port uses __res, which I'd rather avoid. But I did find where it's stored in flash, so I can read it from there. I just need to do a little more work to get it in a manner that can be used.

Quoted 6 lines

Quoted 5 lines

Quoted 3 lines

Quoted 1 line

There must surely be a way to get the MAC addresses out of OpenBIOS...

Probably. I just need to find out where they are stored.

It's not buried somewhere in the arch/ppc/boot code?

Quoted 4 lines

It's not OpenBIOS, it's PIBS. And the arch/ppc port uses __res, which I'd rather avoid. But I did find where it's stored in flash, so I can read it from there. I just need to do a little more work to get it in a manner that can be used.

Hrm.. is that address actually guaranteed to be stable across PIBS versions? If arch/ppc uses __res, I think we should do that too. It shouldn't be any worse than what we already do fot cuboot.

Updated patch below. NOTE: This relies on Scott Wood's strtoull patch as PIBS stores the MAC addresses as ASCII strings in flash.

Add a cuboot wrapper for the Bamboo board. This also removes some obsoleted linker declarations that have been moved into ops.h

Signed-off-by Josh Boyer <[email protected]>

Quoted 11 lines · David Gibson

Quoted 10 lines

Quoted 5 lines

Quoted 3 lines

Quoted 1 line

There must surely be a way to get the MAC addresses out of OpenBIOS...

Probably. I just need to find out where they are stored.

It's not buried somewhere in the arch/ppc/boot code?

It's not OpenBIOS, it's PIBS. And the arch/ppc port uses __res, which I'd rather avoid. But I did find where it's stored in flash, so I can read it from there. I just need to do a little more work to get it in a manner that can be used.

Quoted 3 lines

Hrm.. is that address actually guaranteed to be stable across PIBS versions? If arch/ppc uses __res, I think we should do that too. It shouldn't be any worse than what we already do fot cuboot.

The address should be stable for all versions of PIBS that come on the Bamboo boards, yes. And after looking at it a bit more, the wrapper in arch/ppc for PIBS essentially mocks up __res by reading the values out of flash. So the way I'm doing it is the way it was already done.

Device tree source file for the PPC405 Walnut evaluation board.

Signed-off-by Josh Boyer <[email protected]>

---
 arch/powerpc/boot/dts/walnut.dts |  183 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 183 insertions(+)

arch/powerpc/boot/dts/walnut.dts new file +64 -0

@@ -0,0 +1,183 @@
+/*
+ * Device Tree Source for IBM Walnut
+ *
+ * Copyright 2007 IBM Corp.
+ * Josh Boyer <[email protected]>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2.  This program is licensed "as is" without
+ * any warranty of any kind, whether express or implied.
+ */
+
+/ {
+	#address-cells = <1>;
+	#size-cells = <1>;
+	model = "ibm,walnut";
+	compatible = "ibm,walnut";
+	dcr-parent = <&/cpus/PowerPC,405GP@0>;
+
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		PowerPC,405GP@0 {
+			device_type = "cpu";
+			reg = <0>;
+			clock-frequency = <bebc200>; /* Filled in by zImage */
+			timebase-frequency = <0>; /* Filled in by zImage */
+			i-cache-line-size = <20>;
+			d-cache-line-size = <20>;
+			i-cache-size = <4000>;
+			d-cache-size = <4000>;
+			dcr-controller;
+			dcr-access-method = "native";
+		};
+	};
+
+	memory {
+		device_type = "memory";
+		reg = <0 0>; /* Filled in by zImage */
+	};
+
+	UIC0: interrupt-controller {
+		compatible = "ibm,uic";
+		interrupt-controller;
+		cell-index = <0>;
+		dcr-reg = <0c0 9>;
+		#address-cells = <0>;
+		#size-cells = <0>;
+		#interrupt-cells = <2>;
+	};
+
+	plb {
+		compatible = "ibm,plb3";
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+		clock-frequency = <0>; /* Filled in by zImage */
+
+		SDRAM0: memory-controller {
+			compatible = "ibm,sdram-405gp";
+			dcr-reg = <010 2>;
+		};
+
+		MAL: mcmal {

arch/powerpc/boot/dts/walnut.dts new file +106 -0

+			dcr-reg = <0a0 5>;
+			clock-frequency = <0>; /* Filled in by zImage */
+
+			UART0: serial@300 {
+				device_type = "serial";
+				compatible = "ns16550";
+				reg = <300 8>;
+				virtual-reg = <ef600300>;
+				clock-frequency = <0>; /* Filled in by zImage */
+				current-speed = <2580>;
+				interrupt-parent = <&UIC0>;
+				interrupts = <0 4>;
+			};
+
+			UART1: serial@400 {
+				device_type = "serial";
+				compatible = "ns16550";
+				reg = <400 8>;
+				virtual-reg = <ef600400>;
+				clock-frequency = <0>; /* Filled in by zImage */
+				current-speed = <2580>;
+				interrupt-parent = <&UIC0>;
+				interrupts = <1 4>;
+			};
+
+			IIC: i2c@500 {
+				compatible = "ibm,iic-405gp", "ibm,iic";
+				reg = <500 11>;
+				interrupt-parent = <&UIC0>;
+				interrupts = <2 4>;
+			};
+
+			GPIO: gpio@700 {
+				compatible = "ibm,gpio-405gp";
+				reg = <700 20>;
+			};
+
+			EMAC: ethernet@800 {
+				linux,network-index = <0>;
+				device_type = "network";
+				compatible = "ibm,emac-405gp", "ibm,emac";
+				interrupt-parent = <&UIC0>;
+				interrupts = <9 4 f 4>;
+				reg = <800 70>;
+				mal-device = <&MAL>;
+				mal-tx-channel = <0 1>;
+				mal-rx-channel = <0>;
+				cell-index = <0>;
+				max-frame-size = <5dc>;
+				rx-fifo-size = <1000>;
+				tx-fifo-size = <800>;
+				phy-mode = "rmii";
+				phy-map = <00000001>;
+			};
+
+		};
+
+		EBC0: ebc {
+			compatible = "ibm,ebc-405gp", "ibm,ebc";
+			dcr-reg = <012 2>;
+			#address-cells = <2>;
+			#size-cells = <1>;
+			clock-frequency = <0>; /* Filled in by zImage */
+
+			sram@0,0 {
+				reg = <0 0 80000>;
+			};
+
+			flash@0,80000 {
+				device_type = "rom";
+				compatible = "direct-mapped";
+				probe-type = "JEDEC";
+				bank-width = <1>;
+				partitions = <0 80000>;
+				partition-names = "OpenBIOS";
+				reg = <0 80000 80000>;
+			};
+
+			ds1743@1,0 {
+				/* NVRAM and RTC */
+				compatible = "ds1743";
+				reg = <1 0 2000>;
+			};
+
+			keyboard@2,0 {
+				compatible = "intel,82C42PC";
+				reg = <2 0 2>;
+			};
+
+			ir@3,0 {
+				compatible = "ti,TIR2000PAG";
+				reg = <3 0 10>;
+			};
+
+			fpga@7,0 {
+				compatible = "Walnut-FPGA";
+				reg = <7 0 10>;
+				virtual-reg = <f0300005>;
+			};
+		};
+	};
+
+	chosen {
+		linux,stdout-path = "/plb/opb/serial@300";
+	};
+};

Quoted 79 lines · Josh Boyer

Device tree source file for the PPC405 Walnut evaluation board.

Signed-off-by Josh Boyer <[email protected]>

---
 arch/powerpc/boot/dts/walnut.dts |  183 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 183 insertions(+)

arch/powerpc/boot/dts/walnut.dts new file +68 -0

@@ -0,0 +1,183 @@
+/*
+ * Device Tree Source for IBM Walnut
+ *
+ * Copyright 2007 IBM Corp.
+ * Josh Boyer <[email protected]>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2.  This program is licensed "as is" without
+ * any warranty of any kind, whether express or implied.
+ */
+
+/ {
+	#address-cells = <1>;
+	#size-cells = <1>;
+	model = "ibm,walnut";
+	compatible = "ibm,walnut";
+	dcr-parent = <&/cpus/PowerPC,405GP@0>;
+
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		PowerPC,405GP@0 {
+			device_type = "cpu";
+			reg = <0>;
+			clock-frequency = <bebc200>; /* Filled in by zImage */
+			timebase-frequency = <0>; /* Filled in by zImage */
+			i-cache-line-size = <20>;
+			d-cache-line-size = <20>;
+			i-cache-size = <4000>;
+			d-cache-size = <4000>;
+			dcr-controller;
+			dcr-access-method = "native";
+		};
+	};
+
+	memory {
+		device_type = "memory";
+		reg = <0 0>; /* Filled in by zImage */
+	};
+
+	UIC0: interrupt-controller {
+		compatible = "ibm,uic";
+		interrupt-controller;
+		cell-index = <0>;
+		dcr-reg = <0c0 9>;
+		#address-cells = <0>;
+		#size-cells = <0>;
+		#interrupt-cells = <2>;
+	};
+
+	plb {
+		compatible = "ibm,plb3";
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+		clock-frequency = <0>; /* Filled in by zImage */
+
+		SDRAM0: memory-controller {
+			compatible = "ibm,sdram-405gp";
+			dcr-reg = <010 2>;
+		};
+
+		MAL: mcmal {
+			compatible = "ibm,mcmal-405gp", "ibm,mcmal";
+			dcr-reg = <180 62>;
+			num-tx-chans = <2>;
+			num-rx-chans = <1>;

arch/powerpc/boot/dts/walnut.dts line 74

Quoted 6 lines

arch/powerpc/boot/dts/walnut.dts new file +6 -0

+			interrupt-parent = <&UIC0>;
+			interrupts = <a 4 b 4 c 4 d 4 e 4>;
+		};
+
+		POB0: opb {
+			compatible = "ibm,opb";

Need an opb-405gp here, too.

arch/powerpc/boot/dts/walnut.dts line 77

Quoted 3 lines

arch/powerpc/boot/dts/walnut.dts new file +3 -0

+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges = <0 ef600000 a00000>;

Hrm... something we ought to clarify is the interpretation of the POB0_BEAR register with respect to the bridge's ranges property. For 440 I think the BEAR will need to be interpreted as an OPB address, rather than a PLB address, but I'm not sure if that will work here with the limited ranges property you have.

Quoted 80 lines · David Gibson

Quoted 79 lines · Josh Boyer

Device tree source file for the PPC405 Walnut evaluation board.

Signed-off-by Josh Boyer <[email protected]>

---
 arch/powerpc/boot/dts/walnut.dts |  183 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 183 insertions(+)

arch/powerpc/boot/dts/walnut.dts new file +68 -0

@@ -0,0 +1,183 @@
+/*
+ * Device Tree Source for IBM Walnut
+ *
+ * Copyright 2007 IBM Corp.
+ * Josh Boyer <[email protected]>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2.  This program is licensed "as is" without
+ * any warranty of any kind, whether express or implied.
+ */
+
+/ {
+	#address-cells = <1>;
+	#size-cells = <1>;
+	model = "ibm,walnut";
+	compatible = "ibm,walnut";
+	dcr-parent = <&/cpus/PowerPC,405GP@0>;
+
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		PowerPC,405GP@0 {
+			device_type = "cpu";
+			reg = <0>;
+			clock-frequency = <bebc200>; /* Filled in by zImage */
+			timebase-frequency = <0>; /* Filled in by zImage */
+			i-cache-line-size = <20>;
+			d-cache-line-size = <20>;
+			i-cache-size = <4000>;
+			d-cache-size = <4000>;
+			dcr-controller;
+			dcr-access-method = "native";
+		};
+	};
+
+	memory {
+		device_type = "memory";
+		reg = <0 0>; /* Filled in by zImage */
+	};
+
+	UIC0: interrupt-controller {
+		compatible = "ibm,uic";
+		interrupt-controller;
+		cell-index = <0>;
+		dcr-reg = <0c0 9>;
+		#address-cells = <0>;
+		#size-cells = <0>;
+		#interrupt-cells = <2>;
+	};
+
+	plb {
+		compatible = "ibm,plb3";
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+		clock-frequency = <0>; /* Filled in by zImage */
+
+		SDRAM0: memory-controller {
+			compatible = "ibm,sdram-405gp";
+			dcr-reg = <010 2>;
+		};
+
+		MAL: mcmal {
+			compatible = "ibm,mcmal-405gp", "ibm,mcmal";
+			dcr-reg = <180 62>;
+			num-tx-chans = <2>;
+			num-rx-chans = <1>;

Quoted 8 lines

arch/powerpc/boot/dts/walnut.dts line 74

Quoted 6 lines

arch/powerpc/boot/dts/walnut.dts new file +6 -0

+			interrupt-parent = <&UIC0>;
+			interrupts = <a 4 b 4 c 4 d 4 e 4>;
+		};
+
+		POB0: opb {
+			compatible = "ibm,opb";

Need an opb-405gp here, too.

Yep.

Quoted 9 lines

arch/powerpc/boot/dts/walnut.dts line 77

Quoted 3 lines

arch/powerpc/boot/dts/walnut.dts new file +3 -0

+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges = <0 ef600000 a00000>;

Hrm... something we ought to clarify is the interpretation of the POB0_BEAR register with respect to the bridge's ranges property. For 440 I think the BEAR will need to be interpreted as an OPB address, rather than a PLB address, but I'm not sure if that will work here with the limited ranges property you have.

Ok, I'll look at this.

On Sun, 02 Sep 2007 08:59:44 -0500
Josh Boyer <[email protected]> wrote:

Quoted 6 lines

Quoted 4 lines

arch/powerpc/boot/dts/walnut.dts line 74

Quoted 2 lines

arch/powerpc/boot/dts/walnut.dts new file +2 -0

+		POB0: opb {
+			compatible = "ibm,opb";

Need an opb-405gp here, too.

Yep.

Fixed.

Quoted 10 lines

Quoted 9 lines

arch/powerpc/boot/dts/walnut.dts line 77

Quoted 3 lines

arch/powerpc/boot/dts/walnut.dts new file +3 -0

+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges = <0 ef600000 a00000>;

Hrm... something we ought to clarify is the interpretation of the POB0_BEAR register with respect to the bridge's ranges property. For 440 I think the BEAR will need to be interpreted as an OPB address, rather than a PLB address, but I'm not sure if that will work here with the limited ranges property you have.

Quoted 1 line

Ok, I'll look at this.

The BEAR will still be interpreted as a PLB address here as far as I can see. The ranges spans the entire OPB space. Am I missing something?

Quoted 2 lines · Josh Boyer

On Sun, 02 Sep 2007 08:59:44 -0500
Josh Boyer <[email protected]> wrote:

[snip]

Quoted 21 lines

Quoted 6 lines

Quoted 4 lines

arch/powerpc/boot/dts/walnut.dts line 74

Quoted 2 lines

arch/powerpc/boot/dts/walnut.dts new file +2 -0

+		POB0: opb {
+			compatible = "ibm,opb";

Need an opb-405gp here, too.

Yep.

Fixed.

Quoted 11 lines

Quoted 9 lines

arch/powerpc/boot/dts/walnut.dts line 77

Quoted 3 lines

arch/powerpc/boot/dts/walnut.dts new file +3 -0

+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges = <0 ef600000 a00000>;

Hrm... something we ought to clarify is the interpretation of the POB0_BEAR register with respect to the bridge's ranges property. For 440 I think the BEAR will need to be interpreted as an OPB address, rather than a PLB address, but I'm not sure if that will work here with the limited ranges property you have.

Ok, I'll look at this.

Quoted 3 lines

The BEAR will still be interpreted as a PLB address here as far as I can see. The ranges spans the entire OPB space. Am I missing something?

Ah, sorry, my mistake. I thought the BEAR register would encode an OPB address rather than a PLB address (and thus, be only 32-bits wide on 440). In fact it appears it does encode a PLB address (and is split into BEARH and BEARL registers on 440).

Hrm.. I'm still slightly uneasy though. In my Ebony device tree, the POB's ranges exists to embed the 32-bit OPB space into the 64-bit PLB space by tacking on a 0x1 in bits 32:35. In your 405gp ranges, you're describing just the address range used by OPB peripherals (0xef600000-0xf0000000) as residing at address 0 in OPB-space.

Since the ranges will still generate the right physical addresses, I guess it doesn't matter. But I'm not sure it meets the principle of least surprise - since I think the documentation generally talks as though addresses on the 405 OPB bus are identical to addreses on the PLB.

Quoted 6 lines

Hrm.. I'm still slightly uneasy though. In my Ebony device tree, the POB's ranges exists to embed the 32-bit OPB space into the 64-bit PLB space by tacking on a 0x1 in bits 32:35. In your 405gp ranges, you're describing just the address range used by OPB peripherals (0xef600000-0xf0000000) as residing at address 0 in OPB-space.

Quoted 5 lines

Since the ranges will still generate the right physical addresses, I guess it doesn't matter. But I'm not sure it meets the principle of least surprise - since I think the documentation generally talks as though addresses on the 405 OPB bus are identical to addreses on the PLB.

I don't care either way. If I remember correctly, this way of doing it came out of a discussion with Segher.

Updated DTS below

Device tree source file for the PPC405 Walnut evaluation board.

Signed-off-by Josh Boyer <[email protected]>

Board support for the PPC405 Walnut evaluation board

Signed-off-by Josh Boyer <[email protected]>

arch/powerpc/platforms/40x/Kconfig +0 -4

@@ -53,13 +53,13 @@
 #	help
 #	  This option enables support for the IBM PPC405GPr evaluation board.
 
-#config WALNUT
-#	bool "Walnut"
-#	depends on 40x
-#	default y

Quoted 3 lines · Josh Boyer

Board support for the PPC405 Walnut evaluation board

Signed-off-by Josh Boyer <[email protected]>

[snip]

Quoted 6 lines

arch/powerpc/platforms/40x/Kconfig +0 -0

@@ -53,13 +53,13 @@
 #	help
 #	  This option enables support for the IBM PPC405GPr evaluation board.
 

Quoted 4 lines

arch/powerpc/platforms/40x/Kconfig +0 -4

-#config WALNUT
-#	bool "Walnut"
-#	depends on 40x
-#	default y

arch/powerpc/platforms/40x/Kconfig line 62

Quoted 10 lines

arch/powerpc/platforms/40x/Kconfig +7 -3

-#	select 405GP
-#	help
-#	  This option enables support for the IBM PPC405GP evaluation board.
+config WALNUT
+	bool "Walnut"
+	depends on 40x
+	default y
+	select 405GP
+	help
+	  This option enables support for the IBM PPC405GP evaluation board.

Surely this needs WANT_DEVICE_TREE, too.

Quoted 12 lines · David Gibson

Quoted 3 lines · Josh Boyer

Board support for the PPC405 Walnut evaluation board

Signed-off-by Josh Boyer <[email protected]>

[snip]

Quoted 6 lines

arch/powerpc/platforms/40x/Kconfig +0 -0

@@ -53,13 +53,13 @@
 #	help
 #	  This option enables support for the IBM PPC405GPr evaluation board.
 

Quoted 16 lines

Quoted 4 lines

arch/powerpc/platforms/40x/Kconfig +0 -4

-#config WALNUT
-#	bool "Walnut"
-#	depends on 40x
-#	default y

arch/powerpc/platforms/40x/Kconfig line 62

Quoted 10 lines

arch/powerpc/platforms/40x/Kconfig +7 -3

-#	select 405GP
-#	help
-#	  This option enables support for the IBM PPC405GP evaluation board.
+config WALNUT
+	bool "Walnut"
+	depends on 40x
+	default y
+	select 405GP
+	help
+	  This option enables support for the IBM PPC405GP evaluation board.

Surely this needs WANT_DEVICE_TREE, too.

Yes, will be fixed.

Quoted 30 lines · On Sun, 02 Sep 2007 08:59:06 -0500 Josh Boyer <[email protected]>…

Quoted 28 lines · David Gibson

Quoted 3 lines · Josh Boyer

Board support for the PPC405 Walnut evaluation board

Signed-off-by Josh Boyer <[email protected]>

[snip]

Quoted 10 lines

arch/powerpc/platforms/40x/Kconfig +0 -4

@@ -53,13 +53,13 @@
 #	help
 #	  This option enables support for the IBM PPC405GPr evaluation board.
 
-#config WALNUT
-#	bool "Walnut"
-#	depends on 40x
-#	default y

arch/powerpc/platforms/40x/Kconfig line 62

Quoted 10 lines

arch/powerpc/platforms/40x/Kconfig +7 -3

-#	select 405GP
-#	help
-#	  This option enables support for the IBM PPC405GP evaluation board.
+config WALNUT
+	bool "Walnut"
+	depends on 40x
+	default y
+	select 405GP
+	help
+	  This option enables support for the IBM PPC405GP evaluation board.

Surely this needs WANT_DEVICE_TREE, too.

Quoted 1 line

Yes, will be fixed.

Er, actually no it won't. It doesn't need to be selected here, as 40x in arch/powerpc/platforms/Kconfig.cputype already selects WANT_DEVICE_TREE. Same thing that ebony and bamboo do for 44x.

Board support for the PPC405 Walnut evaluation board

Signed-off-by Josh Boyer <[email protected]>

Add zImage wrapper for walnut board

Signed-off-by Josh Boyer <[email protected]>

arch/powerpc/boot/treeboot-walnut.c new file +15 -0

@@ -0,0 +1,133 @@
+/*
+ * Old U-boot compatibility for Walnut
+ *
+ * Author: Josh Boyer <[email protected]>
+ *
+ * Copyright 2007 IBM Corporation
+ *   Based on cuboot-83xx.c, which is:
+ * Copyright (c) 2007 Freescale Semiconductor, Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 as published
+ * by the Free Software Foundation.
+ */
+
+#include "ops.h"

arch/powerpc/boot/treeboot-walnut.c new file +108 -0

+	u32 cpc0_cr0 = mfdcr(0xb1);
+	u32 cpc0_cr1 = mfdcr(0xb2);
+	u32 cpu, plb, opb, ebc, tb, uart0, uart1, m;
+	u32 fwdv, fbdv, cbdv, opdv, epdv, udiv;
+
+	fwdv = (8 - ((pllmr & 0xe0000000) >> 29));
+	fbdv = (pllmr & 0x1e000000) >> 25;
+	cbdv = ((pllmr & 0x00060000) >> 17) + 1;
+	opdv = ((pllmr & 0x00018000) >> 15) + 1;
+	epdv = ((pllmr & 0x00001800) >> 13) + 2;
+	udiv = ((cpc0_cr0 & 0x3e) >> 1) + 1;
+
+	m = fwdv * fbdv * cbdv;
+
+	cpu = sysclk * m / fwdv;
+	plb = cpu / cbdv;
+	opb = plb / opdv;
+	ebc = plb / epdv;
+
+	if (cpc0_cr0 & 0x80) {
+		/* uart0 uses the external clock */
+		uart0 = ser_clk;
+	} else {
+		uart0 = cpu / udiv;
+	}
+
+	if (cpc0_cr0 & 0x40) {
+		/* uart1 uses the external clock */
+		uart1 = ser_clk;
+	} else {
+		uart1 = cpu / udiv;
+	}
+
+	/* setup the timebase clock to tick at the cpu frequency */
+	cpc0_cr1 = cpc0_cr1 & ~ 0x00800000;
+	mtdcr(0xb2, cpc0_cr1);
+	tb = cpu;
+
+	dt_fixup_cpu_clocks(cpu, tb, 0);
+	dt_fixup_clock("/plb", plb);
+	dt_fixup_clock("/plb/opb", opb);
+	dt_fixup_clock("/plb/ebc", ebc);
+	dt_fixup_clock("/plb/opb/serial@300", uart0);
+	dt_fixup_clock("/plb/opb/serial@400", uart1);
+}
+
+static void walnut_flashsel_fixup(void)
+{
+	void *devp, *sram;
+	u32 reg_flash[3] = {0x0, 0x0, 0x80000};
+	u32 reg_sram[3] = {0x0, 0x0, 0x80000};
+	u8 *fpga;
+	u8 fpga_brds1 = 0x0;
+
+	devp = finddevice("/plb/ebc/fpga");
+	if (!devp)
+		fatal("Couldn't locate FPGA node\n\r");
+
+	if (getprop(devp, "virtual-reg", &fpga, sizeof(fpga)) != sizeof(fpga))
+		fatal("no virtual-reg property\n\r");
+
+	fpga_brds1 = in_8(fpga);
+
+	printf("FPGA_BRDS1: %08x\n", fpga_brds1);
+
+	devp = finddevice("/plb/ebc/flash");
+	if (!devp)
+		fatal("Couldn't locate flash node\n\r");
+
+	if (getprop(devp, "reg", reg_flash, sizeof(reg_flash)) != sizeof(reg_flash))
+		fatal("flash reg property has unexpected size\n\r");
+
+	sram = finddevice("/plb/ebc/sram");
+	if (!sram)
+		fatal("Couldn't locate sram node\n\r");
+
+	if (getprop(sram, "reg", reg_sram, sizeof(reg_sram)) != sizeof(reg_sram))
+		fatal("sram reg property has unexpected size\n\r");
+
+	if (fpga_brds1 & 0x1) {
+		reg_flash[1] ^= 0x80000;
+		reg_sram[1] ^= 0x80000;
+	}
+
+	setprop(devp, "reg", reg_flash, sizeof(reg_flash));
+	setprop(sram, "reg", reg_sram, sizeof(reg_sram));
+}
+
+static void walnut_fixups(void)
+{
+	ibm4xx_fixup_memsize();
+	ibm405gp_fixup_clocks(33330000, 0xa8c000);
+	ibm4xx_quiesce_eth((u32 *)0xef600800, NULL);
+	ibm4xx_fixup_ebc_ranges("/plb/ebc");
+	walnut_flashsel_fixup();
+}
+
+void platform_init(void)
+{
+	unsigned long end_of_ram = 0x2000000;
+	unsigned long avail_ram = end_of_ram - (unsigned long) _end;
+
+	simple_alloc_init(_end, avail_ram, 32, 32);
+	platform_ops.fixups = walnut_fixups;
+	platform_ops.exit = ibm40x_dbcr_reset;
+	ft_init(_dtb_start, _dtb_end - _dtb_start, 32);
+	serial_console_init();
+}

Quoted 3 lines · Josh Boyer

Add zImage wrapper for walnut board

Signed-off-by Josh Boyer <[email protected]>

[snip]

Quoted 22 lines

arch/powerpc/boot/treeboot-walnut.c new file +19 -0

@@ -0,0 +1,133 @@
+/*
+ * Old U-boot compatibility for Walnut
+ *
+ * Author: Josh Boyer <[email protected]>
+ *
+ * Copyright 2007 IBM Corporation
+ *   Based on cuboot-83xx.c, which is:
+ * Copyright (c) 2007 Freescale Semiconductor, Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 as published
+ * by the Free Software Foundation.
+ */
+
+#include "ops.h"
+#include "stdio.h"
+#include "dcr.h"
+#include "4xx.h"
+#include "io.h"

arch/powerpc/boot/treeboot-walnut.c line 25

Quoted 6 lines

arch/powerpc/boot/treeboot-walnut.c new file +6 -0

+
+BSS_STACK(4096);
+
+void ibm405gp_fixup_clocks(unsigned int sysclk, unsigned int ser_clk)
+{
+	u32 pllmr = mfdcr(0xb0);

Please add #defines for the DCR numbers, rather than using literals.

Updated patch below

Add zImage wrapper for walnut board

Signed-off-by Josh Boyer <[email protected]>

Updated patch below

Add zImage wrapper for walnut board

Signed-off-by Josh Boyer <[email protected]>

---
 arch/powerpc/boot/Makefile          |    3 
 arch/powerpc/boot/dcr.h             |    5 +
 arch/powerpc/boot/treeboot-walnut.c |  131 ++++++++++++++++++++++++++++++++++++
 3 files changed, 138 insertions(+), 1 deletion(-)

The addition of treeboot-walnut.c breaks compilation of Linux-2.6 for the lite5200 using the ppc_6xx toolchain of the ELDK 4.1:

MODPOST vmlinux.o
WARNING: vmlinux.o(.text+0x14): Section mismatch: reference to .init.text:prom_init (between '__start' and '__after_mmu_off')
WARNING: vmlinux.o(.text+0x28): Section mismatch: reference to .init.text:early_init (between '__start' and '__after_mmu_off')
WARNING: vmlinux.o(.text+0x340c): Section mismatch: reference to .init.text:machine_init (between 'start_here' and 'set_context')
WARNING: vmlinux.o(.text+0x3414): Section mismatch: reference to .init.text:MMU_init (between 'start_here' and 'set_context')
WARNING: vmlinux.o(.text+0x343e): Section mismatch: reference to .init.text:start_kernel (between 'start_here' and 'set_context')
WARNING: vmlinux.o(.text+0x3442): Section mismatch: reference to .init.text:start_kernel (between 'start_here' and 'set_context')

   GEN     .version
   CHK     include/linux/compile.h
   UPD     include/linux/compile.h
   CC      init/version.o
   LD      init/built-in.o
   LD      vmlinux
   SYSMAP  System.map
   BOOTAS  arch/powerpc/boot/string.o
   BOOTAS  arch/powerpc/boot/crt0.o
   BOOTCC  arch/powerpc/boot/stdio.o
   BOOTCC  arch/powerpc/boot/main.o
   BOOTCC  arch/powerpc/boot/flatdevtree.o
   BOOTCC  arch/powerpc/boot/flatdevtree_misc.o
   BOOTCC  arch/powerpc/boot/ns16550.o
   BOOTCC  arch/powerpc/boot/serial.o
   BOOTCC  arch/powerpc/boot/simple_alloc.o
   BOOTAS  arch/powerpc/boot/div64.o
   BOOTAS  arch/powerpc/boot/util.o
   BOOTCC  arch/powerpc/boot/gunzip_util.o
   BOOTCC  arch/powerpc/boot/elf_util.o
   BOOTCC  arch/powerpc/boot/inffast.o
   BOOTCC  arch/powerpc/boot/inflate.o
   BOOTCC  arch/powerpc/boot/inftrees.o
   BOOTCC  arch/powerpc/boot/devtree.o
   BOOTCC  arch/powerpc/boot/oflib.o
   BOOTCC  arch/powerpc/boot/ofconsole.o
   BOOTCC  arch/powerpc/boot/4xx.o
   BOOTCC  arch/powerpc/boot/ebony.o
   BOOTCC  arch/powerpc/boot/mv64x60.o
   BOOTCC  arch/powerpc/boot/mpsc.o
   BOOTCC  arch/powerpc/boot/mv64x60_i2c.o
   BOOTCC  arch/powerpc/boot/cuboot.o
   BOOTCC  arch/powerpc/boot/bamboo.o
   BOOTAR  arch/powerpc/boot/wrapper.a
   BOOTCC  arch/powerpc/boot/of.o
   BOOTCC  arch/powerpc/boot/cuboot-83xx.o
   BOOTCC  arch/powerpc/boot/cuboot-85xx.o
   BOOTCC  arch/powerpc/boot/holly.o
   BOOTCC  arch/powerpc/boot/cuboot-ebony.o
   BOOTCC  arch/powerpc/boot/treeboot-ebony.o
   BOOTCC  arch/powerpc/boot/prpmc2800.o
   BOOTAS  arch/powerpc/boot/ps3-head.o
   BOOTAS  arch/powerpc/boot/ps3-hvcall.o
   BOOTCC  arch/powerpc/boot/ps3.o
   BOOTCC  arch/powerpc/boot/treeboot-bamboo.o
   BOOTCC  arch/powerpc/boot/cuboot-sequoia.o
   BOOTCC  arch/powerpc/boot/treeboot-walnut.o

{standard input}: Assembler messages:
{standard input}:184: Error: Unrecognized opcode: mfdcr' {standard input}:185: Error: Unrecognized opcode: mfdcr' {standard input}:186: Error: Unrecognized opcode: mfdcr' {standard input}:217: Error: Unrecognized opcode: mtdcr' make[1]: *** [arch/powerpc/boot/treeboot-walnut.o] Error 1
make: *** [uImage] Error 2

It looks like the ppc_6xx toolchain does not know the opcode above. I wonder why files for other PowerPC sub-archs like 4xx are compiled with the wrong compiler. Have I missed something?

And the WARNING above on "Section mismatch" looks strange as well (still present in 2.6.23-rc7).

Quoted 64 lines · On Mon, 24 Sep 2007 09:49:33 +0200 Wolfgang Grandegger <[email protected]>…

The addition of treeboot-walnut.c breaks compilation of Linux-2.6 for the lite5200 using the ppc_6xx toolchain of the ELDK 4.1:

MODPOST vmlinux.o
WARNING: vmlinux.o(.text+0x14): Section mismatch: reference to .init.text:prom_init (between '__start' and '__after_mmu_off')
WARNING: vmlinux.o(.text+0x28): Section mismatch: reference to .init.text:early_init (between '__start' and '__after_mmu_off')
WARNING: vmlinux.o(.text+0x340c): Section mismatch: reference to .init.text:machine_init (between 'start_here' and 'set_context')
WARNING: vmlinux.o(.text+0x3414): Section mismatch: reference to .init.text:MMU_init (between 'start_here' and 'set_context')
WARNING: vmlinux.o(.text+0x343e): Section mismatch: reference to .init.text:start_kernel (between 'start_here' and 'set_context')
WARNING: vmlinux.o(.text+0x3442): Section mismatch: reference to .init.text:start_kernel (between 'start_here' and 'set_context')

   GEN     .version
   CHK     include/linux/compile.h
   UPD     include/linux/compile.h
   CC      init/version.o
   LD      init/built-in.o
   LD      vmlinux
   SYSMAP  System.map
   BOOTAS  arch/powerpc/boot/string.o
   BOOTAS  arch/powerpc/boot/crt0.o
   BOOTCC  arch/powerpc/boot/stdio.o
   BOOTCC  arch/powerpc/boot/main.o
   BOOTCC  arch/powerpc/boot/flatdevtree.o
   BOOTCC  arch/powerpc/boot/flatdevtree_misc.o
   BOOTCC  arch/powerpc/boot/ns16550.o
   BOOTCC  arch/powerpc/boot/serial.o
   BOOTCC  arch/powerpc/boot/simple_alloc.o
   BOOTAS  arch/powerpc/boot/div64.o
   BOOTAS  arch/powerpc/boot/util.o
   BOOTCC  arch/powerpc/boot/gunzip_util.o
   BOOTCC  arch/powerpc/boot/elf_util.o
   BOOTCC  arch/powerpc/boot/inffast.o
   BOOTCC  arch/powerpc/boot/inflate.o
   BOOTCC  arch/powerpc/boot/inftrees.o
   BOOTCC  arch/powerpc/boot/devtree.o
   BOOTCC  arch/powerpc/boot/oflib.o
   BOOTCC  arch/powerpc/boot/ofconsole.o
   BOOTCC  arch/powerpc/boot/4xx.o
   BOOTCC  arch/powerpc/boot/ebony.o
   BOOTCC  arch/powerpc/boot/mv64x60.o
   BOOTCC  arch/powerpc/boot/mpsc.o
   BOOTCC  arch/powerpc/boot/mv64x60_i2c.o
   BOOTCC  arch/powerpc/boot/cuboot.o
   BOOTCC  arch/powerpc/boot/bamboo.o
   BOOTAR  arch/powerpc/boot/wrapper.a
   BOOTCC  arch/powerpc/boot/of.o
   BOOTCC  arch/powerpc/boot/cuboot-83xx.o
   BOOTCC  arch/powerpc/boot/cuboot-85xx.o
   BOOTCC  arch/powerpc/boot/holly.o
   BOOTCC  arch/powerpc/boot/cuboot-ebony.o
   BOOTCC  arch/powerpc/boot/treeboot-ebony.o
   BOOTCC  arch/powerpc/boot/prpmc2800.o
   BOOTAS  arch/powerpc/boot/ps3-head.o
   BOOTAS  arch/powerpc/boot/ps3-hvcall.o
   BOOTCC  arch/powerpc/boot/ps3.o
   BOOTCC  arch/powerpc/boot/treeboot-bamboo.o
   BOOTCC  arch/powerpc/boot/cuboot-sequoia.o
   BOOTCC  arch/powerpc/boot/treeboot-walnut.o

{standard input}: Assembler messages:
{standard input}:184: Error: Unrecognized opcode: mfdcr' {standard input}:185: Error: Unrecognized opcode: mfdcr' {standard input}:186: Error: Unrecognized opcode: mfdcr' {standard input}:217: Error: Unrecognized opcode: mtdcr' make[1]: *** [arch/powerpc/boot/treeboot-walnut.o] Error 1
make: *** [uImage] Error 2

Quoted 1 line

It looks like the ppc_6xx toolchain does not know the opcode above. I wonder why files for other PowerPC sub-archs like 4xx are compiled with the wrong compiler. Have I missed something?

No, you haven't missed anything. I need a one line patch to fix it. Could you try the patch below to make sure it works for you?

Quoted 2 lines

And the WARNING above on "Section mismatch" looks strange as well (still present in 2.6.23-rc7).

Those warnings should be gone with Paul's latest tree. (They will remain for 2.6.23.)

Pass the correct -mcpu option for treeboot-walnut.o to avoid unrecognized opcodes.

Signed-off-by Josh Boyer <[email protected]>

arch/powerpc/boot/Makefile +0 -0

index c1582b6..8e6d36b 100644

Quoted 73 lines · Josh Boyer

Quoted 71 lines · On Mon, 24 Sep 2007 09:49:33 +0200 Wolfgang Grandegger <[email protected]>…

The addition of treeboot-walnut.c breaks compilation of Linux-2.6 for the lite5200 using the ppc_6xx toolchain of the ELDK 4.1:

MODPOST vmlinux.o
WARNING: vmlinux.o(.text+0x14): Section mismatch: reference to .init.text:prom_init (between '__start' and '__after_mmu_off')
WARNING: vmlinux.o(.text+0x28): Section mismatch: reference to .init.text:early_init (between '__start' and '__after_mmu_off')
WARNING: vmlinux.o(.text+0x340c): Section mismatch: reference to .init.text:machine_init (between 'start_here' and 'set_context')
WARNING: vmlinux.o(.text+0x3414): Section mismatch: reference to .init.text:MMU_init (between 'start_here' and 'set_context')
WARNING: vmlinux.o(.text+0x343e): Section mismatch: reference to .init.text:start_kernel (between 'start_here' and 'set_context')
WARNING: vmlinux.o(.text+0x3442): Section mismatch: reference to .init.text:start_kernel (between 'start_here' and 'set_context')

   GEN     .version
   CHK     include/linux/compile.h
   UPD     include/linux/compile.h
   CC      init/version.o
   LD      init/built-in.o
   LD      vmlinux
   SYSMAP  System.map
   BOOTAS  arch/powerpc/boot/string.o
   BOOTAS  arch/powerpc/boot/crt0.o
   BOOTCC  arch/powerpc/boot/stdio.o
   BOOTCC  arch/powerpc/boot/main.o
   BOOTCC  arch/powerpc/boot/flatdevtree.o
   BOOTCC  arch/powerpc/boot/flatdevtree_misc.o
   BOOTCC  arch/powerpc/boot/ns16550.o
   BOOTCC  arch/powerpc/boot/serial.o
   BOOTCC  arch/powerpc/boot/simple_alloc.o
   BOOTAS  arch/powerpc/boot/div64.o
   BOOTAS  arch/powerpc/boot/util.o
   BOOTCC  arch/powerpc/boot/gunzip_util.o
   BOOTCC  arch/powerpc/boot/elf_util.o
   BOOTCC  arch/powerpc/boot/inffast.o
   BOOTCC  arch/powerpc/boot/inflate.o
   BOOTCC  arch/powerpc/boot/inftrees.o
   BOOTCC  arch/powerpc/boot/devtree.o
   BOOTCC  arch/powerpc/boot/oflib.o
   BOOTCC  arch/powerpc/boot/ofconsole.o
   BOOTCC  arch/powerpc/boot/4xx.o
   BOOTCC  arch/powerpc/boot/ebony.o
   BOOTCC  arch/powerpc/boot/mv64x60.o
   BOOTCC  arch/powerpc/boot/mpsc.o
   BOOTCC  arch/powerpc/boot/mv64x60_i2c.o
   BOOTCC  arch/powerpc/boot/cuboot.o
   BOOTCC  arch/powerpc/boot/bamboo.o
   BOOTAR  arch/powerpc/boot/wrapper.a
   BOOTCC  arch/powerpc/boot/of.o
   BOOTCC  arch/powerpc/boot/cuboot-83xx.o
   BOOTCC  arch/powerpc/boot/cuboot-85xx.o
   BOOTCC  arch/powerpc/boot/holly.o
   BOOTCC  arch/powerpc/boot/cuboot-ebony.o
   BOOTCC  arch/powerpc/boot/treeboot-ebony.o
   BOOTCC  arch/powerpc/boot/prpmc2800.o
   BOOTAS  arch/powerpc/boot/ps3-head.o
   BOOTAS  arch/powerpc/boot/ps3-hvcall.o
   BOOTCC  arch/powerpc/boot/ps3.o
   BOOTCC  arch/powerpc/boot/treeboot-bamboo.o
   BOOTCC  arch/powerpc/boot/cuboot-sequoia.o
   BOOTCC  arch/powerpc/boot/treeboot-walnut.o

{standard input}: Assembler messages:
{standard input}:184: Error: Unrecognized opcode: mfdcr' {standard input}:185: Error: Unrecognized opcode: mfdcr' {standard input}:186: Error: Unrecognized opcode: mfdcr' {standard input}:217: Error: Unrecognized opcode: mtdcr' make[1]: *** [arch/powerpc/boot/treeboot-walnut.o] Error 1
make: *** [uImage] Error 2

Quoted 6 lines

Quoted 3 lines

It looks like the ppc_6xx toolchain does not know the opcode above. I wonder why files for other PowerPC sub-archs like 4xx are compiled with the wrong compiler. Have I missed something?

No, you haven't missed anything. I need a one line patch to fix it. Could you try the patch below to make sure it works for you?

It works for me with one typo corrected (see below).