net: myri10ge: force select inet_lro
PATCH 1/1 net: myri10ge: force select inet_lro
This driver uses the inet_lro facilities , but it doesn't force it to be enabled .. Someone would have to know to enable inet_lro if they select the driver ..
Instead, just force INET_LRO if this driver is selected..
--- drivers/net/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/net/Kconfig +1 -0
@@ -2103,6 +2103,7 @@ source "drivers/net/ixp2000/Kconfig" config MYRI_SBUS tristate "MyriCOM Gigabit Ethernet support" depends on SBUS + select INET_LRO help This driver supports MyriCOM Sbus gigabit Ethernet cards.
Signature · 1 line
--
David Miller
maintainerFrom: Daniel Walker <[email protected]>
Date: Fri, 07 Sep 2007 13:26:25 -0700
Quoted 7 lines
This driver uses the
inet_lrofacilities , but it doesn't force it to be enabled .. Someone would have to know to enableinet_lroif they select the driver ..Instead, just force
INET_LROif this driver is selected..Signed-off-by Daniel Walker <[email protected]>
I put this exact fix into the net-2.6.24 tree several days ago already, it's not nice that you didn't even bother checking.
When I saw the response to the help@ address, I could almost predict that the myri10ge developers would not even check if net-2.6.24 had the issue cured already.
Therefore, your patch doesn't even apply to the tree where it is relevant. That sucks.
Quoted 7 lines · David Miller
From: Daniel Walker <[email protected]>
Date: Fri, 07 Sep 2007 13:26:25 -0700Quoted 4 lines
This driver uses the
inet_lrofacilities , but it doesn't force it to be enabled .. Someone would have to know to enableinet_lroif they select the driver ..
Quoted 6 lines
Quoted 3 lines
Instead, just force
INET_LROif this driver is selected..Signed-off-by Daniel Walker <[email protected]>I put this exact fix into the net-2.6.24 tree several days ago already, it's not nice that you didn't even bother checking.
Sorry..
Quoted 6 lines
When I saw the response to the help@ address, I could almost predict that the myri10ge developers would not even check if net-2.6.24 had the issue cured already.
Therefore, your patch doesn't even apply to the tree where it is relevant. That sucks.
Not sure what the help@ address is ? I'm just trying to fix problems I find .. This problem is in -mm which is what I was using. The driver is pretty obscure, and I just assumed not many people would be building it. So I didn't check for fixes in git ..
Did your fix go to LKML ?
Daniel
David Miller
maintainerFrom: Daniel Walker <[email protected]>
Date: Sat, 08 Sep 2007 09:03:06 -0700
Quoted 1 line
Did your fix go to LKML ?
I don't remember exactly.