Skip to contentSkip to conversation

: Update pkt_sched.h (to resemble the kernel one)

PATCH In review Jesper Dangaard Brouer 2 participants 2 messages Sep 12, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 3/6 : Update pkt_sched.h (to resemble the kernel one)

commit ef065a43b8900fbc0763eac0fa0a9a8a00c8aaa2

Author: Jesper Dangaard Brouer <[email protected]>
Date:   Tue Sep 11 16:17:46 2007 +0200

[IPROUTE2]: Update pkt_sched.h (to resemble the kernel one)

Extend the tc_ratespec struct, with two parameters: 1) "cell_align" that allow adjusting the alignment of the rate table. 2) "overhead" that allow adding a packet overhead before the lookup in the kernel.

This is done in order to, add support to changing the rate table to use the upper-boundry L2T (length to time) value. Currently we use the lower-boundry, which result in under-estimating the actual bandwidth usage.

include/linux/pkt_sched.h +2 -2
index 268c515..919af93 100644
@@ -77,8 +77,8 @@ struct tc_ratespec
 {
 	unsigned char	cell_log;
 	unsigned char	__reserved;
-	unsigned short	feature;
-	short		addend;
+	unsigned short	overhead;
+	short		cell_align;
 	unsigned short	mpu;
 	__u32		rate;
 };
#1 lore raw
Quoted 10 lines · On Wed, 12 Sep 2007 12:14:14 +0200 Jesper Dangaard Brouer <[email protected]> wrote:

commit ef065a43b8900fbc0763eac0fa0a9a8a00c8aaa2

Author: Jesper Dangaard Brouer <[email protected]>
Date:   Tue Sep 11 16:17:46 2007 +0200

[IPROUTE2]: Update pkt_sched.h (to resemble the kernel one)

Extend the tc_ratespec struct, with two parameters: 1) "cell_align" that allow adjusting the alignment of the rate table. 2) "overhead" that allow adding a packet overhead before the lookup in the kernel.

Quoted 7 lines

This is done in order to, add support to changing the rate table to use the upper-boundry L2T (length to time) value. Currently we use the lower-boundry, which result in under-estimating the actual bandwidth usage.

Okay, but don't need a special patch to do it. I perodically sync up the headers before each release.