5.0.0_beta1: uncomment "-f --foreground..." help text; comment out unused stuff.
PATCH 1/1 5.0.0_beta1: uncomment "-f --foreground..." help text; comment out unused stuff.
Hi Ian,
Please apply attached trivial patch. It is run-tested. --
vda
daemon/automount.c +4 -1
@@ -413,6 +413,7 @@ int count_mounts(struct autofs_point *apreturn counter.count; } +/* UNUSED static void check_rm_dirs(struct autofs_point *ap, const char *path, int incl) { if ((!ap->ghost) ||
@@ -423,6 +424,7 @@ static void check_rm_dirs(struct autofs_else if (ap->ghost && (ap->type == LKP_INDIRECT)) rm_unwanted(path, 0, ap->dev); } +*/ /* umount all filesystems mounted under path. If incl is true, then it also tries to umount path itself */
@@ -717,6 +719,7 @@ static int handle_packet(struct autofs_preturn -1 ; } +static void become_daemon (unsigned foreground) {FILE *pidfp;
@@ -1278,7 +1281,7 @@ static void usage(void)" -t --timeout n auto-unmount in n seconds (0-disable)\n" " -v --verbose be verbose\n" " -d --debug log debuging info\n" -/*" -f --foreground do not fork into background\n" */ +" -f --foreground do not fork into background\n" " -V --version print version and exit\n" , program); }
daemon/direct.c +2 -1
@@ -213,7 +213,8 @@ int umount_autofs_direct(struct autofs_pstatic int unlink_mount_tree (struct list_head *list,const char *mount) {struct list_head *p; -int rv, ret, need_umount; +int rv, ret; +/* int need_umount; */ pid_t pgrp =getpgrp ();char spgrp[10 ];/*
_______________________________________________
autofs mailing list
[email protected]
http://linux.kernel.org/mailman/listinfo/autofs
PATCH 1/1 5.0.0_beta1: add "-s --stderr" option
Hi Ian,
I see that almost everything is in place for this to work, only actual option handling is missing.
I added it and it works (run-tested).
Please apply attached patch
(should apply on top of autofs-5.0.0_beta1-fg.patch). --
vda
daemon/automount.c +8 -2
@@ -719,12 +719,12 @@ static int handle_packet(struct autofs_preturn -1 ; } +static unsigned char to_stderr;static void become_daemon (unsigned foreground) {FILE *pidfp;char buf[MAX_ERR_BUF ]; -unsigned to_stderr =0 ;pid_t pid;/* Don't BUSY any directories unnecessarily */
@@ -1282,6 +1282,7 @@ static void usage(void)" -v --verbose be verbose\n" " -d --debug log debuging info\n" " -f --foreground do not fork into background\n" +" -s --stderr log to stderr instead of syslog\n" " -V --version print version and exit\n" , program); }
@@ -1302,6 +1303,7 @@ int main(int argc, char *argv[]) {"verbose", 0, 0, 'v'}, {"debug", 0, 0, 'd'}, {"foreground", 0, 0, 'f'}, + {"stderr", 0, 0, 's'}, {"version", 0, 0, 'V'}, {0, 0, 0, 0} };
@@ -1318,7 +1320,7 @@ int main(int argc, char *argv[]) foreground =0 ; opterr =0 ; -while ((opt =getopt_long (argc, argv,"+hp:t:vdfV" , long_options,NULL )) !=EOF ) { +while ((opt =getopt_long (argc, argv,"+hp:t:vdfsV" , long_options,NULL )) !=EOF ) {switch (opt) {case 'h' :usage ();
@@ -1344,6 +1346,10 @@ int main(int argc, char *argv[]) foreground =1 ;break ; +case 's' : + to_stderr =1 ; +break ; +case 'V' :printf ("Linux automount version %s\n" , version);exit (0 );
_______________________________________________
autofs mailing list
[email protected]
http://linux.kernel.org/mailman/listinfo/autofs
Ian Kent
maintainerQuoted 3 lines · Denys Vlasenko
Hi Ian,
Please apply attached trivial patch. It is run-tested.
Sorry I'm so late with this Denys but please look at commit
http://git.kernel.org/?p=linux/storage/autofs/autofs.git;a=commitdiff;h=4bfe89a5c214859eb07ad1aa7e4481d470a5bb3f
I think this will cover the foreground logging issues you're having. The patch is also in the usual place on kernel.org.
Ian