Skip to contentSkip to conversation

linux-2.6.23-git3: Many sysfs-related warnings in dmesg

DISCUSSION Rafael J. Wysocki 5 participants 21 messages Oct 13, 2007 – Oct 25, 2007

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Hi,

There are many traces like this in my dmesg from 2.6.23-git3 (they don't appear for vanilla 2.6.23):

<4>sysfs: duplicate filename 'ethxx1' can not be created

WARNING: at /home/rafael/src/linux-2.6/fs/sysfs/dir.c:425 sysfs_add_one()

Call Trace:
 [<ffffffff802d1532>] sysfs_add_one+0x5c/0xc9
 [<ffffffff802d2411>] sysfs_create_link+0xd1/0x12c
 [<ffffffff803756da>] device_rename+0x17a/0x1db
 [<ffffffff803c903d>] dev_change_name+0x114/0x20c
 [<ffffffff803c9339>] dev_ifsioc+0x204/0x2d0
 [<ffffffff803c9925>] dev_ioctl+0x520/0x633
 [<ffffffff803bf445>] sk_alloc+0x37/0x10c
 [<ffffffff8024b977>] up_read+0x9/0xb
 [<ffffffff803bc65e>] sock_ioctl+0x1fe/0x20c
 [<ffffffff8029b34a>] do_ioctl+0x2a/0x77
 [<ffffffff8029b5e8>] vfs_ioctl+0x251/0x26e
 [<ffffffff8029b664>] sys_ioctl+0x5f/0x83
 [<ffffffff8020bd4e>] system_call+0x7e/0x83

net ethxx1: device_rename: sysfs_create_symlink failed (-17)
sysfs: duplicate filename 'eth1' can not be created

Everything seems to work, but this just looks fishy.

I reported it for at least one -mm of the recent -mm kernels, but no one responded.

Greetings,
Rafael

#1 lore raw
Quoted 23 lines · Rafael J. Wysocki

Hi,

There are many traces like this in my dmesg from 2.6.23-git3 (they don't appear for vanilla 2.6.23):

<4>sysfs: duplicate filename 'ethxx1' can not be created

WARNING: at /home/rafael/src/linux-2.6/fs/sysfs/dir.c:425 sysfs_add_one()

Call Trace:
 [<ffffffff802d1532>] sysfs_add_one+0x5c/0xc9
 [<ffffffff802d2411>] sysfs_create_link+0xd1/0x12c
 [<ffffffff803756da>] device_rename+0x17a/0x1db
 [<ffffffff803c903d>] dev_change_name+0x114/0x20c
 [<ffffffff803c9339>] dev_ifsioc+0x204/0x2d0
 [<ffffffff803c9925>] dev_ioctl+0x520/0x633
 [<ffffffff803bf445>] sk_alloc+0x37/0x10c
 [<ffffffff8024b977>] up_read+0x9/0xb
 [<ffffffff803bc65e>] sock_ioctl+0x1fe/0x20c
 [<ffffffff8029b34a>] do_ioctl+0x2a/0x77
 [<ffffffff8029b5e8>] vfs_ioctl+0x251/0x26e
 [<ffffffff8029b664>] sys_ioctl+0x5f/0x83
 [<ffffffff8020bd4e>] system_call+0x7e/0x83
Quoted 4 lines

net ethxx1: device_rename: sysfs_create_symlink failed (-17)
sysfs: duplicate filename 'eth1' can not be created

Everything seems to work, but this just looks fishy.

This is a userspace program renaming your network device to a name that is already in use. What distro and release is this?

thanks,

greg k-h

#2 lore raw
Quoted 24 lines · Greg KH
Quoted 23 lines · Rafael J. Wysocki

Hi,

There are many traces like this in my dmesg from 2.6.23-git3 (they don't appear for vanilla 2.6.23):

<4>sysfs: duplicate filename 'ethxx1' can not be created

WARNING: at /home/rafael/src/linux-2.6/fs/sysfs/dir.c:425 sysfs_add_one()

Call Trace:
 [<ffffffff802d1532>] sysfs_add_one+0x5c/0xc9
 [<ffffffff802d2411>] sysfs_create_link+0xd1/0x12c
 [<ffffffff803756da>] device_rename+0x17a/0x1db
 [<ffffffff803c903d>] dev_change_name+0x114/0x20c
 [<ffffffff803c9339>] dev_ifsioc+0x204/0x2d0
 [<ffffffff803c9925>] dev_ioctl+0x520/0x633
 [<ffffffff803bf445>] sk_alloc+0x37/0x10c
 [<ffffffff8024b977>] up_read+0x9/0xb
 [<ffffffff803bc65e>] sock_ioctl+0x1fe/0x20c
 [<ffffffff8029b34a>] do_ioctl+0x2a/0x77
 [<ffffffff8029b5e8>] vfs_ioctl+0x251/0x26e
 [<ffffffff8029b664>] sys_ioctl+0x5f/0x83
 [<ffffffff8020bd4e>] system_call+0x7e/0x83
Quoted 7 lines
Quoted 4 lines

net ethxx1: device_rename: sysfs_create_symlink failed (-17)
sysfs: duplicate filename 'eth1' can not be created

Everything seems to work, but this just looks fishy.

This is a userspace program renaming your network device to a name that is already in use. What distro and release is this?

openSUSE 10.2, with some updates (not the most recent, though).

Greetings,
Rafael

#3 lore raw
Quoted 28 lines · Rafael J. Wysocki
Quoted 27 lines · Greg KH
Quoted 26 lines · Rafael J. Wysocki

Hi,

There are many traces like this in my dmesg from 2.6.23-git3 (they don't appear for vanilla 2.6.23):

<4>sysfs: duplicate filename 'ethxx1' can not be created

WARNING: at /home/rafael/src/linux-2.6/fs/sysfs/dir.c:425 sysfs_add_one()

Call Trace:
 [<ffffffff802d1532>] sysfs_add_one+0x5c/0xc9
 [<ffffffff802d2411>] sysfs_create_link+0xd1/0x12c
 [<ffffffff803756da>] device_rename+0x17a/0x1db
 [<ffffffff803c903d>] dev_change_name+0x114/0x20c
 [<ffffffff803c9339>] dev_ifsioc+0x204/0x2d0
 [<ffffffff803c9925>] dev_ioctl+0x520/0x633
 [<ffffffff803bf445>] sk_alloc+0x37/0x10c
 [<ffffffff8024b977>] up_read+0x9/0xb
 [<ffffffff803bc65e>] sock_ioctl+0x1fe/0x20c
 [<ffffffff8029b34a>] do_ioctl+0x2a/0x77
 [<ffffffff8029b5e8>] vfs_ioctl+0x251/0x26e
 [<ffffffff8029b664>] sys_ioctl+0x5f/0x83
 [<ffffffff8020bd4e>] system_call+0x7e/0x83

net ethxx1: device_rename: sysfs_create_symlink failed (-17)
sysfs: duplicate filename 'eth1' can not be created

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Everything seems to work, but this just looks fishy.

This is a userspace program renaming your network device to a name that is already in use. What distro and release is this?

openSUSE 10.2, with some updates (not the most recent, though).

Can you try 10.3? I think we fixed this issue there.

thanks,

greg k-h

#4 lore raw
Quoted 29 lines · Greg KH
Quoted 28 lines · Rafael J. Wysocki
Quoted 27 lines · Greg KH
Quoted 26 lines · Rafael J. Wysocki

Hi,

There are many traces like this in my dmesg from 2.6.23-git3 (they don't appear for vanilla 2.6.23):

<4>sysfs: duplicate filename 'ethxx1' can not be created

WARNING: at /home/rafael/src/linux-2.6/fs/sysfs/dir.c:425 sysfs_add_one()

Call Trace:
 [<ffffffff802d1532>] sysfs_add_one+0x5c/0xc9
 [<ffffffff802d2411>] sysfs_create_link+0xd1/0x12c
 [<ffffffff803756da>] device_rename+0x17a/0x1db
 [<ffffffff803c903d>] dev_change_name+0x114/0x20c
 [<ffffffff803c9339>] dev_ifsioc+0x204/0x2d0
 [<ffffffff803c9925>] dev_ioctl+0x520/0x633
 [<ffffffff803bf445>] sk_alloc+0x37/0x10c
 [<ffffffff8024b977>] up_read+0x9/0xb
 [<ffffffff803bc65e>] sock_ioctl+0x1fe/0x20c
 [<ffffffff8029b34a>] do_ioctl+0x2a/0x77
 [<ffffffff8029b5e8>] vfs_ioctl+0x251/0x26e
 [<ffffffff8029b664>] sys_ioctl+0x5f/0x83
 [<ffffffff8020bd4e>] system_call+0x7e/0x83

net ethxx1: device_rename: sysfs_create_symlink failed (-17)
sysfs: duplicate filename 'eth1' can not be created

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Everything seems to work, but this just looks fishy.

This is a userspace program renaming your network device to a name that is already in use. What distro and release is this?

openSUSE 10.2, with some updates (not the most recent, though).

Can you try 10.3? I think we fixed this issue there.

Ehm nope:

Oct 16 19:36:27 carl kernel: sysfs: duplicate filename 'wlan0_rename'
can not be created
Oct 16 19:36:27 carl kernel: udev: renamed network interface wmaster0 to
eth1
Oct 16 19:36:27 carl kernel: WARNING: at fs/sysfs/dir.c:425
sysfs_add_one()
Oct 16 19:36:27 carl kernel:  [<c01b2dbf>] sysfs_add_one+0x9f/0xe0
Oct 16 19:36:27 carl kernel:  [<c01b3b76>] sysfs_create_link+0x86/0x110
Oct 16 19:36:27 carl kernel:  [<c02398ca>] device_rename+0x17a/0x1e0
Oct 16 19:36:27 carl kernel:  [<c015b56f>] filemap_fault+0x1ff/0x400
Oct 16 19:36:27 carl kernel:  [<c02b8fc0>] dev_change_name+0xb0/0x210
Oct 16 19:36:27 carl kernel:  [<c02b9779>] dev_ioctl+0x3c9/0x530
Oct 16 19:36:27 carl kernel:  [<c01a1938>]
inotify_d_instantiate+0x18/0x80
Oct 16 19:36:27 carl kernel:  [<c0120044>] do_page_fault+0x4a4/0x6f0
Oct 16 19:36:27 carl kernel:  [<c02ac080>] sock_ioctl+0x0/0x220
Oct 16 19:36:27 carl kernel:  [<c01851ab>] do_ioctl+0x2b/0x90
Oct 16 19:36:27 carl kernel:  [<c02ad50b>] sys_socket+0x2b/0x50
Oct 16 19:36:27 carl kernel:  [<c018542e>] vfs_ioctl+0x21e/0x2a0
Oct 16 19:36:27 carl kernel:  [<c01854ed>] sys_ioctl+0x3d/0x70
Oct 16 19:36:27 carl kernel:  [<c01042d6>] sysenter_past_esp+0x6b/0xa1
Oct 16 19:36:27 carl kernel:  =======================
Oct 16 19:36:27 carl kernel: net wlan0_rename: device_rename:

sysfs_create_symlink failed (-17)

Signature · 1 line
Jens Axboe
#5 lore raw
Quoted 64 lines · Jens Axboe
Quoted 29 lines · Greg KH
Quoted 28 lines · Rafael J. Wysocki
Quoted 27 lines · Greg KH
Quoted 26 lines · Rafael J. Wysocki

Hi,

There are many traces like this in my dmesg from 2.6.23-git3 (they don't appear for vanilla 2.6.23):

<4>sysfs: duplicate filename 'ethxx1' can not be created

WARNING: at /home/rafael/src/linux-2.6/fs/sysfs/dir.c:425 sysfs_add_one()

Call Trace:
 [<ffffffff802d1532>] sysfs_add_one+0x5c/0xc9
 [<ffffffff802d2411>] sysfs_create_link+0xd1/0x12c
 [<ffffffff803756da>] device_rename+0x17a/0x1db
 [<ffffffff803c903d>] dev_change_name+0x114/0x20c
 [<ffffffff803c9339>] dev_ifsioc+0x204/0x2d0
 [<ffffffff803c9925>] dev_ioctl+0x520/0x633
 [<ffffffff803bf445>] sk_alloc+0x37/0x10c
 [<ffffffff8024b977>] up_read+0x9/0xb
 [<ffffffff803bc65e>] sock_ioctl+0x1fe/0x20c
 [<ffffffff8029b34a>] do_ioctl+0x2a/0x77
 [<ffffffff8029b5e8>] vfs_ioctl+0x251/0x26e
 [<ffffffff8029b664>] sys_ioctl+0x5f/0x83
 [<ffffffff8020bd4e>] system_call+0x7e/0x83

net ethxx1: device_rename: sysfs_create_symlink failed (-17)
sysfs: duplicate filename 'eth1' can not be created

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Everything seems to work, but this just looks fishy.

This is a userspace program renaming your network device to a name that is already in use. What distro and release is this?

openSUSE 10.2, with some updates (not the most recent, though).

Can you try 10.3? I think we fixed this issue there.

Ehm nope:

Oct 16 19:36:27 carl kernel: sysfs: duplicate filename 'wlan0_rename'
can not be created
Oct 16 19:36:27 carl kernel: udev: renamed network interface wmaster0 to
eth1
Oct 16 19:36:27 carl kernel: WARNING: at fs/sysfs/dir.c:425
sysfs_add_one()
Oct 16 19:36:27 carl kernel:  [<c01b2dbf>] sysfs_add_one+0x9f/0xe0
Oct 16 19:36:27 carl kernel:  [<c01b3b76>] sysfs_create_link+0x86/0x110
Oct 16 19:36:27 carl kernel:  [<c02398ca>] device_rename+0x17a/0x1e0
Oct 16 19:36:27 carl kernel:  [<c015b56f>] filemap_fault+0x1ff/0x400
Oct 16 19:36:27 carl kernel:  [<c02b8fc0>] dev_change_name+0xb0/0x210
Oct 16 19:36:27 carl kernel:  [<c02b9779>] dev_ioctl+0x3c9/0x530
Oct 16 19:36:27 carl kernel:  [<c01a1938>]
inotify_d_instantiate+0x18/0x80
Oct 16 19:36:27 carl kernel:  [<c0120044>] do_page_fault+0x4a4/0x6f0
Oct 16 19:36:27 carl kernel:  [<c02ac080>] sock_ioctl+0x0/0x220
Oct 16 19:36:27 carl kernel:  [<c01851ab>] do_ioctl+0x2b/0x90
Oct 16 19:36:27 carl kernel:  [<c02ad50b>] sys_socket+0x2b/0x50
Oct 16 19:36:27 carl kernel:  [<c018542e>] vfs_ioctl+0x21e/0x2a0
Oct 16 19:36:27 carl kernel:  [<c01854ed>] sys_ioctl+0x3d/0x70
Oct 16 19:36:27 carl kernel:  [<c01042d6>] sysenter_past_esp+0x6b/0xa1
Oct 16 19:36:27 carl kernel:  =======================
Oct 16 19:36:27 carl kernel: net wlan0_rename: device_rename:
Quoted 1 line

sysfs_create_symlink failed (-17)

Plus it doesn't happen on 2.6.23 on my system, so I count it as a regression.

Greetings,
Rafael

#6 lore raw
Quoted 67 lines · Rafael J. Wysocki
Quoted 64 lines · Jens Axboe
Quoted 29 lines · Greg KH
Quoted 28 lines · Rafael J. Wysocki
Quoted 27 lines · Greg KH
Quoted 26 lines · Rafael J. Wysocki

Hi,

There are many traces like this in my dmesg from 2.6.23-git3 (they don't appear for vanilla 2.6.23):

<4>sysfs: duplicate filename 'ethxx1' can not be created

WARNING: at /home/rafael/src/linux-2.6/fs/sysfs/dir.c:425 sysfs_add_one()

Call Trace:
 [<ffffffff802d1532>] sysfs_add_one+0x5c/0xc9
 [<ffffffff802d2411>] sysfs_create_link+0xd1/0x12c
 [<ffffffff803756da>] device_rename+0x17a/0x1db
 [<ffffffff803c903d>] dev_change_name+0x114/0x20c
 [<ffffffff803c9339>] dev_ifsioc+0x204/0x2d0
 [<ffffffff803c9925>] dev_ioctl+0x520/0x633
 [<ffffffff803bf445>] sk_alloc+0x37/0x10c
 [<ffffffff8024b977>] up_read+0x9/0xb
 [<ffffffff803bc65e>] sock_ioctl+0x1fe/0x20c
 [<ffffffff8029b34a>] do_ioctl+0x2a/0x77
 [<ffffffff8029b5e8>] vfs_ioctl+0x251/0x26e
 [<ffffffff8029b664>] sys_ioctl+0x5f/0x83
 [<ffffffff8020bd4e>] system_call+0x7e/0x83

net ethxx1: device_rename: sysfs_create_symlink failed (-17)
sysfs: duplicate filename 'eth1' can not be created

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Everything seems to work, but this just looks fishy.

This is a userspace program renaming your network device to a name that is already in use. What distro and release is this?

openSUSE 10.2, with some updates (not the most recent, though).

Can you try 10.3? I think we fixed this issue there.

Ehm nope:

Oct 16 19:36:27 carl kernel: sysfs: duplicate filename 'wlan0_rename'
can not be created
Oct 16 19:36:27 carl kernel: udev: renamed network interface wmaster0 to
eth1
Oct 16 19:36:27 carl kernel: WARNING: at fs/sysfs/dir.c:425
sysfs_add_one()
Oct 16 19:36:27 carl kernel:  [<c01b2dbf>] sysfs_add_one+0x9f/0xe0
Oct 16 19:36:27 carl kernel:  [<c01b3b76>] sysfs_create_link+0x86/0x110
Oct 16 19:36:27 carl kernel:  [<c02398ca>] device_rename+0x17a/0x1e0
Oct 16 19:36:27 carl kernel:  [<c015b56f>] filemap_fault+0x1ff/0x400
Oct 16 19:36:27 carl kernel:  [<c02b8fc0>] dev_change_name+0xb0/0x210
Oct 16 19:36:27 carl kernel:  [<c02b9779>] dev_ioctl+0x3c9/0x530
Oct 16 19:36:27 carl kernel:  [<c01a1938>]
inotify_d_instantiate+0x18/0x80
Oct 16 19:36:27 carl kernel:  [<c0120044>] do_page_fault+0x4a4/0x6f0
Oct 16 19:36:27 carl kernel:  [<c02ac080>] sock_ioctl+0x0/0x220
Oct 16 19:36:27 carl kernel:  [<c01851ab>] do_ioctl+0x2b/0x90
Oct 16 19:36:27 carl kernel:  [<c02ad50b>] sys_socket+0x2b/0x50
Oct 16 19:36:27 carl kernel:  [<c018542e>] vfs_ioctl+0x21e/0x2a0
Oct 16 19:36:27 carl kernel:  [<c01854ed>] sys_ioctl+0x3d/0x70
Oct 16 19:36:27 carl kernel:  [<c01042d6>] sysenter_past_esp+0x6b/0xa1
Oct 16 19:36:27 carl kernel:  =======================
Oct 16 19:36:27 carl kernel: net wlan0_rename: device_rename:
Quoted 1 line

sysfs_create_symlink failed (-17)

Quoted 1 line

Plus it doesn't happen on 2.6.23 on my system, so I count it as a regression.

It's a new warning I've added to the kernel to catch stupid userspace and kernel code that is quietly failing when they are doing things incorrectly with kobjects and sysfs.

So it's not really a "regression" in that we never notified anyone of this kind of thing before, think of it as a new feature :)

thanks,

greg k-h

#7 lore raw
Quoted 68 lines · Greg KH
Quoted 67 lines · Rafael J. Wysocki
Quoted 65 lines · Jens Axboe
Quoted 29 lines · Greg KH
Quoted 28 lines · Rafael J. Wysocki
Quoted 27 lines · Greg KH
Quoted 26 lines · Rafael J. Wysocki

Hi,

There are many traces like this in my dmesg from 2.6.23-git3 (they don't appear for vanilla 2.6.23):

<4>sysfs: duplicate filename 'ethxx1' can not be created

WARNING: at /home/rafael/src/linux-2.6/fs/sysfs/dir.c:425 sysfs_add_one()

Call Trace:
 [<ffffffff802d1532>] sysfs_add_one+0x5c/0xc9
 [<ffffffff802d2411>] sysfs_create_link+0xd1/0x12c
 [<ffffffff803756da>] device_rename+0x17a/0x1db
 [<ffffffff803c903d>] dev_change_name+0x114/0x20c
 [<ffffffff803c9339>] dev_ifsioc+0x204/0x2d0
 [<ffffffff803c9925>] dev_ioctl+0x520/0x633
 [<ffffffff803bf445>] sk_alloc+0x37/0x10c
 [<ffffffff8024b977>] up_read+0x9/0xb
 [<ffffffff803bc65e>] sock_ioctl+0x1fe/0x20c
 [<ffffffff8029b34a>] do_ioctl+0x2a/0x77
 [<ffffffff8029b5e8>] vfs_ioctl+0x251/0x26e
 [<ffffffff8029b664>] sys_ioctl+0x5f/0x83
 [<ffffffff8020bd4e>] system_call+0x7e/0x83

net ethxx1: device_rename: sysfs_create_symlink failed (-17)
sysfs: duplicate filename 'eth1' can not be created

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Everything seems to work, but this just looks fishy.

This is a userspace program renaming your network device to a name that is already in use. What distro and release is this?

openSUSE 10.2, with some updates (not the most recent, though).

Can you try 10.3? I think we fixed this issue there.

Ehm nope:

Oct 16 19:36:27 carl kernel: sysfs: duplicate filename 'wlan0_rename'
can not be created
Oct 16 19:36:27 carl kernel: udev: renamed network interface wmaster0 to
eth1
Oct 16 19:36:27 carl kernel: WARNING: at fs/sysfs/dir.c:425
sysfs_add_one()
Oct 16 19:36:27 carl kernel:  [<c01b2dbf>] sysfs_add_one+0x9f/0xe0
Oct 16 19:36:27 carl kernel:  [<c01b3b76>] sysfs_create_link+0x86/0x110
Oct 16 19:36:27 carl kernel:  [<c02398ca>] device_rename+0x17a/0x1e0
Oct 16 19:36:27 carl kernel:  [<c015b56f>] filemap_fault+0x1ff/0x400
Oct 16 19:36:27 carl kernel:  [<c02b8fc0>] dev_change_name+0xb0/0x210
Oct 16 19:36:27 carl kernel:  [<c02b9779>] dev_ioctl+0x3c9/0x530
Oct 16 19:36:27 carl kernel:  [<c01a1938>]
inotify_d_instantiate+0x18/0x80
Oct 16 19:36:27 carl kernel:  [<c0120044>] do_page_fault+0x4a4/0x6f0
Oct 16 19:36:27 carl kernel:  [<c02ac080>] sock_ioctl+0x0/0x220
Oct 16 19:36:27 carl kernel:  [<c01851ab>] do_ioctl+0x2b/0x90
Oct 16 19:36:27 carl kernel:  [<c02ad50b>] sys_socket+0x2b/0x50
Oct 16 19:36:27 carl kernel:  [<c018542e>] vfs_ioctl+0x21e/0x2a0
Oct 16 19:36:27 carl kernel:  [<c01854ed>] sys_ioctl+0x3d/0x70
Oct 16 19:36:27 carl kernel:  [<c01042d6>] sysenter_past_esp+0x6b/0xa1
Oct 16 19:36:27 carl kernel:  =======================
Oct 16 19:36:27 carl kernel: net wlan0_rename: device_rename:

sysfs_create_symlink failed (-17)

Quoted 8 lines
Quoted 1 line

Plus it doesn't happen on 2.6.23 on my system, so I count it as a regression.

It's a new warning I've added to the kernel to catch stupid userspace and kernel code that is quietly failing when they are doing things incorrectly with kobjects and sysfs.

So it's not really a "regression" in that we never notified anyone of this kind of thing before, think of it as a new feature :)

Well, it seems to be a little bit over the top, then. ;-)

Greetings,
Rafael

#8 lore raw
Quoted 71 lines · Rafael J. Wysocki
Quoted 70 lines · Greg KH
Quoted 68 lines · Rafael J. Wysocki
Quoted 64 lines · Jens Axboe
Quoted 29 lines · Greg KH
Quoted 28 lines · Rafael J. Wysocki
Quoted 27 lines · Greg KH
Quoted 26 lines · Rafael J. Wysocki

Hi,

There are many traces like this in my dmesg from 2.6.23-git3 (they don't appear for vanilla 2.6.23):

<4>sysfs: duplicate filename 'ethxx1' can not be created

WARNING: at /home/rafael/src/linux-2.6/fs/sysfs/dir.c:425 sysfs_add_one()

Call Trace:
 [<ffffffff802d1532>] sysfs_add_one+0x5c/0xc9
 [<ffffffff802d2411>] sysfs_create_link+0xd1/0x12c
 [<ffffffff803756da>] device_rename+0x17a/0x1db
 [<ffffffff803c903d>] dev_change_name+0x114/0x20c
 [<ffffffff803c9339>] dev_ifsioc+0x204/0x2d0
 [<ffffffff803c9925>] dev_ioctl+0x520/0x633
 [<ffffffff803bf445>] sk_alloc+0x37/0x10c
 [<ffffffff8024b977>] up_read+0x9/0xb
 [<ffffffff803bc65e>] sock_ioctl+0x1fe/0x20c
 [<ffffffff8029b34a>] do_ioctl+0x2a/0x77
 [<ffffffff8029b5e8>] vfs_ioctl+0x251/0x26e
 [<ffffffff8029b664>] sys_ioctl+0x5f/0x83
 [<ffffffff8020bd4e>] system_call+0x7e/0x83

net ethxx1: device_rename: sysfs_create_symlink failed (-17)
sysfs: duplicate filename 'eth1' can not be created

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Everything seems to work, but this just looks fishy.

This is a userspace program renaming your network device to a name that is already in use. What distro and release is this?

openSUSE 10.2, with some updates (not the most recent, though).

Can you try 10.3? I think we fixed this issue there.

Ehm nope:

Oct 16 19:36:27 carl kernel: sysfs: duplicate filename 'wlan0_rename'
can not be created
Oct 16 19:36:27 carl kernel: udev: renamed network interface wmaster0 to
eth1
Oct 16 19:36:27 carl kernel: WARNING: at fs/sysfs/dir.c:425
sysfs_add_one()
Oct 16 19:36:27 carl kernel:  [<c01b2dbf>] sysfs_add_one+0x9f/0xe0
Oct 16 19:36:27 carl kernel:  [<c01b3b76>] sysfs_create_link+0x86/0x110
Oct 16 19:36:27 carl kernel:  [<c02398ca>] device_rename+0x17a/0x1e0
Oct 16 19:36:27 carl kernel:  [<c015b56f>] filemap_fault+0x1ff/0x400
Oct 16 19:36:27 carl kernel:  [<c02b8fc0>] dev_change_name+0xb0/0x210
Oct 16 19:36:27 carl kernel:  [<c02b9779>] dev_ioctl+0x3c9/0x530
Oct 16 19:36:27 carl kernel:  [<c01a1938>]
inotify_d_instantiate+0x18/0x80
Oct 16 19:36:27 carl kernel:  [<c0120044>] do_page_fault+0x4a4/0x6f0
Oct 16 19:36:27 carl kernel:  [<c02ac080>] sock_ioctl+0x0/0x220
Oct 16 19:36:27 carl kernel:  [<c01851ab>] do_ioctl+0x2b/0x90
Oct 16 19:36:27 carl kernel:  [<c02ad50b>] sys_socket+0x2b/0x50
Oct 16 19:36:27 carl kernel:  [<c018542e>] vfs_ioctl+0x21e/0x2a0
Oct 16 19:36:27 carl kernel:  [<c01854ed>] sys_ioctl+0x3d/0x70
Oct 16 19:36:27 carl kernel:  [<c01042d6>] sysenter_past_esp+0x6b/0xa1
Oct 16 19:36:27 carl kernel:  =======================
Oct 16 19:36:27 carl kernel: net wlan0_rename: device_rename:
Quoted 1 line

sysfs_create_symlink failed (-17)

Plus it doesn't happen on 2.6.23 on my system, so I count it as a regression.

Quoted 8 lines
Quoted 6 lines

It's a new warning I've added to the kernel to catch stupid userspace and kernel code that is quietly failing when they are doing things incorrectly with kobjects and sysfs.

So it's not really a "regression" in that we never notified anyone of this kind of thing before, think of it as a new feature :)

Well, it seems to be a little bit over the top, then. ;-)

In the network renaming it's a bit noisy, yes, but for other users which we discovered by this, it already exposed real bugs.

Kay

#9 lore raw
Quoted 76 lines · Kay Sievers
Quoted 75 lines · Rafael J. Wysocki
Quoted 74 lines · Greg KH
Quoted 67 lines · Rafael J. Wysocki
Quoted 64 lines · Jens Axboe
Quoted 29 lines · Greg KH
Quoted 28 lines · Rafael J. Wysocki
Quoted 27 lines · Greg KH
Quoted 26 lines · Rafael J. Wysocki

Hi,

There are many traces like this in my dmesg from 2.6.23-git3 (they don't appear for vanilla 2.6.23):

<4>sysfs: duplicate filename 'ethxx1' can not be created

WARNING: at /home/rafael/src/linux-2.6/fs/sysfs/dir.c:425 sysfs_add_one()

Call Trace:
 [<ffffffff802d1532>] sysfs_add_one+0x5c/0xc9
 [<ffffffff802d2411>] sysfs_create_link+0xd1/0x12c
 [<ffffffff803756da>] device_rename+0x17a/0x1db
 [<ffffffff803c903d>] dev_change_name+0x114/0x20c
 [<ffffffff803c9339>] dev_ifsioc+0x204/0x2d0
 [<ffffffff803c9925>] dev_ioctl+0x520/0x633
 [<ffffffff803bf445>] sk_alloc+0x37/0x10c
 [<ffffffff8024b977>] up_read+0x9/0xb
 [<ffffffff803bc65e>] sock_ioctl+0x1fe/0x20c
 [<ffffffff8029b34a>] do_ioctl+0x2a/0x77
 [<ffffffff8029b5e8>] vfs_ioctl+0x251/0x26e
 [<ffffffff8029b664>] sys_ioctl+0x5f/0x83
 [<ffffffff8020bd4e>] system_call+0x7e/0x83

net ethxx1: device_rename: sysfs_create_symlink failed (-17)
sysfs: duplicate filename 'eth1' can not be created

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Everything seems to work, but this just looks fishy.

This is a userspace program renaming your network device to a name that is already in use. What distro and release is this?

openSUSE 10.2, with some updates (not the most recent, though).

Can you try 10.3? I think we fixed this issue there.

Ehm nope:

Oct 16 19:36:27 carl kernel: sysfs: duplicate filename 'wlan0_rename'
can not be created
Oct 16 19:36:27 carl kernel: udev: renamed network interface wmaster0 to
eth1
Oct 16 19:36:27 carl kernel: WARNING: at fs/sysfs/dir.c:425
sysfs_add_one()
Oct 16 19:36:27 carl kernel:  [<c01b2dbf>] sysfs_add_one+0x9f/0xe0
Oct 16 19:36:27 carl kernel:  [<c01b3b76>] sysfs_create_link+0x86/0x110
Oct 16 19:36:27 carl kernel:  [<c02398ca>] device_rename+0x17a/0x1e0
Oct 16 19:36:27 carl kernel:  [<c015b56f>] filemap_fault+0x1ff/0x400
Oct 16 19:36:27 carl kernel:  [<c02b8fc0>] dev_change_name+0xb0/0x210
Oct 16 19:36:27 carl kernel:  [<c02b9779>] dev_ioctl+0x3c9/0x530
Oct 16 19:36:27 carl kernel:  [<c01a1938>]
inotify_d_instantiate+0x18/0x80
Oct 16 19:36:27 carl kernel:  [<c0120044>] do_page_fault+0x4a4/0x6f0
Oct 16 19:36:27 carl kernel:  [<c02ac080>] sock_ioctl+0x0/0x220
Oct 16 19:36:27 carl kernel:  [<c01851ab>] do_ioctl+0x2b/0x90
Oct 16 19:36:27 carl kernel:  [<c02ad50b>] sys_socket+0x2b/0x50
Oct 16 19:36:27 carl kernel:  [<c018542e>] vfs_ioctl+0x21e/0x2a0
Oct 16 19:36:27 carl kernel:  [<c01854ed>] sys_ioctl+0x3d/0x70
Oct 16 19:36:27 carl kernel:  [<c01042d6>] sysenter_past_esp+0x6b/0xa1
Oct 16 19:36:27 carl kernel:  =======================
Oct 16 19:36:27 carl kernel: net wlan0_rename: device_rename:
Quoted 1 line

sysfs_create_symlink failed (-17)

Quoted 1 line

Plus it doesn't happen on 2.6.23 on my system, so I count it as a regression.

It's a new warning I've added to the kernel to catch stupid userspace and kernel code that is quietly failing when they are doing things incorrectly with kobjects and sysfs.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

So it's not really a "regression" in that we never notified anyone of this kind of thing before, think of it as a new feature :)

Well, it seems to be a little bit over the top, then. ;-)

In the network renaming it's a bit noisy, yes, but for other users which we discovered by this, it already exposed real bugs.

Is it possible to change udev rules to avoid the warnings on openSUSE 10.2?

Greetings,
Rafael

#10 lore raw
In reply to Jens Axboe
Quoted 64 lines · Jens Axboe
Quoted 29 lines · Greg KH
Quoted 28 lines · Rafael J. Wysocki
Quoted 27 lines · Greg KH
Quoted 26 lines · Rafael J. Wysocki

Hi,

There are many traces like this in my dmesg from 2.6.23-git3 (they don't appear for vanilla 2.6.23):

<4>sysfs: duplicate filename 'ethxx1' can not be created

WARNING: at /home/rafael/src/linux-2.6/fs/sysfs/dir.c:425 sysfs_add_one()

Call Trace:
 [<ffffffff802d1532>] sysfs_add_one+0x5c/0xc9
 [<ffffffff802d2411>] sysfs_create_link+0xd1/0x12c
 [<ffffffff803756da>] device_rename+0x17a/0x1db
 [<ffffffff803c903d>] dev_change_name+0x114/0x20c
 [<ffffffff803c9339>] dev_ifsioc+0x204/0x2d0
 [<ffffffff803c9925>] dev_ioctl+0x520/0x633
 [<ffffffff803bf445>] sk_alloc+0x37/0x10c
 [<ffffffff8024b977>] up_read+0x9/0xb
 [<ffffffff803bc65e>] sock_ioctl+0x1fe/0x20c
 [<ffffffff8029b34a>] do_ioctl+0x2a/0x77
 [<ffffffff8029b5e8>] vfs_ioctl+0x251/0x26e
 [<ffffffff8029b664>] sys_ioctl+0x5f/0x83
 [<ffffffff8020bd4e>] system_call+0x7e/0x83

net ethxx1: device_rename: sysfs_create_symlink failed (-17)
sysfs: duplicate filename 'eth1' can not be created

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Everything seems to work, but this just looks fishy.

This is a userspace program renaming your network device to a name that is already in use. What distro and release is this?

openSUSE 10.2, with some updates (not the most recent, though).

Can you try 10.3? I think we fixed this issue there.

Ehm nope:

Oct 16 19:36:27 carl kernel: sysfs: duplicate filename 'wlan0_rename'
can not be created
Oct 16 19:36:27 carl kernel: udev: renamed network interface wmaster0 to
eth1
Oct 16 19:36:27 carl kernel: WARNING: at fs/sysfs/dir.c:425
sysfs_add_one()
Oct 16 19:36:27 carl kernel:  [<c01b2dbf>] sysfs_add_one+0x9f/0xe0
Oct 16 19:36:27 carl kernel:  [<c01b3b76>] sysfs_create_link+0x86/0x110
Oct 16 19:36:27 carl kernel:  [<c02398ca>] device_rename+0x17a/0x1e0
Oct 16 19:36:27 carl kernel:  [<c015b56f>] filemap_fault+0x1ff/0x400
Oct 16 19:36:27 carl kernel:  [<c02b8fc0>] dev_change_name+0xb0/0x210
Oct 16 19:36:27 carl kernel:  [<c02b9779>] dev_ioctl+0x3c9/0x530
Oct 16 19:36:27 carl kernel:  [<c01a1938>]
inotify_d_instantiate+0x18/0x80
Oct 16 19:36:27 carl kernel:  [<c0120044>] do_page_fault+0x4a4/0x6f0
Oct 16 19:36:27 carl kernel:  [<c02ac080>] sock_ioctl+0x0/0x220
Oct 16 19:36:27 carl kernel:  [<c01851ab>] do_ioctl+0x2b/0x90
Oct 16 19:36:27 carl kernel:  [<c02ad50b>] sys_socket+0x2b/0x50
Oct 16 19:36:27 carl kernel:  [<c018542e>] vfs_ioctl+0x21e/0x2a0
Oct 16 19:36:27 carl kernel:  [<c01854ed>] sys_ioctl+0x3d/0x70
Oct 16 19:36:27 carl kernel:  [<c01042d6>] sysenter_past_esp+0x6b/0xa1
Oct 16 19:36:27 carl kernel:  =======================
Oct 16 19:36:27 carl kernel: net wlan0_rename: device_rename:
Quoted 1 line

sysfs_create_symlink failed (-17)

Ugh, not good, I'll poke Kay...

{poke}

Kay, are we doing something wrong in userspace when renaming wireless devices such that we can overlap names?

thanks,

greg k-h

maintainer
#11 lore raw

From: Greg KH <[email protected]>
Date: Tue, 16 Oct 2007 14:37:30 -0700

Quoted 2 lines

Kay, are we doing something wrong in userspace when renaming wireless devices such that we can overlap names?

It does it for all network devices, I see this ugly message on every single system I have from Fedora foo to RHEL foo to ubuntu foo to debian foo.

udev simply applies the MAC address to device name rules blindly, it doesn't check if the device already has the desired name already

It's been like this forever, and since userland has been doing it for so long, you can't warn on this there is too much established practice. Expecting people to install "fixed" udev is not an acceptable answer, the warning is a regression and therefore you'll have to remove the kernel warning for this case and live with this issue essentially forever.

#12 lore raw
Quoted 6 lines · David Miller

From: Greg KH <[email protected]>
Date: Tue, 16 Oct 2007 14:37:30 -0700

Quoted 2 lines

Kay, are we doing something wrong in userspace when renaming wireless devices such that we can overlap names?

Quoted 6 lines

It does it for all network devices, I see this ugly message on every single system I have from Fedora foo to RHEL foo to ubuntu foo to debian foo.

udev simply applies the MAC address to device name rules blindly, it doesn't check if the device already has the desired name already

Ugh :(

Quoted 6 lines

It's been like this forever, and since userland has been doing it for so long, you can't warn on this there is too much established practice. Expecting people to install "fixed" udev is not an acceptable answer, the warning is a regression and therefore you'll have to remove the kernel warning for this case and live with this issue essentially forever.

Nope, I guess we will have to take out the check (or put it under the kobject debugging flag), unless Kay has any other ideas...

thanks,

greg k-h

#13 lore raw
Quoted 6 lines · Greg KH
Quoted 5 lines · David Miller

From: Greg KH <[email protected]>
Date: Tue, 16 Oct 2007 14:37:30 -0700

Quoted 2 lines

Kay, are we doing something wrong in userspace when renaming wireless devices such that we can overlap names?

Not udev, but SUSE 10.2's network renaming. It uses udev and calls ifrename in the same code path. 10.3 uses the unified version from the udev tree.

Quoted 6 lines
Quoted 6 lines

It does it for all network devices, I see this ugly message on every single system I have from Fedora foo to RHEL foo to ubuntu foo to debian foo.

udev simply applies the MAC address to device name rules blindly, it doesn't check if the device already has the desired name already

There is a check for the same name in udev for long.

Quoted 8 lines

Ugh :(

Quoted 6 lines

It's been like this forever, and since userland has been doing it for so long, you can't warn on this there is too much established practice. Expecting people to install "fixed" udev is not an acceptable answer, the warning is a regression and therefore you'll have to remove the kernel warning for this case and live with this issue essentially forever.

We should probably just add the check to kobject_rename() and print a simple warning and then do nothing. Or just do the check in the network ioctl, if we really don't want to see this.

Quoted 2 lines

Nope, I guess we will have to take out the check (or put it under the kobject debugging flag), unless Kay has any other ideas...

We should really keep it, it already exposed a lot of serious bugs in the kernel and users, we never spotted before.

Kay

#14 lore raw
Quoted 30 lines · Kay Sievers
Quoted 6 lines · Greg KH
Quoted 5 lines · David Miller

From: Greg KH <[email protected]>
Date: Tue, 16 Oct 2007 14:37:30 -0700

Quoted 2 lines

Kay, are we doing something wrong in userspace when renaming wireless devices such that we can overlap names?

Not udev, but SUSE 10.2's network renaming. It uses udev and calls ifrename in the same code path. 10.3 uses the unified version from the udev tree.

Quoted 6 lines
Quoted 6 lines

It does it for all network devices, I see this ugly message on every single system I have from Fedora foo to RHEL foo to ubuntu foo to debian foo.

udev simply applies the MAC address to device name rules blindly, it doesn't check if the device already has the desired name already

There is a check for the same name in udev for long.

Quoted 8 lines

Ugh :(

Quoted 6 lines

It's been like this forever, and since userland has been doing it for so long, you can't warn on this there is too much established practice. Expecting people to install "fixed" udev is not an acceptable answer, the warning is a regression and therefore you'll have to remove the kernel warning for this case and live with this issue essentially forever.

Quoted 3 lines

We should probably just add the check to kobject_rename() and print a simple warning and then do nothing. Or just do the check in the network ioctl, if we really don't want to see this.

I agree that perhaps kobject_rename() should check for this. Let me go see if I can get that to work...

thanks,

greg k-h

#15 lore raw
Quoted 31 lines · Greg KH
Quoted 30 lines · Kay Sievers
Quoted 6 lines · Greg KH
Quoted 5 lines · David Miller

From: Greg KH <[email protected]>
Date: Tue, 16 Oct 2007 14:37:30 -0700

Quoted 2 lines

Kay, are we doing something wrong in userspace when renaming wireless devices such that we can overlap names?

Not udev, but SUSE 10.2's network renaming. It uses udev and calls ifrename in the same code path. 10.3 uses the unified version from the udev tree.

Quoted 6 lines
Quoted 6 lines

It does it for all network devices, I see this ugly message on every single system I have from Fedora foo to RHEL foo to ubuntu foo to debian foo.

udev simply applies the MAC address to device name rules blindly, it doesn't check if the device already has the desired name already

There is a check for the same name in udev for long.

Quoted 8 lines

Ugh :(

Quoted 6 lines

It's been like this forever, and since userland has been doing it for so long, you can't warn on this there is too much established practice. Expecting people to install "fixed" udev is not an acceptable answer, the warning is a regression and therefore you'll have to remove the kernel warning for this case and live with this issue essentially forever.

Quoted 6 lines
Quoted 3 lines

We should probably just add the check to kobject_rename() and print a simple warning and then do nothing. Or just do the check in the network ioctl, if we really don't want to see this.

I agree that perhaps kobject_rename() should check for this. Let me go see if I can get that to work...

Can someone try this patch, and see what happens when they try to rename an object to something that is already existing?

thanks,

greg k-h

---
 lib/kobject.c |   13 +++++++++++++
 1 file changed, 13 insertions(+)
lib/kobject.c +13 -0
@@ -366,6 +366,19 @@ int kobject_rename(struct kobject * kobj
 	if (!kobj->parent)
 		return -EINVAL;
 
+	/* see if this name is already in use */
+	if (kobj->kset) {
+		struct kobject *temp_kobj;
+		temp_kobj = kset_find_obj(kobj->kset, new_name);
+		if (temp_kobj) {
+			printk(KERN_WARNING "kobject '%s' can not be renamed "
+			       "to '%s' as '%s' is already in existance.\n",
+			       kobject_name(kobj), new_name, new_name);
+			kobject_put(temp_kobj);
+			return -EINVAL;
+		}
+	}
+
 	devpath = kobject_get_path(kobj, GFP_KERNEL);
 	if (!devpath) {
 		error = -ENOMEM;
#16 lore raw
Quoted 36 lines · Greg KH
Quoted 35 lines · Greg KH
Quoted 33 lines · Kay Sievers
Quoted 6 lines · Greg KH
Quoted 5 lines · David Miller

From: Greg KH <[email protected]>
Date: Tue, 16 Oct 2007 14:37:30 -0700

Quoted 2 lines

Kay, are we doing something wrong in userspace when renaming wireless devices such that we can overlap names?

Not udev, but SUSE 10.2's network renaming. It uses udev and calls ifrename in the same code path. 10.3 uses the unified version from the udev tree.

Quoted 6 lines
Quoted 6 lines

It does it for all network devices, I see this ugly message on every single system I have from Fedora foo to RHEL foo to ubuntu foo to debian foo.

udev simply applies the MAC address to device name rules blindly, it doesn't check if the device already has the desired name already

There is a check for the same name in udev for long.

Quoted 8 lines

Ugh :(

Quoted 6 lines

It's been like this forever, and since userland has been doing it for so long, you can't warn on this there is too much established practice. Expecting people to install "fixed" udev is not an acceptable answer, the warning is a regression and therefore you'll have to remove the kernel warning for this case and live with this issue essentially forever.

We should probably just add the check to kobject_rename() and print a simple warning and then do nothing. Or just do the check in the network ioctl, if we really don't want to see this.

Quoted 5 lines
Quoted 2 lines

I agree that perhaps kobject_rename() should check for this. Let me go see if I can get that to work...

Can someone try this patch, and see what happens when they try to rename an object to something that is already existing?

That may still fail if a netif creation, and a rename compete about the same name, right?

The driver core name of the netdev is part of the netdev, so the net core might need to rename the driver core part while holding its usual lock, just like it does when it changes the net internal name?

The netdev rename should also fail, if the core rename fails, right?

Thanks,
Kay

net/core/dev.c +5 -2
index 8726589..ed3db06 100644
@@ -899,9 +899,12 @@ int dev_change_name(struct net_device *dev, char *newname)
 		strlcpy(dev->name, newname, IFNAMSIZ);
 
 rollback:
-	device_rename(&dev->dev, dev->name);
-
 	write_lock_bh(&dev_base_lock);
+	err = device_rename(&dev->dev, dev->name);
+	if (err) {
+		write_unlock_bh(&dev_base_lock);
+		return err;
+	}
 	hlist_del(&dev->name_hlist);
 	hlist_add_head(&dev->name_hlist, dev_name_hash(net, dev->name));
 	write_unlock_bh(&dev_base_lock);
#17 lore raw
In reply to Jens Axboe
Quoted 64 lines · Jens Axboe
Quoted 29 lines · Greg KH
Quoted 28 lines · Rafael J. Wysocki
Quoted 27 lines · Greg KH
Quoted 26 lines · Rafael J. Wysocki

Hi,

There are many traces like this in my dmesg from 2.6.23-git3 (they don't appear for vanilla 2.6.23):

<4>sysfs: duplicate filename 'ethxx1' can not be created

WARNING: at /home/rafael/src/linux-2.6/fs/sysfs/dir.c:425 sysfs_add_one()

Call Trace:
 [<ffffffff802d1532>] sysfs_add_one+0x5c/0xc9
 [<ffffffff802d2411>] sysfs_create_link+0xd1/0x12c
 [<ffffffff803756da>] device_rename+0x17a/0x1db
 [<ffffffff803c903d>] dev_change_name+0x114/0x20c
 [<ffffffff803c9339>] dev_ifsioc+0x204/0x2d0
 [<ffffffff803c9925>] dev_ioctl+0x520/0x633
 [<ffffffff803bf445>] sk_alloc+0x37/0x10c
 [<ffffffff8024b977>] up_read+0x9/0xb
 [<ffffffff803bc65e>] sock_ioctl+0x1fe/0x20c
 [<ffffffff8029b34a>] do_ioctl+0x2a/0x77
 [<ffffffff8029b5e8>] vfs_ioctl+0x251/0x26e
 [<ffffffff8029b664>] sys_ioctl+0x5f/0x83
 [<ffffffff8020bd4e>] system_call+0x7e/0x83

net ethxx1: device_rename: sysfs_create_symlink failed (-17)
sysfs: duplicate filename 'eth1' can not be created

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Everything seems to work, but this just looks fishy.

This is a userspace program renaming your network device to a name that is already in use. What distro and release is this?

openSUSE 10.2, with some updates (not the most recent, though).

Can you try 10.3? I think we fixed this issue there.

Ehm nope:

Oct 16 19:36:27 carl kernel: sysfs: duplicate filename 'wlan0_rename'
can not be created
Oct 16 19:36:27 carl kernel: udev: renamed network interface wmaster0 to
eth1
Oct 16 19:36:27 carl kernel: WARNING: at fs/sysfs/dir.c:425
sysfs_add_one()
Oct 16 19:36:27 carl kernel:  [<c01b2dbf>] sysfs_add_one+0x9f/0xe0
Oct 16 19:36:27 carl kernel:  [<c01b3b76>] sysfs_create_link+0x86/0x110
Oct 16 19:36:27 carl kernel:  [<c02398ca>] device_rename+0x17a/0x1e0
Oct 16 19:36:27 carl kernel:  [<c015b56f>] filemap_fault+0x1ff/0x400
Oct 16 19:36:27 carl kernel:  [<c02b8fc0>] dev_change_name+0xb0/0x210
Oct 16 19:36:27 carl kernel:  [<c02b9779>] dev_ioctl+0x3c9/0x530
Oct 16 19:36:27 carl kernel:  [<c01a1938>]
inotify_d_instantiate+0x18/0x80
Oct 16 19:36:27 carl kernel:  [<c0120044>] do_page_fault+0x4a4/0x6f0
Oct 16 19:36:27 carl kernel:  [<c02ac080>] sock_ioctl+0x0/0x220
Oct 16 19:36:27 carl kernel:  [<c01851ab>] do_ioctl+0x2b/0x90
Oct 16 19:36:27 carl kernel:  [<c02ad50b>] sys_socket+0x2b/0x50
Oct 16 19:36:27 carl kernel:  [<c018542e>] vfs_ioctl+0x21e/0x2a0
Oct 16 19:36:27 carl kernel:  [<c01854ed>] sys_ioctl+0x3d/0x70
Oct 16 19:36:27 carl kernel:  [<c01042d6>] sysenter_past_esp+0x6b/0xa1
Oct 16 19:36:27 carl kernel:  =======================
Oct 16 19:36:27 carl kernel: net wlan0_rename: device_rename:
Quoted 1 line

sysfs_create_symlink failed (-17)

Are you switching from the ipw to the iwl driver?
Care to delete (or remove the entries):
/etc/udev/rules.d/70-persistent-net.rules
and try with iwl only? It should work then, even when going back to ipw.

A fix for this didn't make it into the 10.3 release, but is in the upstream udev tree.

Thanks,
Kay

#18 lore raw
Quoted 67 lines · Kay Sievers
Quoted 64 lines · Jens Axboe
Quoted 29 lines · Greg KH
Quoted 28 lines · Rafael J. Wysocki
Quoted 27 lines · Greg KH
Quoted 26 lines · Rafael J. Wysocki

Hi,

There are many traces like this in my dmesg from 2.6.23-git3 (they don't appear for vanilla 2.6.23):

<4>sysfs: duplicate filename 'ethxx1' can not be created

WARNING: at /home/rafael/src/linux-2.6/fs/sysfs/dir.c:425 sysfs_add_one()

Call Trace:
 [<ffffffff802d1532>] sysfs_add_one+0x5c/0xc9
 [<ffffffff802d2411>] sysfs_create_link+0xd1/0x12c
 [<ffffffff803756da>] device_rename+0x17a/0x1db
 [<ffffffff803c903d>] dev_change_name+0x114/0x20c
 [<ffffffff803c9339>] dev_ifsioc+0x204/0x2d0
 [<ffffffff803c9925>] dev_ioctl+0x520/0x633
 [<ffffffff803bf445>] sk_alloc+0x37/0x10c
 [<ffffffff8024b977>] up_read+0x9/0xb
 [<ffffffff803bc65e>] sock_ioctl+0x1fe/0x20c
 [<ffffffff8029b34a>] do_ioctl+0x2a/0x77
 [<ffffffff8029b5e8>] vfs_ioctl+0x251/0x26e
 [<ffffffff8029b664>] sys_ioctl+0x5f/0x83
 [<ffffffff8020bd4e>] system_call+0x7e/0x83

net ethxx1: device_rename: sysfs_create_symlink failed (-17)
sysfs: duplicate filename 'eth1' can not be created

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Everything seems to work, but this just looks fishy.

This is a userspace program renaming your network device to a name that is already in use. What distro and release is this?

openSUSE 10.2, with some updates (not the most recent, though).

Can you try 10.3? I think we fixed this issue there.

Ehm nope:

Oct 16 19:36:27 carl kernel: sysfs: duplicate filename 'wlan0_rename'
can not be created
Oct 16 19:36:27 carl kernel: udev: renamed network interface wmaster0 to
eth1
Oct 16 19:36:27 carl kernel: WARNING: at fs/sysfs/dir.c:425
sysfs_add_one()
Oct 16 19:36:27 carl kernel:  [<c01b2dbf>] sysfs_add_one+0x9f/0xe0
Oct 16 19:36:27 carl kernel:  [<c01b3b76>] sysfs_create_link+0x86/0x110
Oct 16 19:36:27 carl kernel:  [<c02398ca>] device_rename+0x17a/0x1e0
Oct 16 19:36:27 carl kernel:  [<c015b56f>] filemap_fault+0x1ff/0x400
Oct 16 19:36:27 carl kernel:  [<c02b8fc0>] dev_change_name+0xb0/0x210
Oct 16 19:36:27 carl kernel:  [<c02b9779>] dev_ioctl+0x3c9/0x530
Oct 16 19:36:27 carl kernel:  [<c01a1938>]
inotify_d_instantiate+0x18/0x80
Oct 16 19:36:27 carl kernel:  [<c0120044>] do_page_fault+0x4a4/0x6f0
Oct 16 19:36:27 carl kernel:  [<c02ac080>] sock_ioctl+0x0/0x220
Oct 16 19:36:27 carl kernel:  [<c01851ab>] do_ioctl+0x2b/0x90
Oct 16 19:36:27 carl kernel:  [<c02ad50b>] sys_socket+0x2b/0x50
Oct 16 19:36:27 carl kernel:  [<c018542e>] vfs_ioctl+0x21e/0x2a0
Oct 16 19:36:27 carl kernel:  [<c01854ed>] sys_ioctl+0x3d/0x70
Oct 16 19:36:27 carl kernel:  [<c01042d6>] sysenter_past_esp+0x6b/0xa1
Oct 16 19:36:27 carl kernel:  =======================
Oct 16 19:36:27 carl kernel: net wlan0_rename: device_rename:
Quoted 1 line

sysfs_create_symlink failed (-17)

Quoted 4 lines

Are you switching from the ipw to the iwl driver?
Care to delete (or remove the entries):
/etc/udev/rules.d/70-persistent-net.rules
and try with iwl only? It should work then, even when going back to ipw.

Yep, that's exactly what I'm doing. I'll try and kill that udev entry.

Quoted 2 lines

A fix for this didn't make it into the 10.3 release, but is in the upstream udev tree.

OK

Signature · 1 line
Jens Axboe
#19 lore raw
Quoted 68 lines · Jens Axboe
Quoted 67 lines · Kay Sievers
Quoted 65 lines · Jens Axboe
Quoted 29 lines · Greg KH
Quoted 28 lines · Rafael J. Wysocki
Quoted 27 lines · Greg KH
Quoted 26 lines · Rafael J. Wysocki

Hi,

There are many traces like this in my dmesg from 2.6.23-git3 (they don't appear for vanilla 2.6.23):

<4>sysfs: duplicate filename 'ethxx1' can not be created

WARNING: at /home/rafael/src/linux-2.6/fs/sysfs/dir.c:425 sysfs_add_one()

Call Trace:
 [<ffffffff802d1532>] sysfs_add_one+0x5c/0xc9
 [<ffffffff802d2411>] sysfs_create_link+0xd1/0x12c
 [<ffffffff803756da>] device_rename+0x17a/0x1db
 [<ffffffff803c903d>] dev_change_name+0x114/0x20c
 [<ffffffff803c9339>] dev_ifsioc+0x204/0x2d0
 [<ffffffff803c9925>] dev_ioctl+0x520/0x633
 [<ffffffff803bf445>] sk_alloc+0x37/0x10c
 [<ffffffff8024b977>] up_read+0x9/0xb
 [<ffffffff803bc65e>] sock_ioctl+0x1fe/0x20c
 [<ffffffff8029b34a>] do_ioctl+0x2a/0x77
 [<ffffffff8029b5e8>] vfs_ioctl+0x251/0x26e
 [<ffffffff8029b664>] sys_ioctl+0x5f/0x83
 [<ffffffff8020bd4e>] system_call+0x7e/0x83

net ethxx1: device_rename: sysfs_create_symlink failed (-17)
sysfs: duplicate filename 'eth1' can not be created

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Everything seems to work, but this just looks fishy.

This is a userspace program renaming your network device to a name that is already in use. What distro and release is this?

openSUSE 10.2, with some updates (not the most recent, though).

Can you try 10.3? I think we fixed this issue there.

Ehm nope:

Oct 16 19:36:27 carl kernel: sysfs: duplicate filename 'wlan0_rename'
can not be created
Oct 16 19:36:27 carl kernel: udev: renamed network interface wmaster0 to
eth1
Oct 16 19:36:27 carl kernel: WARNING: at fs/sysfs/dir.c:425
sysfs_add_one()
Oct 16 19:36:27 carl kernel:  [<c01b2dbf>] sysfs_add_one+0x9f/0xe0
Oct 16 19:36:27 carl kernel:  [<c01b3b76>] sysfs_create_link+0x86/0x110
Oct 16 19:36:27 carl kernel:  [<c02398ca>] device_rename+0x17a/0x1e0
Oct 16 19:36:27 carl kernel:  [<c015b56f>] filemap_fault+0x1ff/0x400
Oct 16 19:36:27 carl kernel:  [<c02b8fc0>] dev_change_name+0xb0/0x210
Oct 16 19:36:27 carl kernel:  [<c02b9779>] dev_ioctl+0x3c9/0x530
Oct 16 19:36:27 carl kernel:  [<c01a1938>]
inotify_d_instantiate+0x18/0x80
Oct 16 19:36:27 carl kernel:  [<c0120044>] do_page_fault+0x4a4/0x6f0
Oct 16 19:36:27 carl kernel:  [<c02ac080>] sock_ioctl+0x0/0x220
Oct 16 19:36:27 carl kernel:  [<c01851ab>] do_ioctl+0x2b/0x90
Oct 16 19:36:27 carl kernel:  [<c02ad50b>] sys_socket+0x2b/0x50
Oct 16 19:36:27 carl kernel:  [<c018542e>] vfs_ioctl+0x21e/0x2a0
Oct 16 19:36:27 carl kernel:  [<c01854ed>] sys_ioctl+0x3d/0x70
Oct 16 19:36:27 carl kernel:  [<c01042d6>] sysenter_past_esp+0x6b/0xa1
Oct 16 19:36:27 carl kernel:  =======================
Oct 16 19:36:27 carl kernel: net wlan0_rename: device_rename:

sysfs_create_symlink failed (-17)

Quoted 6 lines
Quoted 4 lines

Are you switching from the ipw to the iwl driver?
Care to delete (or remove the entries):
/etc/udev/rules.d/70-persistent-net.rules
and try with iwl only? It should work then, even when going back to ipw.

Yep, that's exactly what I'm doing. I'll try and kill that udev entry.

Removing that udev rule file got rid of the warning here. Now I just have to figure out why iwl3945 doesn't work for me in the vanilla kernel, when it does in the SUSE kernel...

Signature · 1 line
Jens Axboe
#20 lore raw
In reply to Rafael J. Wysocki
Quoted 28 lines · Rafael J. Wysocki
Quoted 27 lines · Greg KH
Quoted 26 lines · Rafael J. Wysocki

Hi,

There are many traces like this in my dmesg from 2.6.23-git3 (they don't appear for vanilla 2.6.23):

<4>sysfs: duplicate filename 'ethxx1' can not be created

WARNING: at /home/rafael/src/linux-2.6/fs/sysfs/dir.c:425 sysfs_add_one()

Call Trace:
 [<ffffffff802d1532>] sysfs_add_one+0x5c/0xc9
 [<ffffffff802d2411>] sysfs_create_link+0xd1/0x12c
 [<ffffffff803756da>] device_rename+0x17a/0x1db
 [<ffffffff803c903d>] dev_change_name+0x114/0x20c
 [<ffffffff803c9339>] dev_ifsioc+0x204/0x2d0
 [<ffffffff803c9925>] dev_ioctl+0x520/0x633
 [<ffffffff803bf445>] sk_alloc+0x37/0x10c
 [<ffffffff8024b977>] up_read+0x9/0xb
 [<ffffffff803bc65e>] sock_ioctl+0x1fe/0x20c
 [<ffffffff8029b34a>] do_ioctl+0x2a/0x77
 [<ffffffff8029b5e8>] vfs_ioctl+0x251/0x26e
 [<ffffffff8029b664>] sys_ioctl+0x5f/0x83
 [<ffffffff8020bd4e>] system_call+0x7e/0x83

net ethxx1: device_rename: sysfs_create_symlink failed (-17)
sysfs: duplicate filename 'eth1' can not be created

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Everything seems to work, but this just looks fishy.

This is a userspace program renaming your network device to a name that is already in use. What distro and release is this?

openSUSE 10.2, with some updates (not the most recent, though).

Same thing happens in 10.3, rendering current git unusable for me with iwl3945.

Signature · 1 line
Jens Axboe