Skip to contentSkip to conversation

drivers/bluetooth/btsdio.c: fix double-free

PATCH In review Adrian Bunk 2 participants 2 messages Oct 24, 2007 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/bluetooth/btsdio.c: fix double-free

This patch fixes a double-free spotted by the Coverity checker.

---

09bae986c340a634714517659822959cef72f66d

drivers/bluetooth/btsdio.c +1 -3
index b786f61..58630cc 100644
@@ -162,10 +162,8 @@ static int btsdio_rx_packet(struct btsdio_data *data)
 	bt_cb(skb)->pkt_type = hdr[3];
 
 	err = hci_recv_frame(skb);
-	if (err < 0) {
-		kfree(skb);
+	if (err < 0)
 		return err;
-	}
 
 	sdio_writeb(data->func, 0x00, REG_PC_RRT, NULL);
 
maintainer
#1 lore raw

Hi Adrian,

Quoted 1 line

This patch fixes a double-free spotted by the Coverity checker.

good catch. Patch has been applied to me tree. Thanks.

Regards

Marcel

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel