Wipe out traditional opt from x86_64 Makefile
PATCH 1/1 Wipe out traditional opt from x86_64 Makefile
Among other things, using -traditional as a gcc option stops us from using macro token pasting, which is a feature we heavily rely on.
There was still a use of -traditional in arch/x86/kernel/Makefile_64, which this patch removes.
I don't see any problems building kernels in my x86_64 box without -traditional.
--- arch/x86/kernel/Makefile_64 | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
arch/x86/kernel/Makefile_64 +0 -1
@@ -3,7 +3,6 @@ # extra-y := head_64.o head64.o init_task.o vmlinux.lds -#EXTRA_AFLAGS := -traditional obj-y := process_64.o signal_64.o entry_64.o traps_64.o irq_64.o \ ptrace_64.o time_64.o ioport_64.o ldt_64.o setup_64.o i8259_64.o sys_x86_64.o \ x8664_ksyms_64.o i387_64.o syscall_64.o vsyscall_64.o \
Signature · 1 line
1.4.4.2
Ok, ok... this was stupid.
I sent the patch against an already-commented out version, which is the one I was using for testing. Really stupid.
Quoted 30 lines · Glauber de Oliveira Costa
Among other things, using -traditional as a gcc option stops us from using macro token pasting, which is a feature we heavily rely on.
There was still a use of -traditional in
arch/x86/kernel/Makefile_64, which this patch removes.I don't see any problems building kernels in my
x86_64box without -traditional.Signed-off-by Glauber de Oliveira Costa <[email protected]>--- arch/x86/kernel/Makefile_64 | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)arch/x86/kernel/Makefile_64 +0
-2@@ -3,7 +3,6 @@ # extra-y := head_64.o head64.o init_task.o vmlinux.lds -#EXTRA_AFLAGS := -traditional obj-y := process_64.o signal_64.o entry_64.o traps_64.o irq_64.o \ ptrace_64.o time_64.o ioport_64.o ldt_64.o setup_64.o i8259_64.o sys_x86_64.o \ x8664_ksyms_64.o i387_64.o syscall_64.o vsyscall_64.o \ --1.4.4.2
Signature · 5 lines
Glauber de Oliveira Costa. "Free as in Freedom" http://glommer.net "The less confident you are, the more serious you have to act."
H. Peter Anvin
reviewerQuoted 19 lines · Glauber de Oliveira Costa
Among other things, using -traditional as a gcc option stops us from using macro token pasting, which is a feature we heavily rely on.
There was still a use of -traditional in
arch/x86/kernel/Makefile_64, which this patch removes.I don't see any problems building kernels in my
x86_64box without -traditional.Signed-off-by Glauber de Oliveira Costa <[email protected]>--- arch/x86/kernel/Makefile_64 | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)arch/x86/kernel/Makefile_64 +0
-0
arch/x86/kernel/Makefile_64 line 8
Quoted 7 lines
arch/x86/kernel/Makefile_64 +0
-1@@ -3,7 +3,6 @@ # extra-y := head_64.o head64.o init_task.o vmlinux.lds -#EXTRA_AFLAGS := -traditional obj-y := process_64.o signal_64.o entry_64.o traps_64.o irq_64.o \ ptrace_64.o time_64.o ioport_64.o ldt_64.o setup_64.o i8259_64.o sys_x86_64.o \ x8664_ksyms_64.o i387_64.o syscall_64.o vsyscall_64.o \
At least *at one point*, ld scripts were whitespace-sensitive in a way that called for using -traditional. Doesn't mean that anything else needs it, though.
-hpa
Quoted 9 lines · Glauber de Oliveira Costa
Among other things, using -traditional as a gcc option stops us from using macro token pasting, which is a feature we heavily rely on.
There was still a use of -traditional in
arch/x86/kernel/Makefile_64, which this patch removes.I don't see any problems building kernels in my
x86_64box without -traditional.
...
Does it also work with gcc 3.2 ?
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedH. Peter Anvin
reviewerQuoted 4 lines · Adrian Bunk
Quoted 3 lines · Glauber de Oliveira Costa
Among other things, using -traditional as a gcc option stops us from using macro token pasting, which is a feature we heavily rely on.
Quoted 9 lines
Quoted 6 lines
There was still a use of -traditional in
arch/x86/kernel/Makefile_64, which this patch removes.I don't see any problems building kernels in my
x86_64box without -traditional.
...Does it also work with gcc 3.2 ?
It wouldn't be a gcc version issue, it would be a binutils (ld) version issue.
-hpa
Quoted 8 lines · H. Peter Anvin
Quoted 7 lines · Adrian Bunk
Quoted 6 lines · Glauber de Oliveira Costa
Among other things, using -traditional as a gcc option stops us from using macro token pasting, which is a feature we heavily rely on.
There was still a use of -traditional in
arch/x86/kernel/Makefile_64, which this patch removes.
Quoted 7 lines
Quoted 4 lines
Quoted 3 lines
I don't see any problems building kernels in my
x86_64box without -traditional.
...Does it also work with gcc 3.2 ?
It wouldn't be a gcc version issue, it would be a binutils (ld) version issue.
Sorry for the dumb question, but how does or did the gcc -traditional option affect ld?
Quoted 1 line
-hpa
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 3 lines · Adrian Bunk
Sorry for the dumb question, but how does or did the gcc -traditional option affect ld?
vmlinux.lds is run through cpp (as a .S file).
J
Quoted 5 lines · Jeremy Fitzhardinge
Quoted 3 lines · Adrian Bunk
Sorry for the dumb question, but how does or did the gcc -traditional option affect ld?
After a while, there is no issue I can find on x86_64 by taking out the -traditional flag. Everything seems fine.
Signature · 5 lines
Glauber de Oliveira Costa. "Free as in Freedom" http://glommer.net "The less confident you are, the more serious you have to act."