AD1986A 6-channel bugs

Hi,

I have a ICH8M + AD1986A machine and run alsa-driver-1.0.15rc.

I found that :
In 6 channel mode,if adjust the front or pcm volume when playing

all channel will be muted,but if adjust the volume alone(don't play music at the same time),every thing is ok.
I use printk to display the verb in the azx_send_cmd(), when adjusting the volume in either case, there are just two verb (0x300) sent to the nid(0x1b) [correct action].
But in the first case, the dac widget amp-out vals are all affected.

Some other interesting thing,
If i adjust the Sur or CLFE volume when playing music, the printk show that correct verb is sent, but the codec status don't change. If I adjust them alone,every thing is ok.

Hi,

I have a ICH8M + AD1986A machine.

In 6 channel modes, if adjust the volumes when playing 2-channel or 4-channel music, codec will be muted and all widget's Amp-Out vals will be reset. If you play 2-channel files in 6 channel modes,there is noise in the jacks.

By doing experiments, I found that the 6-channel bug was caused by sharing channels.

If play 2-channel audio file,the rest channels will share channels with the first 2-channel.

The HDA spec doesn’t define the exact behavior under such circumstances.

Majority of the codec chips support sharing channel, but seem that AD1986A doesn’t support.

I wrote a patch and tested it in my hardware,now it works well.

At Thu, 25 Oct 2007 15:05:40 +0800,

Quoted 21 lines · zhejiang

Hi,

I have a ICH8M + AD1986A machine.

In 6 channel modes, if adjust the volumes when playing 2-channel or 4-channel music, codec will be muted and all widget's Amp-Out vals will be reset. If you play 2-channel files in 6 channel modes,there is noise in the jacks.

By doing experiments, I found that the 6-channel bug was caused by sharing channels.

If play 2-channel audio file,the rest channels will share channels with the first 2-channel.

The HDA spec doesn’t define the exact behavior under such circumstances.

Majority of the codec chips support sharing channel, but seem that AD1986A doesn’t support.

Quoted 1 line

I wrote a patch and tested it in my hardware,now it works well.

Thanks! It's been a bug that I hardly understood what was wrong.

IMO, it's better to have a flag in hda_multi_out rather than hardcoding the codec id there.

Could you check whether the patch below works?

Takashi

diff -r 4f3f2f4bd5e9 pci/hda/hda_codec.c

pci/hda/hda_codec.c +4 -3

@@ -2486,13 +2486,14 @@ int snd_hda_multi_out_analog_prepare(str
 	/* front */
 	snd_hda_codec_setup_stream(codec, nids[HDA_FRONT], stream_tag,
 				   0, format);
-	if (mout->hp_nid && mout->hp_nid != nids[HDA_FRONT])
+	if (!mout->no_share_stream &&
+	    mout->hp_nid && mout->hp_nid != nids[HDA_FRONT])
 		/* headphone out will just decode front left/right (stereo) */
 		snd_hda_codec_setup_stream(codec, mout->hp_nid, stream_tag,
 					   0, format);
 	/* extra outputs copied from front */
 	for (i = 0; i < ARRAY_SIZE(mout->extra_out_nid); i++)
-		if (mout->extra_out_nid[i])
+		if (!mout->no_share_stream && mout->extra_out_nid[i])
 			snd_hda_codec_setup_stream(codec,
 						   mout->extra_out_nid[i],
 						   stream_tag, 0, format);

@@ -2502,7 +2503,7 @@ int snd_hda_multi_out_analog_prepare(str
 		if (chs >= (i + 1) * 2) /* independent out */
 			snd_hda_codec_setup_stream(codec, nids[i], stream_tag,
 						   i * 2, format);
-		else /* copy front */
+		else if (!mout->no_share_stream) /* copy front */
 			snd_hda_codec_setup_stream(codec, nids[i], stream_tag,
 						   0, format);
 	}

diff -r 4f3f2f4bd5e9 pci/hda/hda_local.h

pci/hda/hda_local.h +1 -0

@@ -220,6 +220,7 @@ struct hda_multi_out {
 	hda_nid_t dig_out_nid;	/* digital out audio widget */
 	int max_channels;	/* currently supported analog channels */
 	int dig_out_used;	/* current usage of digital out (HDA_DIG_XXX) */
+	int no_share_stream;	/* don't share a stream with multiple pins */
 };
 
 int snd_hda_multi_out_dig_open(struct hda_codec *codec,

diff -r 4f3f2f4bd5e9 pci/hda/patch_analog.c

pci/hda/patch_analog.c +1 -0

@@ -956,6 +956,14 @@ static int patch_ad1986a(struct hda_code
 		spec->multiout.dig_out_nid = 0;
 		break;
 	}
+

Quoted 27 lines · Takashi Iwai

At Thu, 25 Oct 2007 15:05:40 +0800,

Quoted 16 lines · zhejiang

Hi,

I have a ICH8M + AD1986A machine.

In 6 channel modes, if adjust the volumes when playing 2-channel or 4-channel music, codec will be muted and all widget's Amp-Out vals will be reset. If you play 2-channel files in 6 channel modes,there is noise in the jacks.

By doing experiments, I found that the 6-channel bug was caused by sharing channels.

If play 2-channel audio file,the rest channels will share channels with the first 2-channel.

Quoted 6 lines

The HDA spec doesn’t define the exact behavior under such circumstances.

Majority of the codec chips support sharing channel, but seem that AD1986A doesn’t support.

I wrote a patch and tested it in my hardware,now it works well.

Thanks! It's been a bug that I hardly understood what was wrong.

Quoted 5 lines

IMO, it's better to have a flag in hda_multi_out rather than hardcoding the codec id there.

Could you check whether the patch below works?

I have tested them and they are okay! Thanks!