Skip to contentSkip to conversation

fs/dlm/: proper prototypes

PATCH In review Adrian Bunk 3 participants 3 messages Nov 3, 2007 – Nov 7, 2007 Distributed lock manager (DLM)

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 fs/dlm/: proper prototypes

This patch adds a proper prototype for some functions in fs/dlm/dlm_internal.h

Signed-off-by Adrian Bunk <[email protected]>

---

 fs/dlm/dlm_internal.h |   16 ++++++++++++++++
 fs/dlm/lock.c         |    1 -
 fs/dlm/lockspace.c    |    8 --------
 fs/dlm/main.c         |   10 ----------
 4 files changed, 16 insertions(+), 19 deletions(-)

11349b53af8d04ff007660d9142e2382033f5d8f

fs/dlm/dlm_internal.h +16 -0
index d2fc238..ec61bba 100644
@@ -570,5 +570,21 @@ static inline int dlm_no_directory(struct dlm_ls *ls)
 	return (ls->ls_exflags & DLM_LSFL_NODIR) ? 1 : 0;
 }
 
+int dlm_netlink_init(void);
+void dlm_netlink_exit(void);
+void dlm_timeout_warn(struct dlm_lkb *lkb);
+
+#ifdef CONFIG_DLM_DEBUG
+int dlm_register_debugfs(void);
+void dlm_unregister_debugfs(void);
+int dlm_create_debug_file(struct dlm_ls *ls);
+void dlm_delete_debug_file(struct dlm_ls *ls);
+#else
+static inline int dlm_register_debugfs(void) { return 0; }
+static inline void dlm_unregister_debugfs(void) { }
+static inline int dlm_create_debug_file(struct dlm_ls *ls) { return 0; }
+static inline void dlm_delete_debug_file(struct dlm_ls *ls) { }
+#endif
+
 #endif				/* __DLM_INTERNAL_DOT_H__ */
fs/dlm/lock.c +0 -1
index 3915b8e..7bc6ad9 100644
@@ -88,7 +88,6 @@ static void __receive_convert_reply(struct dlm_rsb *r, struct dlm_lkb *lkb,
 static int receive_extralen(struct dlm_message *ms);
 static void do_purge(struct dlm_ls *ls, int nodeid, int pid);
 static void del_timeout(struct dlm_lkb *lkb);
-void dlm_timeout_warn(struct dlm_lkb *lkb);
 
 /*
  * Lock compatibilty matrix - thanks Steve
fs/dlm/lockspace.c +0 -8
index 6353a83..b99485b 100644
@@ -24,14 +24,6 @@
 #include "recover.h"
 #include "requestqueue.h"
 
-#ifdef CONFIG_DLM_DEBUG
-int dlm_create_debug_file(struct dlm_ls *ls);
-void dlm_delete_debug_file(struct dlm_ls *ls);
-#else
-static inline int dlm_create_debug_file(struct dlm_ls *ls) { return 0; }
-static inline void dlm_delete_debug_file(struct dlm_ls *ls) { }
-#endif
-
 static int			ls_count;
 static struct mutex		ls_lock;
 static struct list_head		lslist;
fs/dlm/main.c +0 -10
index eca2907..58487fb 100644
@@ -18,16 +18,6 @@
 #include "memory.h"
 #include "config.h"
 
-#ifdef CONFIG_DLM_DEBUG
-int dlm_register_debugfs(void);
-void dlm_unregister_debugfs(void);
-#else
-static inline int dlm_register_debugfs(void) { return 0; }
-static inline void dlm_unregister_debugfs(void) { }
-#endif
-int dlm_netlink_init(void);
-void dlm_netlink_exit(void);
-
 static int __init init_dlm(void)
 {
 	int error;
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 2 lines · Adrian Bunk

This patch adds a proper prototype for some functions in fs/dlm/dlm_internal.h

Acked-by David Teigland <[email protected]>
Quoted 89 lines
Signed-off-by Adrian Bunk <[email protected]>

---

 fs/dlm/dlm_internal.h |   16 ++++++++++++++++
 fs/dlm/lock.c         |    1 -
 fs/dlm/lockspace.c    |    8 --------
 fs/dlm/main.c         |   10 ----------
 4 files changed, 16 insertions(+), 19 deletions(-)

11349b53af8d04ff007660d9142e2382033f5d8f

fs/dlm/dlm_internal.h +16 -0
index d2fc238..ec61bba 100644
@@ -570,5 +570,21 @@ static inline int dlm_no_directory(struct dlm_ls *ls)
 	return (ls->ls_exflags & DLM_LSFL_NODIR) ? 1 : 0;
 }
 
+int dlm_netlink_init(void);
+void dlm_netlink_exit(void);
+void dlm_timeout_warn(struct dlm_lkb *lkb);
+
+#ifdef CONFIG_DLM_DEBUG
+int dlm_register_debugfs(void);
+void dlm_unregister_debugfs(void);
+int dlm_create_debug_file(struct dlm_ls *ls);
+void dlm_delete_debug_file(struct dlm_ls *ls);
+#else
+static inline int dlm_register_debugfs(void) { return 0; }
+static inline void dlm_unregister_debugfs(void) { }
+static inline int dlm_create_debug_file(struct dlm_ls *ls) { return 0; }
+static inline void dlm_delete_debug_file(struct dlm_ls *ls) { }
+#endif
+
 #endif				/* __DLM_INTERNAL_DOT_H__ */
fs/dlm/lock.c +0 -1
index 3915b8e..7bc6ad9 100644
@@ -88,7 +88,6 @@ static void __receive_convert_reply(struct dlm_rsb *r, struct dlm_lkb *lkb,
 static int receive_extralen(struct dlm_message *ms);
 static void do_purge(struct dlm_ls *ls, int nodeid, int pid);
 static void del_timeout(struct dlm_lkb *lkb);
-void dlm_timeout_warn(struct dlm_lkb *lkb);
 
 /*
  * Lock compatibilty matrix - thanks Steve
fs/dlm/lockspace.c +0 -8
index 6353a83..b99485b 100644
@@ -24,14 +24,6 @@
 #include "recover.h"
 #include "requestqueue.h"
 
-#ifdef CONFIG_DLM_DEBUG
-int dlm_create_debug_file(struct dlm_ls *ls);
-void dlm_delete_debug_file(struct dlm_ls *ls);
-#else
-static inline int dlm_create_debug_file(struct dlm_ls *ls) { return 0; }
-static inline void dlm_delete_debug_file(struct dlm_ls *ls) { }
-#endif
-
 static int			ls_count;
 static struct mutex		ls_lock;
 static struct list_head		lslist;
fs/dlm/main.c +0 -10
index eca2907..58487fb 100644
@@ -18,16 +18,6 @@
 #include "memory.h"
 #include "config.h"
 
-#ifdef CONFIG_DLM_DEBUG
-int dlm_register_debugfs(void);
-void dlm_unregister_debugfs(void);
-#else
-static inline int dlm_register_debugfs(void) { return 0; }
-static inline void dlm_unregister_debugfs(void) { }
-#endif
-int dlm_netlink_init(void);
-void dlm_netlink_exit(void);
-
 static int __init init_dlm(void)
 {
 	int error;
#2 lore raw

Hi,

I've added this to the GFS2 -nmw git tree and since Linus has released -rc2, I've rebased it to that at the same time. Thanks,

Steve.

Quoted 97 lines · David Teigland
Quoted 2 lines · Adrian Bunk

This patch adds a proper prototype for some functions in fs/dlm/dlm_internal.h

Acked-by David Teigland <[email protected]>
Quoted 89 lines
Signed-off-by Adrian Bunk <[email protected]>

---

 fs/dlm/dlm_internal.h |   16 ++++++++++++++++
 fs/dlm/lock.c         |    1 -
 fs/dlm/lockspace.c    |    8 --------
 fs/dlm/main.c         |   10 ----------
 4 files changed, 16 insertions(+), 19 deletions(-)

11349b53af8d04ff007660d9142e2382033f5d8f

fs/dlm/dlm_internal.h +16 -0
index d2fc238..ec61bba 100644
@@ -570,5 +570,21 @@ static inline int dlm_no_directory(struct dlm_ls *ls)
 	return (ls->ls_exflags & DLM_LSFL_NODIR) ? 1 : 0;
 }
 
+int dlm_netlink_init(void);
+void dlm_netlink_exit(void);
+void dlm_timeout_warn(struct dlm_lkb *lkb);
+
+#ifdef CONFIG_DLM_DEBUG
+int dlm_register_debugfs(void);
+void dlm_unregister_debugfs(void);
+int dlm_create_debug_file(struct dlm_ls *ls);
+void dlm_delete_debug_file(struct dlm_ls *ls);
+#else
+static inline int dlm_register_debugfs(void) { return 0; }
+static inline void dlm_unregister_debugfs(void) { }
+static inline int dlm_create_debug_file(struct dlm_ls *ls) { return 0; }
+static inline void dlm_delete_debug_file(struct dlm_ls *ls) { }
+#endif
+
 #endif				/* __DLM_INTERNAL_DOT_H__ */
fs/dlm/lock.c +0 -1
index 3915b8e..7bc6ad9 100644
@@ -88,7 +88,6 @@ static void __receive_convert_reply(struct dlm_rsb *r, struct dlm_lkb *lkb,
 static int receive_extralen(struct dlm_message *ms);
 static void do_purge(struct dlm_ls *ls, int nodeid, int pid);
 static void del_timeout(struct dlm_lkb *lkb);
-void dlm_timeout_warn(struct dlm_lkb *lkb);
 
 /*
  * Lock compatibilty matrix - thanks Steve
fs/dlm/lockspace.c +0 -8
index 6353a83..b99485b 100644
@@ -24,14 +24,6 @@
 #include "recover.h"
 #include "requestqueue.h"
 
-#ifdef CONFIG_DLM_DEBUG
-int dlm_create_debug_file(struct dlm_ls *ls);
-void dlm_delete_debug_file(struct dlm_ls *ls);
-#else
-static inline int dlm_create_debug_file(struct dlm_ls *ls) { return 0; }
-static inline void dlm_delete_debug_file(struct dlm_ls *ls) { }
-#endif
-
 static int			ls_count;
 static struct mutex		ls_lock;
 static struct list_head		lslist;
fs/dlm/main.c +0 -10
index eca2907..58487fb 100644
@@ -18,16 +18,6 @@
 #include "memory.h"
 #include "config.h"
 
-#ifdef CONFIG_DLM_DEBUG
-int dlm_register_debugfs(void);
-void dlm_unregister_debugfs(void);
-#else
-static inline int dlm_register_debugfs(void) { return 0; }
-static inline void dlm_unregister_debugfs(void) { }
-#endif
-int dlm_netlink_init(void);
-void dlm_netlink_exit(void);
-
 static int __init init_dlm(void)
 {
 	int error;