Fix used_idx wrap-around in virtio
PATCH 1/1 Fix used_idx wrap-around in virtio
The more_used() function compares the vq->vring.used->idx with last_used_idx. Since vq->vring.used->idx is a 16-bit integer, and last_used_idx is an unsigned int, this results in unpredictable behavior when vq->vring.used->idx wraps around.
This patch corrects this by changing last_used_idx to the correct type.
Signed-off-by Anthony Liguori <[email protected]>
drivers/virtio/virtio_ring.c +1 -1
@@ -53,7 +53,7 @@ struct vring_virtqueueunsigned int num_added;/* Last used index we've seen. */ -unsigned int last_used_idx; +u16 last_used_idx;/* How to notify other side. FIXME: commonalize hcalls! */ void (*notify)(struct virtqueue *vq);