pm: make PM_TRACE more architecture independent
Subsystems (4)
PATCH 1/1 pm: make PM_TRACE more architecture independent
When trying to debug a suspend failure I started implementing PM_TRACE for powerpc. I then noticed that I'm debugging a suspend failure and so PM_TRACE isn't useful at all, but thought that nonetheless this could be useful in the future.
Basically, to support PM_TRACE, you add a Kconfig option that selects PM_TRACE and provides the infrastructure as per the help text of PM_TRACE.
---
I don't really care much. I can let this patch collect dust until I actually want to implement PM_TRACE for powerpc or another architecture but since I had it I wanted to send it out too.
drivers/base/power/Makefile | 2 +- kernel/power/Kconfig | 23 ++++++++++++++++++++++- 2 files changed, 23 insertions(+), 2 deletions(-)
drivers/base/power/Makefile +1 -1
@@ -1,6 +1,6 @@ obj-y := shutdown.o obj-$(CONFIG_PM_SLEEP) += main.o sysfs.o -obj-$(CONFIG_PM_TRACE) += trace.o +obj-$(CONFIG_PM_TRACE_RTC) += trace.o ifeq ($(CONFIG_DEBUG_DRIVER),y) EXTRA_CFLAGS += -DDEBUG
kernel/power/Kconfig +22 -1
@@ -44,9 +44,30 @@ config PM_VERBOSE ---help--- This option enables verbose messages from the Power Management code. +config CAN_PM_TRACE + def_bool y + depends on PM_DEBUG && PM_SLEEP && EXPERIMENTAL + config PM_TRACE + bool + help + This enables code to save the last PM event point across + reboot. The architecture needs to support this, x86 for + example does by saving things in the RTC, see below. + + The architecture specific code must provide the extern + functions from <linux/resume-trace.h> as well as the + <asm/resume-trace.h> header with a TRACE_RESUME() macro. + + The way the information is presented is architecture- + dependent, x86 will print the information during a + late_initcall. + +config PM_TRACE_RTC bool "Suspend/resume event tracing" - depends on PM_DEBUG && X86 && PM_SLEEP && EXPERIMENTAL + depends on CAN_PM_TRACE + depends on X86 + select PM_TRACE default n ---help--- This enables some cheesy code to save the last PM event point in the
Quoted 11 lines · Johannes Berg
When trying to debug a suspend failure I started implementing
PM_TRACEfor powerpc. I then noticed that I'm debugging a suspend failure and soPM_TRACEisn't useful at all, but thought that nonetheless this could be useful in the future.Basically, to support
PM_TRACE, you add aKconfigoption that selectsPM_TRACEand provides the infrastructure as per the help text ofPM_TRACE.Signed-off-by Johannes Berg <[email protected]>
Quoted 58 lines
Cc Linus Torvalds <[email protected]>---
I don't really care much. I can let this patch collect dust until I actually want to implementPM_TRACEfor powerpc or another architecture but since I had it I wanted to send it out too.drivers/base/power/Makefile | 2 +- kernel/power/Kconfig | 23 ++++++++++++++++++++++- 2 files changed, 23 insertions(+), 2 deletions(-)drivers/base/power/Makefile +1
-1@@ -1,6 +1,6 @@ obj-y := shutdown.o obj-$(CONFIG_PM_SLEEP) += main.o sysfs.o -obj-$(CONFIG_PM_TRACE) += trace.o +obj-$(CONFIG_PM_TRACE_RTC) += trace.o ifeq ($(CONFIG_DEBUG_DRIVER),y) EXTRA_CFLAGS += -DDEBUGkernel/power/Kconfig +22
-1@@ -44,9 +44,30 @@ config PM_VERBOSE ---help--- This option enables verbose messages from the Power Management code. +config CAN_PM_TRACE + def_bool y + depends on PM_DEBUG && PM_SLEEP && EXPERIMENTAL + config PM_TRACE + bool + help + This enables code to save the last PM event point across + reboot. The architecture needs to support this, x86 for + example does by saving things in the RTC, see below. + + The architecture specific code must provide the extern + functions from <linux/resume-trace.h> as well as the + <asm/resume-trace.h> header with a TRACE_RESUME() macro. + + The way the information is presented is architecture- + dependent, x86 will print the information during a + late_initcall. + +config PM_TRACE_RTC bool "Suspend/resume event tracing" - depends on PM_DEBUG && X86 && PM_SLEEP && EXPERIMENTAL + depends on CAN_PM_TRACE + depends on X86 + select PM_TRACE default n ---help--- This enables some cheesy code to save the last PM event point in the
Signature · 1 line
"Premature optimization is the root of all evil." - Donald Knuth